From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Marcel Ziswiler <marcel@ziswiler.com>,
linux-tegra@vger.kernel.org, linux-can@vger.kernel.org
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] apalis_t30: fix can2
Date: Mon, 23 Jul 2018 10:16:23 +0200 [thread overview]
Message-ID: <c511af9e-e0d5-f7d8-e6cc-92ea0df7a290@pengutronix.de> (raw)
In-Reply-To: <20180625075948.32040-1-marcel@ziswiler.com>
[-- Attachment #1.1: Type: text/plain, Size: 1282 bytes --]
On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> CAN2 currently fails on probe as follows:
>
> mcp251x spi1.1: Probe failed, err=19
>
> Fix this by enabling input on pin mux of resp. SPI4 pins.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
I can take this via the linux-can tree. Any acks from the DT people?
Marc
>
> ---
>
> arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index d1d21ec2a844..9ff6aafd72b3 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -118,6 +118,7 @@
> nvidia,function = "spi4";
> nvidia,pull = <TEGRA_PIN_PULL_NONE>;
> nvidia,tristate = <TEGRA_PIN_DISABLE>;
> + nvidia,enable-input = <TEGRA_PIN_ENABLE>;
> };
> /* CAN_INT2 */
> spi2_cs2_n_pw3 {
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-23 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 7:59 [PATCH] apalis_t30: fix can2 Marcel Ziswiler
2018-07-23 8:16 ` Marc Kleine-Budde [this message]
2018-07-23 10:18 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c511af9e-e0d5-f7d8-e6cc-92ea0df7a290@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).