From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] memory: Add Broadcom STB memory controller driver
Date: Fri, 12 Aug 2022 21:41:22 +0300 [thread overview]
Message-ID: <c51c360e-a73f-9333-ffa1-3461de29f41f@linaro.org> (raw)
In-Reply-To: <ec06e9c6-f475-fe19-9046-d57a6168e72b@gmail.com>
On 12/08/2022 20:52, Florian Fainelli wrote:
>>> unless you also implied enclosing those functions under an #if
>>> IS_ENABLED(CONFIG_PM) or something which is IMHO less preferable.
>>
>> Are you sure you added also pm_ptr()? I don't see such warnings with W=1
>> and final object does not have the functions (for a different driver but
>> same principle).
>
> Yes I am sure I added pm_ptr() see the v4 I just submitted. I don't see
> how the compiler cannot warn about the functions being unused the day
> they stop being referenced by the pm_ops structure which is eliminated?
I don't have the answer how it exactly works (or which gcc version
introduced it), but I tested it and the functions were not present in
the object file, thus of course no warnings.
The driver change I am referring to is:
https://lore.kernel.org/all/20220808174107.38676-15-paul@crapouillou.net/
I think the only difference against your v4 is:
DEFINE_SIMPLE_DEV_PM_OPS
and lack of __maybe_unused on the functions.
The DEFINE_SIMPLE_DEV_PM_OPS itself adds __maybe_unused for !CONFIG_PM
case, but I don't think it is relevant.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-12 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 22:09 [PATCH v3 0/3] Add Broadcom STB memory controller driver Florian Fainelli
2022-08-01 22:09 ` [PATCH v3 1/3] dt-bindings: memory-controller: Document Broadcom STB MEMC Florian Fainelli
2022-08-01 22:09 ` [PATCH v3 2/3] Documentation: sysfs: Document Broadcom STB memc sysfs knobs Florian Fainelli
2022-08-01 22:09 ` [PATCH v3 3/3] memory: Add Broadcom STB memory controller driver Florian Fainelli
2022-08-09 9:58 ` Krzysztof Kozlowski
2022-08-12 17:29 ` Florian Fainelli
2022-08-12 17:36 ` Krzysztof Kozlowski
2022-08-12 17:52 ` Florian Fainelli
2022-08-12 18:41 ` Krzysztof Kozlowski [this message]
2022-08-12 22:22 ` Florian Fainelli
2022-08-16 7:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51c360e-a73f-9333-ffa1-3461de29f41f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).