Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/11/2022 03:31, Nicholas Roth wrote:
> Add a device tree binding for the Omnivision OV8858 image sensor.
> The OV8858 is an 8 megapixel image sensor which provides images in RAW
> format over MIPI CSI-2 data bus and is controlled through an
> I2C-compatibile SCCB bus.
> 
> Tested on PinePhone Pro with libcamera cam and qcam.

How can you test bindings with libcamera?
> 
> Signed-off-by: Nicholas Roth <nicholas@rothemail.net>

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

1. There is no driver, no DTS. You received the feedback about it.
2. Wrong cc list. You were asked to use get_maintainers.pl and still
decide not to.

> ---
>  .../devicetree/bindings/media/i2c/ov8858.yaml | 139 ++++++++++++++++++
>  1 file changed, 139 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8858.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8858.yaml b/Documentation/devicetree/bindings/media/i2c/ov8858.yaml
> new file mode 100644
> index 000000000000..f004e57b05ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8858.yaml
> @@ -0,0 +1,139 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ov8858.yaml#

Filename still does not match compatible. ovti,ov8858.yaml

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings
> +
> +maintainers:
> +  - Nicholas Roth <nicholas@rothemail.net>
> +
> +description: |-
> +  The Omnivision OV8858 is an 8 megapixel image sensor which provides
> +  images in RAW format over MIPI CSI-2 data bus with up to 4 lanes
> +  and is controlled through an I2C-compatibile SCCB bus.
> +
> +properties:
> +  compatible:
> +    const: ovti,ov8858
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    description:
> +      Input clock for the sensor.
> +    items:
> +      - const: xvclk
> +
> +  clock-frequency:
> +    description:
> +      Frequency of the xvclk clock in Hertz.

The frequency of clock should go via common clock framework - you have
get_rate and set_rate. Drop entire property.

> +    minimum: 6000000
> +    default: 24000000
> +    maximum: 27000000
> +
> +  dovdd-supply:
> +    description:
> +      Definition of the regulator used as interface power supply.

Drop "Definition of the regulator used as "

> +
> +  avdd-supply:
> +    description:
> +      Definition of the regulator used as analog power supply.
> +
> +  dvdd-supply:
> +    description:
> +      Definition of the regulator used as digital power supply.
> +
> +  reset-gpios:
> +    description:
> +      The phandle and specifier for the GPIO that controls sensor reset.

Drop this sentence.

> +      This corresponds to the hardware pin XSHUTDN which is physically
> +      active low.
> +
> +  powerdown-gpios:
> +    description:
> +      The phandle and specifier for the GPIO that controls power down.

Drop this sentence.

> +      This corresponds to the hardware pin PWDNB which is physically
> +      active low.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            description: |-
> +              The driver supports both two- and four-lane operation.

Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.

> +            items:
> +              - const: 1
> +              - const: 2
> +              - const: 3
> +              - const: 4
> +
> +          link-frequencies:
> +            description: Frequencies listed are driver, not h/w limitations.

If these are driver limitations, then drop it. Link frequencies are
hardware related and you should here describe the minimum and maximum.
Or leave it empty if any is allowed by hardware.


> +            maxItems: 1
> +            items:
> +              enum: [ 360000000 ]
> +
> +        required:
> +          - link-frequencies
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - clock-frequency
> +  - dovdd-supply
> +  - avdd-supply
> +  - dvdd-supply
> +  - reset-gpios
> +  - port
> +
> +additionalProperties: false

Best regards,
Krzysztof