From: Johan Jonker <jbx6244@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>, heiko@sntech.de
Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, paweljarosz3691@gmail.com
Subject: Re: [PATCH] ARM: dts: rockchip: remove cap-mmc-highspeed property from mk808 &mmc0 node
Date: Fri, 20 Aug 2021 16:41:32 +0200 [thread overview]
Message-ID: <c52b4cf0-d018-f6b4-8728-41551b8bf62b@gmail.com> (raw)
In-Reply-To: <bf6cba99-da3b-a6fe-4e4b-f4ea6e3c6e63@arm.com>
On 8/20/21 4:17 PM, Robin Murphy wrote:
> On 2021-08-20 14:19, Johan Jonker wrote:
>> On the MK808 only a microSD slot is connected with the SDMMC Host
>> Controller,
>> so remove the cap-mmc-highspeed property from the &mmc0 node.
>
> Why, does it do any harm?
Harm not. Example rk3066 u-boot:
>>>>sd_select_mode_and_width
sd card: widths [4, 1, \b\b] modes [MMC legacy, SD High Speed (50MHz), UHS
SDR12 (25MHz), UHS SDR25 (50MHz), \b\b]
host: widths [4, 1, \b\b] modes [MMC legacy, MMC High Speed (26MHz), SD
High Speed (50MHz), MMC High Speed (52MHz), \b\b]
trying mode SD High Speed (50MHz) width 4 (at 50 MHz)
I would say only advertise host capabilities that are under normal
circumstances occur. How realistic is it to use a TF/Micro SD TO SD Card
Extension Cable Adapter (giggle) for a deprecated mmc card?
Johan
It's perfectly possible to connect a
> full-sized card to a microSD slot with an adapter. I came across my old
> SDIO WiFi card a while back and tried it that way for a giggle, but
> unfortunately it turned out not to be a chipset supported by any
> upstream driver.
>
> Robin.
>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> arch/arm/boot/dts/rk3066a-mk808.dts | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts
>> b/arch/arm/boot/dts/rk3066a-mk808.dts
>> index 9790bc63b..b67f5cb51 100644
>> --- a/arch/arm/boot/dts/rk3066a-mk808.dts
>> +++ b/arch/arm/boot/dts/rk3066a-mk808.dts
>> @@ -123,7 +123,6 @@
>> &mmc0 {
>> bus-width = <4>;
>> - cap-mmc-highspeed;
>> cap-sd-highspeed;
>> vmmc-supply = <&vcc_sd>;
>> status = "okay";
>>
next prev parent reply other threads:[~2021-08-20 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 13:19 [PATCH] ARM: dts: rockchip: remove cap-mmc-highspeed property from mk808 &mmc0 node Johan Jonker
2021-08-20 14:17 ` Robin Murphy
2021-08-20 14:41 ` Johan Jonker [this message]
2021-08-20 14:49 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52b4cf0-d018-f6b4-8728-41551b8bf62b@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paweljarosz3691@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).