From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A98C43334 for ; Mon, 6 Jun 2022 11:16:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235139AbiFFLQQ (ORCPT ); Mon, 6 Jun 2022 07:16:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235144AbiFFLQP (ORCPT ); Mon, 6 Jun 2022 07:16:15 -0400 X-Greylist: delayed 908 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 06 Jun 2022 04:16:11 PDT Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B562224DE62; Mon, 6 Jun 2022 04:16:10 -0700 (PDT) Received: from [192.168.1.103] (31.173.84.0) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Mon, 6 Jun 2022 14:00:56 +0300 Subject: Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle To: Harsh Agarwal , Greg Kroah-Hartman , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Felipe Balbi , Bjorn Andersson CC: , , , , , , References: <1654276362-28930-1-git-send-email-quic_harshq@quicinc.com> <1654276362-28930-3-git-send-email-quic_harshq@quicinc.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Mon, 6 Jun 2022 14:00:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1654276362-28930-3-git-send-email-quic_harshq@quicinc.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.84.0] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 06/06/2022 10:38:49 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 170918 [Jun 06 2022] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 482 482 6622156fb2e4848883fa5c715ac8f6ff125fd631 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;31.173.84.0:7.1.2;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.84.0 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/06/2022 10:41:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 6/6/2022 9:18:00 AM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello! On 6/3/22 8:12 PM, Harsh Agarwal wrote: > Adding support for devm_of_usb_get_phy_by_phandle which allows > us to get PHY phandles of a device declared inside lookup_node. > > Signed-off-by: Harsh Agarwal [...] > diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h > index e4de6bc..2581c72 100644 > --- a/include/linux/usb/phy.h > +++ b/include/linux/usb/phy.h [...] > @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, > return ERR_PTR(-ENXIO); > } > > +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev, *extern inline*? :-O Shouldn't it be *static*? > + const char *phandle, u8 index, struct device_node *lookup_node) > +{ > + return ERR_PTR(-ENXIO); > +} > + > static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev, > struct device_node *node, struct notifier_block *nb) > { MBR, Sergey