From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org, vkoul@kernel.org,
kishon@kernel.org, arnd@arndb.de, geert+renesas@glider.be,
nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v9 3/4] arm64: dts: qcom: ipq5332: Enable USB
Date: Tue, 22 Aug 2023 13:39:01 +0200 [thread overview]
Message-ID: <c534e39f-f8dc-b9eb-ef27-3ace29192cfc@linaro.org> (raw)
In-Reply-To: <27d6303008be83131048ddf2ecef91cec9519ee2.1692699472.git.quic_varada@quicinc.com>
On 22/08/2023 12:29, Varadarajan Narayanan wrote:
> Enable USB2 in host mode.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v9:
> regulator_fixed_5p0: s0500 -> regulator_fixed_5p0: regulator_s0500
> "make ARCH=arm64 -j 16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml dtbs_check" passed
> v6:
> Add vdd-supply and corresponding regulator
> v1:
> Enable usb-phy node
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> index f96b0c8..53696f4 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> @@ -12,6 +12,15 @@
> / {
> model = "Qualcomm Technologies, Inc. IPQ5332 MI01.6";
> compatible = "qcom,ipq5332-ap-mi01.6", "qcom,ipq5332";
> +
> + regulator_fixed_5p0: regulator_s0500 {
No underscores in node names. If you look at any source code, you will
notice lack of them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-22 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 10:29 [PATCH v9 0/4] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-08-22 10:29 ` [PATCH v9 1/4] phy: qcom: m31: Fix indentation issues Varadarajan Narayanan
2023-08-22 10:55 ` Dmitry Baryshkov
2023-08-22 11:33 ` Dmitry Baryshkov
2023-08-22 11:47 ` Krzysztof Kozlowski
2023-08-22 10:29 ` [PATCH v9 2/4] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-08-22 11:40 ` Krzysztof Kozlowski
2023-08-23 5:18 ` Varadarajan Narayanan
2023-08-22 10:29 ` [PATCH v9 3/4] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-08-22 11:39 ` Krzysztof Kozlowski [this message]
2023-08-22 10:29 ` [PATCH v9 4/4] arm64: defconfig: Enable M31 USB phy driver Varadarajan Narayanan
2023-08-22 11:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c534e39f-f8dc-b9eb-ef27-3ace29192cfc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=peng.fan@nxp.com \
--cc=quic_varada@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).