From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: Re: [PATCH 3/4] arm64: dts: ti: k3-j721e-main: Add mailbox cluster nodes Date: Tue, 23 Jul 2019 12:54:39 -0500 Message-ID: References: <20190722202024.14867-1-s-anna@ti.com> <20190722202024.14867-4-s-anna@ti.com> <20190723113729.gkgq3kf2mman5m4q@kahuna> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190723113729.gkgq3kf2mman5m4q@kahuna> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Nishanth Menon Cc: Tero Kristo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 7/23/19 6:37 AM, Nishanth Menon wrote: > On 15:20-20190722, Suman Anna wrote: >> The J721E Main NavSS block contains a Mailbox IP instance with >> multiple clusters. Each cluster is equivalent to an Mailbox IP >> instance on OMAP platforms. >> >> Add all the Mailbox clusters as their own nodes under the MAIN >> NavSS cbass_main_navss interconnect node instead of creating an >> almost empty parent node for the new K3 mailbox IP and the clusters >> as its child nodes. All these nodes are marked as disabled, and >> they need to be enabled along with the appropriate child nodes >> on a need basis. >> >> NOTE: >> The NavSS only has a limited number of interrupts, so all the >> interrupts generated by a Mailbox IP are not added by default. >> Only the needed interrupts that are targeted towards the A72 >> GIC will need to be be added later on when some sub-mailbox >> child nodes are added. >> >> Signed-off-by: Suman Anna >> --- >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 108 ++++++++++++++++++++++ >> 1 file changed, 108 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> index a2e031f7d88e..319d423b3440 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> @@ -95,6 +95,114 @@ >> reg = <0x00 0x30e00000 0x00 0x1000>; >> #hwlock-cells = <1>; >> }; >> + >> + mailbox0_cluster0: mailbox@31f80000 { >> + compatible = "ti,am654-mailbox"; >> + reg = <0x00 0x31f80000 0x00 0x200>; >> + #mbox-cells = <1>; >> + ti,mbox-num-users = <4>; >> + ti,mbox-num-fifos = <16>; >> + status = "disabled"; > > Please drop disabled. Same comment as on the AM65x patch (patch 1). regards Suman