From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C254527511A for ; Mon, 19 May 2025 15:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747667503; cv=none; b=WSbnfWl2jRINxxtI/7rEATw5bdrbkDCrfbchrM5bBr3QC5dn2B9VcLBq/viAkGmp83hdaPgdNU2+RuCeezGNfzqhbtwATihNXRSDmAZaizS+cI65Z+asZDYFWBQxZaRpKCLv0WdnHZqAKH6wlh4VkZDsPT9FPqzEnaCuva3QJ4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747667503; c=relaxed/simple; bh=E76LtS5mMrCQmyQwql/VpDooXGYuDZwoELGSsjzXeB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HR0S0q23fu/lZ7lkujMqCvb5jfKpH4qBBiHxxk8xmieJ2luRojnD1SrLj2BVz+asAtVsV8YW6ASZ2xhxrifvi9hOZngyz30ENZG7M9TJFjkVyVv+4I7gWlFQ4ussZA9IJcvJlMP3dkS1hqnrMTSb1MnaAeDJPwFtXe1Yh3KvENs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yyLc0eby; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yyLc0eby" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-60169001e0cso594808a12.2 for ; Mon, 19 May 2025 08:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747667499; x=1748272299; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Yv2jL2CIgoQgCOrnHWOAEQ/yU7hN35XKLb9t90BK5zA=; b=yyLc0ebyps8o30UKt8jvJQPzFnrqh5gqMK2rgv8LMRELthCbsPsac1llVv+q+qdaI/ tb4ZB8r0xedQSLtxutErY7BaMmeONwaP9IScmRIQCpq41rizpxeCrN9bGuyAIzixzExh z6RRBzJjEjEz9kMNkCqkgMcNCvmgZSFvJ7oVJc0oCs1XT6oKGpv3DEtlkERKp4E1vMHw SxmRasRQ+GUxfflO47mLrzB54vePfVJ6dOPZgrLZNyBXtDRDjbWLHrdXCriQHBPqeUgY zTtzgyc0oy9rjWQZjvAOXWl8v8wB3MhZLRUU17bRSU0JygqF64hy5JizJKlXy41FPapW rquw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747667499; x=1748272299; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yv2jL2CIgoQgCOrnHWOAEQ/yU7hN35XKLb9t90BK5zA=; b=s1nBhl0D+UrnTef8/mlXEer/XDfA/C8DO+2A1AxRZ0pnCJVT0DBhErhYSAilPRCR4q u37jGGsf3jO/29YmF3hRkNLY05tjkckBj5HkGPr8Ci0EOuXgHgiqhrgi1AbjNVZBAaFu 5XApTmqbXXd+2KSd4YQewtIQ9pBuK4G31S1GGVlQrzMf6MfwH3D6LFjUrF7aSmRWiKJd 8H4ywfYqVak7iKaRL8iUzB+Z82s2qpxm+zP9SdHceV1Kk7fZ2dPBnQfft39oVTIMZBJK bgoKoi/N8GJRW7wsl0miwtgN9Nbja1iTGWMVLE5FRRNd5PK8OahuwJJdQXRjWdXZTJVE KSYA== X-Forwarded-Encrypted: i=1; AJvYcCV25IjsPN2uyKMg0Ovn0HGnmNE6XrmgJ/NcOXQjfXXEpni8dEMTTLSJR3NvAluSEtZ7gDLtSTQsSZsz@vger.kernel.org X-Gm-Message-State: AOJu0YwCSAOkxCu5IsJgZ/Prbny1SBSpzAldilxxVGWHPvYKxIMRzeed 9RyOlB8RxPzqm/8OzzhUQgyIKF3d3yGdFFd0XnUPmSY6bEHVVl4pR/xDTHFQGCckcig= X-Gm-Gg: ASbGnctjGeZIijQnD0Qh2TzdM2rF/ACmJvfHHWxe/GAdEjYWmW/njTVIblD/KdGDkOi jOTfZHvG3V4I3Ltg1bvJDkYsyEI3PgmldwdqvCIWJHY6cE2UdWVjPvIMBf+zpT6cxj1GQ7qxWK1 48y3vNgK9OFpo5Byh6NEYshhNmjbaKoGr9Mg7nuFbLDPImUuuRVFKquNMxeVF9KJxGUJz4qKhI7 BKaOqb0WpNL1kXQxGroSfY1I+ce2/jjTarvCnkTqIe3FVcyRfUcil4OlXoMegdxhrq49kHy+8jM rD20QpiGbelUMReJWpB1cKGXlitvVrq0PeDjqykWSzdAYkVXjZnzXQTS0FLVq3bbDFJ5IXs= X-Google-Smtp-Source: AGHT+IEJp0HK+RclBsl7yhDxHBPPtCcr2CtN7uGmWtAaF+rtTBS/afg6uPSghq1UwkKLGWMcmuWwWw== X-Received: by 2002:a05:6402:270c:b0:600:caf:51e5 with SMTP id 4fb4d7f45d1cf-6009010e282mr4547796a12.8.1747667499003; Mon, 19 May 2025 08:11:39 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4381d5sm611186666b.99.2025.05.19.08.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 08:11:38 -0700 (PDT) Message-ID: Date: Mon, 19 May 2025 17:11:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/24] drm/msm/dsi: Add support for SM8750 To: Abhinav Kumar , Dmitry Baryshkov Cc: Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , Rob Clark , Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , linux-clk@vger.kernel.org, Srinivas Kandagatla References: <20250430-b4-sm8750-display-v5-0-8cab30c3e4df@linaro.org> <20250430-b4-sm8750-display-v5-19-8cab30c3e4df@linaro.org> <65710c50-9bfc-42e8-afad-ac01c7f96a9e@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+AhsD BQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmgXUEoF CRaWdJoACgkQG5NDfTtBYpudig/+Inb3Kjx1B7w2IpPKmpCT20QQQstx14Wi+rh2FcnV6+/9 tyHtYwdirraBGGerrNY1c14MX0Tsmzqu9NyZ43heQB2uJuQb35rmI4dn1G+ZH0BD7cwR+M9m lSV9YlF7z3Ycz2zHjxL1QXBVvwJRyE0sCIoe+0O9AW9Xj8L/dmvmRfDdtRhYVGyU7fze+lsH 1pXaq9fdef8QsAETCg5q0zxD+VS+OoZFx4ZtFqvzmhCs0eFvM7gNqiyczeVGUciVlO3+1ZUn eqQnxTXnqfJHptZTtK05uXGBwxjTHJrlSKnDslhZNkzv4JfTQhmERyx8BPHDkzpuPjfZ5Jp3 INcYsxgttyeDS4prv+XWlT7DUjIzcKih0tFDoW5/k6OZeFPba5PATHO78rcWFcduN8xB23B4 WFQAt5jpsP7/ngKQR9drMXfQGcEmqBq+aoVHobwOfEJTErdku05zjFmm1VnD55CzFJvG7Ll9 OsRfZD/1MKbl0k39NiRuf8IYFOxVCKrMSgnqED1eacLgj3AWnmfPlyB3Xka0FimVu5Q7r1H/ 9CCfHiOjjPsTAjE+Woh+/8Q0IyHzr+2sCe4g9w2tlsMQJhixykXC1KvzqMdUYKuE00CT+wdK nXj0hlNnThRfcA9VPYzKlx3W6GLlyB6umd6WBGGKyiOmOcPqUK3GIvnLzfTXR5DOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: <65710c50-9bfc-42e8-afad-ac01c7f96a9e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/05/2025 23:28, Abhinav Kumar wrote: >>> static int dsi_clk_init(struct msm_dsi_host *msm_host) >>> { Dmitry, Please kindly trim the replies from unnecessary context. It makes it much easier to find new content. >>> struct platform_device *pdev = msm_host->pdev; >>> @@ -370,6 +411,46 @@ int dsi_link_clk_set_rate_6g(struct msm_dsi_host *msm_host) >>> return 0; >>> } >>> >>> +int dsi_link_clk_set_rate_6g_v2_9(struct msm_dsi_host *msm_host) >>> +{ >>> + struct device *dev = &msm_host->pdev->dev; >>> + int ret; >>> + >>> + /* >>> + * DSI PHY PLLs have to be enabled to allow reparenting to them and >>> + * setting the rates of pixel/byte clocks. >>> + */ >> >> According to the docs this should be handled by the >> CLK_OPS_PARENT_ENABLE flag. Please correct me if I'm wrong. >> > > I am also interested to know that if we are indeed setting > CLK_OPS_PARENT_ENABLE flag, do we need this logic in the dsi driver. > > If CLK_OPS_PARENT_ENABLE flag is not working as expected, shouldnt this > be something fixed on the clk fwk side? > You are both right - CLK_OPS_PARENT_ENABLE handles this and I just did not test that exact case (fixed dispcc driver, here dropping clk_prepare_enable). Best regards, Krzysztof