From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Ajit Pandey <ajitp@codeaurora.org>,
Cheng-Yi Chiang <cychiang@chromium.org>,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver
Date: Fri, 18 Sep 2020 22:16:21 +0530 [thread overview]
Message-ID: <c55995fa-5233-b1c9-7c4c-13b5cd8fe178@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=WtSEB6-M8x564t=RuSEKHwH3YvcmuZ9VGpxY+5kcL7rA@mail.gmail.com>
Thanks Mr. Doug for Review comments!!
On 9/18/2020 7:28 PM, Doug Anderson wrote:
> Hi,
>
> On Fri, Sep 18, 2020 at 6:18 AM Srinivasa Rao Mandadapu
> <srivasam@codeaurora.org> wrote:
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -1742,6 +1742,45 @@
>> };
>> };
>>
>> + sec_mi2s_active: sec-mi2s-active {
>> + pinmux {
>> + pins = "gpio49", "gpio50", "gpio51";
>> + function = "mi2s_1";
>> + };
>> +
>> + pinconf {
>> + pins = "gpio49", "gpio50", "gpio51";;
> There are still two ";" on the above line.
will fix this type error.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-09-18 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:17 [PATCH v3] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver Srinivasa Rao Mandadapu
2020-09-18 13:58 ` Doug Anderson
2020-09-18 16:46 ` Srinivasa Rao Mandadapu [this message]
2020-09-18 15:20 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55995fa-5233-b1c9-7c4c-13b5cd8fe178@codeaurora.org \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox