[PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console
@ 2023-02-14 16:12 Robert Marko
  2023-02-14 16:12 ` [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema Robert Marko
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Robert Marko @ 2023-02-14 16:12 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov, Robert Marko

Add the required alias and stdout property so that kernel can setup
the console based off DTS and not have to set it in the cmdline.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
index a5a6f3ebb2749..38efd45433da5 100644
--- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
@@ -8,6 +8,14 @@ / {
 	model = "ALFA Network AP120C-AC";
 	compatible = "alfa-network,ap120c-ac", "qcom,ipq4018";
 
+	aliases {
+		serial0 = &blsp1_uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	keys {
 		compatible = "gpio-keys";
 
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema
  2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
@ 2023-02-14 16:12 ` Robert Marko
  2023-02-16 10:48   ` Konrad Dybcio
  2023-02-14 16:12 ` [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND " Robert Marko
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Robert Marko @ 2023-02-14 16:12 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov, Robert Marko

Align USB power GPIO hog node to DT schema.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
index 38efd45433da5..cd2a32d0d5548 100644
--- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
@@ -76,7 +76,7 @@ mux_cs {
 		};
 	};
 
-	usb-power {
+	usb-power-hog {
 		line-name = "USB-power";
 		gpios = <1 GPIO_ACTIVE_HIGH>;
 		gpio-hog;
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema
  2023-02-14 16:12 ` [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema Robert Marko
@ 2023-02-16 10:48   ` Konrad Dybcio
  2023-02-16 10:59     ` Robert Marko
  0 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:48 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov



On 14.02.2023 17:12, Robert Marko wrote:
> Align USB power GPIO hog node to DT schema.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Unless you submitted a separate patch for this, I only see
hog being allowed in 845 TLMM.

Konrad
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> index 38efd45433da5..cd2a32d0d5548 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> @@ -76,7 +76,7 @@ mux_cs {
>  		};
>  	};
>  
> -	usb-power {
> +	usb-power-hog {
>  		line-name = "USB-power";
>  		gpios = <1 GPIO_ACTIVE_HIGH>;
>  		gpio-hog;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema
  2023-02-16 10:48   ` Konrad Dybcio
@ 2023-02-16 10:59     ` Robert Marko
  0 siblings, 0 replies; 9+ messages in thread
From: Robert Marko @ 2023-02-16 10:59 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: agross, andersson, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
	devicetree, linux-kernel, luka.perkov

On Thu, Feb 16, 2023 at 11:48 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.02.2023 17:12, Robert Marko wrote:
> > Align USB power GPIO hog node to DT schema.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> Unless you submitted a separate patch for this, I only see
> hog being allowed in 845 TLMM.

No, cause there is a gpio-hog schema in dtschema and I did not
even look into the pinctrl bindings and dtbs_check is not throwing
a warning.

I dont really see a point further allowing it in pinctrl bindings.

Regards,
Robert
>
> Konrad
> >  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > index 38efd45433da5..cd2a32d0d5548 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > @@ -76,7 +76,7 @@ mux_cs {
> >               };
> >       };
> >
> > -     usb-power {
> > +     usb-power-hog {
> >               line-name = "USB-power";
> >               gpios = <1 GPIO_ACTIVE_HIGH>;
> >               gpio-hog;



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND with DT schema
  2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
  2023-02-14 16:12 ` [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema Robert Marko
@ 2023-02-14 16:12 ` Robert Marko
  2023-02-16 10:46   ` Konrad Dybcio
  2023-02-14 16:12 ` [PATCH 4/4] ARM: dts: qcom: ipq4018-ap120c-ac: use NVMEM for ath10k caldata Robert Marko
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Robert Marko @ 2023-02-14 16:12 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov, Robert Marko

SPI-NAND node name should be flash@1 and not nand@1 according to schema.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
index cd2a32d0d5548..bb0c888b048ec 100644
--- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
@@ -186,7 +186,7 @@ partition@190000 {
 		};
 	};
 
-	nand@1 {
+	flash@1 {
 		compatible = "spi-nand";
 		reg = <1>;
 		spi-max-frequency = <40000000>;
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND with DT schema
  2023-02-14 16:12 ` [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND " Robert Marko
@ 2023-02-16 10:46   ` Konrad Dybcio
  0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:46 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov



On 14.02.2023 17:12, Robert Marko wrote:
> SPI-NAND node name should be flash@1 and not nand@1 according to schema.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> index cd2a32d0d5548..bb0c888b048ec 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> @@ -186,7 +186,7 @@ partition@190000 {
>  		};
>  	};
>  
> -	nand@1 {
> +	flash@1 {
>  		compatible = "spi-nand";
>  		reg = <1>;
>  		spi-max-frequency = <40000000>;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4/4] ARM: dts: qcom: ipq4018-ap120c-ac: use NVMEM for ath10k caldata
  2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
  2023-02-14 16:12 ` [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema Robert Marko
  2023-02-14 16:12 ` [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND " Robert Marko
@ 2023-02-14 16:12 ` Robert Marko
  2023-02-16 10:45 ` [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Konrad Dybcio
  2023-03-15 23:35 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 9+ messages in thread
From: Robert Marko @ 2023-02-14 16:12 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov, Robert Marko

Since ath10k now supports loading the pre-cal via NVMEM instead of having
to use userspace scripts, lets use it.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
index bb0c888b048ec..d90b4f4c63afe 100644
--- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
@@ -170,6 +170,17 @@ partition@170000 {
 				label = "ART";
 				reg = <0x00170000 0x00010000>;
 				read-only;
+				compatible = "nvmem-cells";
+				#address-cells = <1>;
+				#size-cells = <1>;
+
+				precal_art_1000: precal@1000 {
+					reg = <0x1000 0x2f20>;
+				};
+
+				precal_art_5000: precal@5000 {
+					reg = <0x5000 0x2f20>;
+				};
 			};
 
 			partition@180000 {
@@ -233,10 +244,14 @@ &mdio {
 
 &wifi0 {
 	status = "okay";
+	nvmem-cell-names = "pre-calibration";
+	nvmem-cells = <&precal_art_1000>;
 };
 
 &wifi1 {
 	status = "okay";
+	nvmem-cell-names = "pre-calibration";
+	nvmem-cells = <&precal_art_5000>;
 	qcom,ath10k-calibration-variant = "ALFA-Network-AP120C-AC";
 };
 
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console
  2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
                   ` (2 preceding siblings ...)
  2023-02-14 16:12 ` [PATCH 4/4] ARM: dts: qcom: ipq4018-ap120c-ac: use NVMEM for ath10k caldata Robert Marko
@ 2023-02-16 10:45 ` Konrad Dybcio
  2023-03-15 23:35 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-02-16 10:45 UTC (permalink / raw)
  To: Robert Marko, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov



On 14.02.2023 17:12, Robert Marko wrote:
> Add the required alias and stdout property so that kernel can setup
> the console based off DTS and not have to set it in the cmdline.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> index a5a6f3ebb2749..38efd45433da5 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> @@ -8,6 +8,14 @@ / {
>  	model = "ALFA Network AP120C-AC";
>  	compatible = "alfa-network,ap120c-ac", "qcom,ipq4018";
>  
> +	aliases {
> +		serial0 = &blsp1_uart1;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
>  	keys {
>  		compatible = "gpio-keys";
>  

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: (subset) [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console
  2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
                   ` (3 preceding siblings ...)
  2023-02-16 10:45 ` [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Konrad Dybcio
@ 2023-03-15 23:35 ` Bjorn Andersson
  4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:35 UTC (permalink / raw)
  To: linux-arm-msm, konrad.dybcio, Robert Marko, robh+dt, agross,
	devicetree, krzysztof.kozlowski+dt, linux-kernel
  Cc: luka.perkov

On Tue, 14 Feb 2023 17:12:08 +0100, Robert Marko wrote:
> Add the required alias and stdout property so that kernel can setup
> the console based off DTS and not have to set it in the cmdline.
> 
> 

Applied, thanks!

[1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console
      commit: 131731c44f2cea44135e93bfb0a2920829910625
[2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema
      commit: a7d2715df2845560302aea9d9922b4bfdf4fe09a
[3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND with DT schema
      commit: fabc476a6cff40119365014e84aa2d2bbdf7756a
[4/4] ARM: dts: qcom: ipq4018-ap120c-ac: use NVMEM for ath10k caldata
      commit: d64f94249c689962b895aa650a30c29ac3b41cd3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-03-15 23:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-14 16:12 [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Robert Marko
2023-02-14 16:12 ` [PATCH 2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema Robert Marko
2023-02-16 10:48   ` Konrad Dybcio
2023-02-16 10:59     ` Robert Marko
2023-02-14 16:12 ` [PATCH 3/4] ARM: dts: qcom: ipq4018-ap120c-ac: align SPI-NAND " Robert Marko
2023-02-16 10:46   ` Konrad Dybcio
2023-02-14 16:12 ` [PATCH 4/4] ARM: dts: qcom: ipq4018-ap120c-ac: use NVMEM for ath10k caldata Robert Marko
2023-02-16 10:45 ` [PATCH 1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console Konrad Dybcio
2023-03-15 23:35 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).