From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F9CC4332F for ; Thu, 3 Nov 2022 12:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231631AbiKCMfP (ORCPT ); Thu, 3 Nov 2022 08:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231638AbiKCMfM (ORCPT ); Thu, 3 Nov 2022 08:35:12 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24261007F for ; Thu, 3 Nov 2022 05:35:09 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id a27so1060636qtw.10 for ; Thu, 03 Nov 2022 05:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AIhE5tTAyhN78d6a2N8YuzGDstI/Nrsk3pPBZ8RS5Yk=; b=YYxU3yG4i+301n1Yz40+nRHTTCJgk1T3Tym8Fiq6TDBNv+1KQ4YVl6p/PAtepKSRD/ AIuaoJN05BZEoSv/ZELW0H8b95Yj6W8Pfqke5EVawTofFSVabfowL6RiNCh8h0Mnfauw Jo6HIrq42XRW2eoecTxq7xKJl6vSQCEAsPKnJS35EL5OhpMOzofeqXHyv3m4EyVFWoSq yXqs1qabKHqDSDOGe1/5dZ0G3CLWkvLyJru+ZQPcJOwCJ4i+OpC2VQ7YtkI/+8j6qpr2 1MmZTTMG/XDpeZoV8ZpuELpevhdvTClO6G2jAgSPmKgf9BLX/7lXlAi01DBFSsUWkIxh NrWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AIhE5tTAyhN78d6a2N8YuzGDstI/Nrsk3pPBZ8RS5Yk=; b=bmfgNtv/sTxUbshNe8M1Nfv8RTRZQokWDPo5F2z3KobDOt6F3cv2uBg4LcpjAyke55 p9zOCVPdWZb988y6N2XU2kQXFB6VUzctxq3c3NhHoErLK7kZGLnjIdA26b0SteGmwr9Y 0s/VjRHHtKd63mydbS8HdBxXsNtkDF7grJgxdhsqEUdTR98ufm8asixj2pYQTakA2I6O OIYxDldbW/YgJyB767NcQaeJED8COnAtavgIfYqc1rJFPVRjjUdzlpxkHZ26JlTcCuZU ty5Yaa2sCluQZxSvFnr/RWthRI6+PSo592dMmwGJjNWRNOj2uPTamnfv54XJXgAqOtKl F7fA== X-Gm-Message-State: ACrzQf3XhP2LWTahFKBZAISjv839ynjSZtM94BlJ0XmwyfrjBWUkUzsi h+Q2mMJ+hYo6b8u2tKlGS2gOVg== X-Google-Smtp-Source: AMsMyM7xMUwtyr9tB3lj38zP1zS2TpQYq3vUnnA9LpvU4xyURUGwzF3DryKpyfcka2lcnVJDZ1anMg== X-Received: by 2002:a05:622a:5d1:b0:3a5:3818:a067 with SMTP id d17-20020a05622a05d100b003a53818a067mr12241551qtb.574.1667478908921; Thu, 03 Nov 2022 05:35:08 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id c11-20020ac8054b000000b003a527d29a41sm424304qth.75.2022.11.03.05.35.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:35:08 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:35:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221102130602.48969-1-aakarsh.jain@samsung.com> <20221102130602.48969-2-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221102130602.48969-2-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/11/2022 09:06, Aakarsh Jain wrote: > commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for Please run scripts/checkpatch.pl and fix reported warnings. > Exynos3250 and used the same compatible string as used by > Exynos5240 but both the IPs are a bit different in terms of > IP clock. > Lets add variant driver data based on the new compatible string > "samsung,exynos3250-mfc" for Exynos3250 SoC. Aren't you just missing the clock on Exynos3250? Best regards, Krzysztof