Re: [PATCH v2 2/7] arm64: dts: imx93-11x11-evk: added ele-mu

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 19/04/2023 19:55, Pankaj Gupta wrote:
> adde support for ele-mu for imx93-11x11-evk.

Typo, missing capital letter.

> 
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 41efd97dd6d6..ffb7cb8ed228 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>  /*
> - * Copyright 2022 NXP
> + * Copyright 2022-2022 NXP

?


>   */
>  
>  #include <dt-bindings/clock/imx93-clock.h>
> @@ -741,5 +741,14 @@ media_blk_ctrl: system-controller@4ac10000 {
>  			#power-domain-cells = <1>;
>  			status = "disabled";
>  		};

Missing blank line.

> +		ele_mu: ele-mu {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +			compatible = "fsl,imx93-ele";
> +			mboxes = <&s4muap 0 0 &s4muap 1 0>;

Two phandles, not one.

> +			mbox-names = "tx", "rx";
> +			fsl,ele_mu_did = <3>;
> +			fsl,ele_mu_id = <2>;
> +			fsl,ele_mu_max_users = <4>;
> +			status = "okay";

Why do you need it?

Run your patches through internal review to fix such obvious mistakes.
There is entire NXP to help you, instead of relying on us to fix trivial
code style.

> +		};
>  	};
>  };

Best regards,
Krzysztof