* [PATCH 2/2] arm64: dts: qcom: sa8775p: enable the inline crypto engine
2023-09-13 15:35 [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine Bartosz Golaszewski
@ 2023-09-13 15:35 ` Bartosz Golaszewski
2023-09-13 18:05 ` Konrad Dybcio
2023-09-13 15:55 ` [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-09-13 15:35 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S . Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Bartosz Golaszewski
Add an ICE node to sa8775p SoC description and enable it by adding a
phandle to the UFS node.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..b6a93b11cbbd 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -1525,6 +1525,7 @@ ufs_mem_hc: ufs@1d84000 {
<0 0>,
<0 0>,
<0 0>;
+ qcom,ice = <&ice>;
status = "disabled";
};
@@ -1546,6 +1547,13 @@ ufs_mem_phy: phy@1d87000 {
status = "disabled";
};
+ ice: crypto@1d88000 {
+ compatible = "qcom,sa8775p-inline-crypto-engine",
+ "qcom,inline-crypto-engine";
+ reg = <0x0 0x01d88000 0x0 0x8000>;
+ clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+ };
+
usb_0_hsphy: phy@88e4000 {
compatible = "qcom,sa8775p-usb-hs-phy",
"qcom,usb-snps-hs-5nm-phy";
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: enable the inline crypto engine
2023-09-13 15:35 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: enable the " Bartosz Golaszewski
@ 2023-09-13 18:05 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-09-13 18:05 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Herbert Xu,
David S . Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel
On 13.09.2023 17:35, Bartosz Golaszewski wrote:
> Add an ICE node to sa8775p SoC description and enable it by adding a
> phandle to the UFS node.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
I don't have any sources backing this up, but 8350 seems to
have the exact same register ranges for this block, so I'm
inclined to believe it's ok
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine
2023-09-13 15:35 [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine Bartosz Golaszewski
2023-09-13 15:35 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: enable the " Bartosz Golaszewski
@ 2023-09-13 15:55 ` Krzysztof Kozlowski
2023-09-25 6:59 ` Bartosz Golaszewski
2023-09-20 17:13 ` (subset) " Bjorn Andersson
2023-10-01 8:33 ` Herbert Xu
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-13 15:55 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Herbert Xu, David S . Miller, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel
On 13/09/2023 17:35, Bartosz Golaszewski wrote:
> Add the compatible string for QCom ICE on sa8775p SoCs.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine
2023-09-13 15:55 ` [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p " Krzysztof Kozlowski
@ 2023-09-25 6:59 ` Bartosz Golaszewski
0 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-09-25 6:59 UTC (permalink / raw)
To: Herbert Xu
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
David S . Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Krzysztof Kozlowski
On Wed, Sep 13, 2023 at 5:56 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/09/2023 17:35, Bartosz Golaszewski wrote:
> > Add the compatible string for QCom ICE on sa8775p SoCs.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Herbert,
Gentle ping for the binding as Bjorn already picked up the dts part.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine
2023-09-13 15:35 [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine Bartosz Golaszewski
2023-09-13 15:35 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: enable the " Bartosz Golaszewski
2023-09-13 15:55 ` [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p " Krzysztof Kozlowski
@ 2023-09-20 17:13 ` Bjorn Andersson
2023-10-01 8:33 ` Herbert Xu
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-09-20 17:13 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Herbert Xu, David S . Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bartosz Golaszewski
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel
On Wed, 13 Sep 2023 17:35:28 +0200, Bartosz Golaszewski wrote:
> Add the compatible string for QCom ICE on sa8775p SoCs.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: sa8775p: enable the inline crypto engine
commit: 96272ba7103d4518e2d0f17daf6fe0008fc6e12c
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine
2023-09-13 15:35 [PATCH 1/2] dt-bindings: crypto: ice: document the sa8775p inline crypto engine Bartosz Golaszewski
` (2 preceding siblings ...)
2023-09-20 17:13 ` (subset) " Bjorn Andersson
@ 2023-10-01 8:33 ` Herbert Xu
3 siblings, 0 replies; 7+ messages in thread
From: Herbert Xu @ 2023-10-01 8:33 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, David S . Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
linux-crypto, devicetree, linux-kernel
On Wed, Sep 13, 2023 at 05:35:28PM +0200, Bartosz Golaszewski wrote:
> Add the compatible string for QCom ICE on sa8775p SoCs.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 7+ messages in thread