From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03DAC6379F for ; Tue, 21 Feb 2023 11:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234149AbjBULh6 (ORCPT ); Tue, 21 Feb 2023 06:37:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234170AbjBULh4 (ORCPT ); Tue, 21 Feb 2023 06:37:56 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2125426869 for ; Tue, 21 Feb 2023 03:37:43 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id g1so15650275edz.7 for ; Tue, 21 Feb 2023 03:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b3giO+r2popIm1oll4LM9l15/2T1iWfGy9yTjFyqedM=; b=BJix9Ib3J8P8E2H6/ZcIc9et7JHruyqg71shp6ZsL+VbRXLIcOd6sQYDNfjkBtcjzG JZWVeNXhWq+sgCnGVXc5XvOqovQUcKXqsFbc/K9NX0sMcS+x3F89Ae8HPI459jgwjGHS MsJKEYTcsCuiDYUpWT+p0FBfXYv8LJSTSUDNDHTTP1lAIg00xkvRdPOxaWP9yx1cIa25 rSV/boSTwV+54FYyOLw+wvsbe0V08Dfjtin85npV/bh2JcE0f3fIQhvKyAHWuZUzTEbx BUBRMeXDWtXl9vcqvOH/ogcUyW5sBWt8sgWI9kwvrDlikfQNvS5Mv9l9ptvp3Vq+sk89 lOGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b3giO+r2popIm1oll4LM9l15/2T1iWfGy9yTjFyqedM=; b=LOA3Tj3eg3lb/oomKoRIUEmBB7+lyhuFTZ+9t1y+oH6rIyrxPCDChNKixa00bfiaoO hhrgLbYaosCr+3T/UTYtaw4k/ZvyXh4R+ICQDipxsayY81+Z7W08X26Yb7vOAhf1sALk XH6FecQc8dAQmjUMfET3tuTXnWrDJA+MYhmIev3DC94XF0pnpyWDD44gj2XGeXUyBUcD WCn4UbYJ2l1ILPhMsfY+UGDPMFF/mfSo95m+qFRhZCSYVSvMHRxrbuLABx0vOjAqsL58 vPV3yvyy+6mQ4z3/voSyHDW0c/H/eISfyy1k4xyD2HGS3K2rlk+0+N/8HJEJm18akPvi xMjA== X-Gm-Message-State: AO0yUKV4e5AJiUMTUtuq/CmudO3aJPcYadIrHtrAqZqrNh2v3IMt+jgX M9DSIcEuU/csxGHtUcMcbejC2Q== X-Google-Smtp-Source: AK7set84xkBelkMy79NBCa0so0dIuGCWkoKNyvcKs7Q69fGLNNK7SSXmGCK9KVAOjVH9tPTL4xKhJg== X-Received: by 2002:aa7:de98:0:b0:4ab:eac:30f2 with SMTP id j24-20020aa7de98000000b004ab0eac30f2mr3564835edv.18.1676979456078; Tue, 21 Feb 2023 03:37:36 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id u13-20020aa7d88d000000b004ab4c28a967sm1789572edq.44.2023.02.21.03.37.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 03:37:35 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 12:37:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/4] dt-bindings: soc: imx8mp-media-blk-ctrl: Add LDB into DT example Content-Language: en-US To: Marek Vasut , linux-arm-kernel@lists.infradead.org Cc: Liu Ying , Alexander Stein , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org References: <20230220035051.327847-1-marex@denx.de> <20230220035051.327847-2-marex@denx.de> From: Krzysztof Kozlowski In-Reply-To: <20230220035051.327847-2-marex@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/02/2023 04:50, Marek Vasut wrote: > Document the LDB bridge subnode and add the subnode into the example. > For the subnode to work, the block control must scan its subnodes and > bind drivers to them, do not misuse either simple-bus or simple-mfd > here . Drop space before full stop. Your subject is a bit imprecise. Main feature here is adding LDB child, not to the example but to the schema. > > Reviewed-by: Liu Ying > Signed-off-by: Marek Vasut > --- > Cc: Alexander Stein > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: NXP Linux Team > Cc: Paul Elder > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Richard Cochran > Cc: Richard Zhu > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > V2: Add RB from Liu > --- > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > index 71deebe902d52..61e6bc731bbb5 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > @@ -23,6 +23,12 @@ properties: > reg: > maxItems: 1 > > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > '#power-domain-cells': > const: 1 > > @@ -78,9 +84,16 @@ properties: > - const: isp1 > - const: dwe > > + bridge@5c: > + type: object > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > + unevaluatedProperties: false > + > required: > - compatible > - reg > + - '#address-cells' > + - '#size-cells' > - '#power-domain-cells' > - power-domains > - power-domain-names > @@ -114,5 +127,43 @@ examples: > clock-names = "apb", "axi", "cam1", "cam2", "disp1", "disp2", > "isp", "phy"; > #power-domain-cells = <1>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + bridge@5c { > + compatible = "fsl,imx8mp-ldb"; > + clocks = <&clk IMX8MP_CLK_MEDIA_LDB>; > + clock-names = "ldb"; > + reg = <0x5c 0x4>, <0x128 0x4>; > + reg-names = "ldb", "lvds"; Usually reg (and reg-names) is the second property, although depends on the soc subarch coding style. Anyway, with full-stop fix: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof