From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sergei Antonov" <saproj@gmail.com>, devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
"Jonas Jensen" <jonas.jensen@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: fix Moxa SDIO 'compatible', remove 'sdhci' misnomer
Date: Mon, 05 Sep 2022 15:06:04 +0200 [thread overview]
Message-ID: <c587279a-8444-4ffc-b30f-af17d92604d2@www.fastmail.com> (raw)
In-Reply-To: <20220905125343.2769117-1-saproj@gmail.com>
On Mon, Sep 5, 2022, at 2:53 PM, Sergei Antonov wrote:
> Driver moxart-mmc.c has .compatible = "moxa,moxart-mmc".
>
> But moxart .dts/.dtsi and the documentation file moxa,moxart-dma.txt
> contain compatible = "moxa,moxart-sdhci".
>
> Change moxart .dts/.dtsi files and moxa,moxart-dma.txt to match the driver.
>
> Replace 'sdhci' with 'mmc' in names too, since SDHCI is a different
> controller from FTSDC010.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Jonas Jensen <jonas.jensen@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> v1 -> v2:
> Per Arnd Bergmann's suggestion, replaced sdhci with mmc in names too.
Looks good to me now. Let's wait for more comments, or possibly
for Jonas to pick it up into his tree. If everyone is fine with this
version, can you send it to soc@kernel.org so I can pick it
up into the soc tree?
Arnd
next prev parent reply other threads:[~2022-09-05 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 12:53 [PATCH v2] ARM: dts: fix Moxa SDIO 'compatible', remove 'sdhci' misnomer Sergei Antonov
2022-09-05 13:06 ` Arnd Bergmann [this message]
2022-09-08 21:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c587279a-8444-4ffc-b30f-af17d92604d2@www.fastmail.com \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jonas.jensen@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=saproj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).