From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1020C25B4E for ; Sun, 22 Jan 2023 14:18:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbjAVOSB (ORCPT ); Sun, 22 Jan 2023 09:18:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbjAVOSA (ORCPT ); Sun, 22 Jan 2023 09:18:00 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E7F144B7 for ; Sun, 22 Jan 2023 06:17:58 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id m15so7223793wms.4 for ; Sun, 22 Jan 2023 06:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XjtzMpfc/L7l3fC8W1FOlPndT4/yZbcPMqMFz9cu9kY=; b=e8Ep5xa52Zw9S9fKBFg5pmufcH+1T5QSycoeAReB0gK3rpjZjv8UoeFu/crHjPM+NX rczOIH1HfixNQqjj0Sl948H9UymQ8xzxIZMIvUge/Y8JgqCEpLidz2IbY2MUDW/h4Gx9 JmGlsfvbEQn+v6UrghHuVeO7yo0RJGjdGEUzbkq3K9uP/kan0t3UHdz46WWUfe3xfy25 crTIo3/o/tnipKPc38h9b9A7gOfbjNOMr0RjFCan2OzwwmPlHiexqLOqdOV83yWxyfsz 4eQG2S4TFXtRfFUeiLtPFHQ0brDDcsTs/BPTKYQcT6E2qB2jqd/6iVpGkdiC4TZ/lHRD FdiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XjtzMpfc/L7l3fC8W1FOlPndT4/yZbcPMqMFz9cu9kY=; b=XZ3p6ivWMseeWiR4WXRQG0c/88PZiK/3M8WEDSy/10i7ZSoOxF6+wbbJFcRsEfBdHS /uHqkn38ylMvPF/pXliFgf9D24Nwmiy7j4De3TviPXi9ZeL/KHIgE0JKimnIv19dbXAJ yJKHEuDDZDsExyYH5sxk2645hGTUuzR+mJ2OJ8tdtcndZ2YqgvgVYSEOSPIoorIP+hKO pk8mPEHOlgwtf/WLzAnuY0MidVBgel1l1gtmU0Y5giJUeAO95cpJHdL22GsSAll8NqRQ 9qX0juCZOY+QlqgDbDl0y8pRO438vG764gAA12aNMFxPziI69bcT4gw0mmuFnbmglSnh GYoQ== X-Gm-Message-State: AFqh2krO5iD/ciRms5vXaUr5Jn6EaAkpuBcuvzh1mv6MbDCQxRTdNFYh 7PCREWL9QreuazTI/qHyLeh+Fw== X-Google-Smtp-Source: AMrXdXvqx3OuPPUrVEDE4FcnCybgJCBy6h2YA83AtFMcVZlG47Pyh9oMcY7c9dsmQc2Sv7qDPcQKzA== X-Received: by 2002:a05:600c:6001:b0:3da:f80a:5e85 with SMTP id az1-20020a05600c600100b003daf80a5e85mr20338672wmb.26.1674397077429; Sun, 22 Jan 2023 06:17:57 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d4-20020a05600c3ac400b003d9fa355387sm7825029wms.27.2023.01.22.06.17.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 06:17:57 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 15:17:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/3] dt-bindings: opp: opp-v2-kryo-cpu: add opp-microvolt nvmem based Content-Language: en-US To: Christian Marangi Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ilia Lin , "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Stephen Boyd , Yassine Oudjana , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230121000146.7809-1-ansuelsmth@gmail.com> <20230121000146.7809-2-ansuelsmth@gmail.com> <4b58dcf1-df8a-048f-ba6f-ea170479751b@linaro.org> <63cd44e6.050a0220.ed90.635a@mx.google.com> From: Krzysztof Kozlowski In-Reply-To: <63cd44e6.050a0220.ed90.635a@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/01/2023 15:15, Christian Marangi wrote: > On Sun, Jan 22, 2023 at 03:00:22PM +0100, Krzysztof Kozlowski wrote: >> On 21/01/2023 01:01, Christian Marangi wrote: >>> The operating-points-v2-kryo-cpu driver supports defining multiple >>> opp-microvolt based on the blown efuses in the soc. It consist of 3 >>> values that are parsed: speedbin, psv and version. They are all >>> appended to the opp-microvolt name and selected by the nvmem driver and >>> loaded dynamically at runtime. >>> >>> Example: >>> >>> opp-microvolt-speed0-pvs0-v0 = <1050000 997500 1102500>; >>> opp-microvolt-speed0-pvs1-v0 = <975000 926250 1023750>; >>> opp-microvolt-speed0-pvs2-v0 = <925000 878750 971250>; >>> opp-microvolt-speed0-pvs3-v0 = <850000 807500 892500>; >>> >>> Add support for this and reject these special binding if we don't have a >>> nvmem-cell to read data from. >>> >>> Signed-off-by: Christian Marangi >>> --- >>> .../devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >>> index b4947b326773..cea932339faf 100644 >>> --- a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >>> @@ -61,6 +61,17 @@ patternProperties: >>> >>> required-opps: true >>> >>> + patternProperties: >>> + '^opp-microvolt-speed[0-9]-pvs[0-9]-v[0-9]$': >> >> This does not end with correct unit suffix. Should be >> opp-speed-.....-microvolt >> > > I think I didn't understand this? > > From opp-v2-base and from what we are using downstream, the named > opp-micrvolt works correctly. > > (speed[0-9]-pvs[0-9]-v[0-9] is the entire name of the named > opp-microvolt- binding) > > This is the reference I always used for the pattern. [1] > Here the pattern used by the driver. [2] > > [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/opp/opp-v2-base.yaml#L209 > [2] https://elixir.bootlin.com/linux/latest/source/drivers/cpufreq/qcom-cpufreq-nvmem.c#L238 Are you documenting existing property or adding new? Commit msg suggests you add new property, so what do you reference here? How is it related? > >>> + description: | >>> + Assign a microvolt value to the opp hz based on the efuses value from >>> + speedbin, pvs and vers >> >> Where is the DTS change? > > You mean an additional example that use this additional binding? This > may be difficult to add since the current example in this schema is a > root one and I can't put multiple root example. No, I mean, you DTS using it. We do not want empty (unused) bindings... Best regards, Krzysztof