From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>, "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Liu Ying" <victor.liu@nxp.com>
Subject: Re: [PATCH 05/18] dt-bindings: mfd: adp5585: document adp5589 I/O expander
Date: Fri, 14 Mar 2025 09:38:32 +0000 [thread overview]
Message-ID: <c59477b2a94cbd10bc530809fbcdc0f2d1b79d07.camel@gmail.com> (raw)
In-Reply-To: <20250314-outstanding-futuristic-cat-5d8240@krzk-bin>
On Fri, 2025-03-14 at 09:49 +0100, Krzysztof Kozlowski wrote:
> On Thu, Mar 13, 2025 at 02:19:22PM +0000, Nuno Sá wrote:
> > reg:
> > maxItems: 1
> > @@ -63,13 +70,26 @@ allOf:
> > properties:
> > gpio-reserved-ranges: false
> > else:
> > - properties:
> > - gpio-reserved-ranges:
> > - maxItems: 1
> > - items:
> > + if:
>
> Do not nest if:then:else:if:then, it leads to code impossible to read.
> Just provide if-then cases for each of your variant.
>
Alright...
>
>
>
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - adi,adp5585-00
> > + - adi,adp5585-02
> > + - adi,adp5585-03
> > + - adi,adp5585-04
> > + then:
> > + properties:
> > + gpio-reserved-ranges:
> > + maxItems: 1
>
> one tem?
>
> > items:
> > - - const: 5
> > - - const: 1
>
> But here two...
>
> > + items:
> > + - const: 5
> > + - const: 1
>
> and this is confusing. I don't get what you want to express.
>
I just kept it as before (maybe I messed up in some other way but the 2 items:
were already in the binding):
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml#L70
If this is not needed I can simplifying during this patch. Is this sufficient?
...
gpio-reserved-ranges:
maxItems: 1
items:
- const: 5
- const: 1
Thx!
- Nuno Sá
next prev parent reply other threads:[~2025-03-14 9:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 14:19 [PATCH 00/18] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 01/18] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 02/18] mfd: adp5585: enable oscilator during probe Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 03/18] pwm: adp5585: don't control OSC_EN in the pwm driver Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 04/18] mfd: adp5585: make use of MFD_CELL_NAME() Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 05/18] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá via B4 Relay
2025-03-14 8:49 ` Krzysztof Kozlowski
2025-03-14 9:38 ` Nuno Sá [this message]
2025-03-17 7:41 ` Krzysztof Kozlowski
2025-03-17 9:30 ` Nuno Sá
2025-03-17 10:41 ` Krzysztof Kozlowski
2025-03-13 14:19 ` [PATCH 06/18] mfd: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-03-14 9:12 ` kernel test robot
2025-03-14 9:23 ` kernel test robot
2025-03-14 9:32 ` Nuno Sá
2025-03-13 14:19 ` [PATCH 07/18] gpio: adp5585: add support for the ad5589 expander Nuno Sá via B4 Relay
2025-03-14 10:53 ` Linus Walleij
2025-03-13 14:19 ` [PATCH 08/18] pwm: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 09/18] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá via B4 Relay
2025-03-17 15:53 ` Rob Herring
2025-03-17 16:08 ` Nuno Sá
2025-03-13 14:19 ` [PATCH 10/18] mfd: adp5585: add support for key events Nuno Sá via B4 Relay
2025-03-14 9:43 ` kernel test robot
2025-03-13 14:19 ` [PATCH 11/18] gpio: adp5585: support gpi events Nuno Sá via B4 Relay
2025-03-14 10:54 ` Linus Walleij
2025-03-13 14:19 ` [PATCH 12/18] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 13/18] Input: adp5589: remove the driver Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 14/18] mfd: adp5585: support getting vdd regulator Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 15/18] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá via B4 Relay
2025-03-14 8:52 ` Krzysztof Kozlowski
2025-03-13 14:19 ` [PATCH 16/18] mfd: adp5585: add support for a reset pin Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 17/18] pwm: adp5585: make sure to include mod_devicetable.h Nuno Sá via B4 Relay
2025-03-13 14:19 ` [PATCH 18/18] gpio: " Nuno Sá via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59477b2a94cbd10bc530809fbcdc0f2d1b79d07.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).