From: Krzysztof Kozlowski <krzk@kernel.org>
To: Siratul Islam <email@sirat.me>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Date: Fri, 20 Mar 2026 13:52:19 +0100 [thread overview]
Message-ID: <c59cfc77-b49a-48c4-b975-026ccd3be31a@kernel.org> (raw)
In-Reply-To: <20260319190738.151614-2-email@sirat.me>
On 19/03/2026 20:07, Siratul Islam wrote:
>
> properties:
> compatible:
> - const: st,vl53l0x
> + enum:
> + - st,vl53l0x
> + - st,vl53l1x
>
> reg:
> maxItems: 1
> @@ -21,12 +24,17 @@ properties:
>
> reset-gpios:
> maxItems: 1
> + description:
> + Phandle to the XSHUT GPIO. Used for hardware reset.
>
> - vdd-supply: true
> + vdd-supply:
> + description:
> + Phandle to the vdd input voltage. This is physically required for operation.
Drop the description. Schema tells that.
>
> required:
> - compatible
> - reg
> + - vdd-supply
That's an ABI break and nothing in commit msg explains why. You need
rationale for this, but most likely everything was working fine before,
so supply should not be required.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-20 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 19:07 [PATCH v6 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor Siratul Islam
2026-03-19 19:07 ` [PATCH v6 1/2] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-20 9:05 ` Krzysztof Kozlowski
2026-03-20 12:10 ` Sirat
2026-03-20 12:44 ` Krzysztof Kozlowski
2026-03-20 12:52 ` Krzysztof Kozlowski [this message]
2026-03-20 13:28 ` Sirat
2026-03-21 10:00 ` Krzysztof Kozlowski
2026-03-19 19:07 ` [PATCH v6 2/2] iio: proximity: add driver for " Siratul Islam
2026-03-20 8:38 ` Andy Shevchenko
2026-03-21 17:09 ` David Lechner
2026-03-21 22:39 ` Sirat
2026-03-22 0:37 ` David Lechner
2026-03-22 11:03 ` Jonathan Cameron
2026-03-22 13:52 ` Sirat
2026-03-24 15:17 ` Sirat
2026-03-24 17:29 ` David Lechner
2026-03-24 18:04 ` Sirat
2026-03-21 17:21 ` Jonathan Cameron
2026-03-21 23:40 ` Sirat
2026-03-22 0:39 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59cfc77-b49a-48c4-b975-026ccd3be31a@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox