Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	"biju.das.au" <biju.das.au@gmail.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"magnus.damm" <magnus.damm@gmail.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/2] dt-bindings: spi: renesas,rzv2h-rspi: Document RZ/G3L SoC
Date: Sun, 5 Apr 2026 10:58:04 +0200	[thread overview]
Message-ID: <c5a8ba40-1315-4654-b188-1c7a5f744d03@kernel.org> (raw)
In-Reply-To: <TY3PR01MB113461341DE0677746358F5BD8651A@TY3PR01MB11346.jpnprd01.prod.outlook.com>

On 02/04/2026 16:10, Biju Das wrote:
>>>>
>>>> So even after my objections here:
>>>> https://lore.kernel.org/all/9d08ddda-403e-458d-95e4-4e76915df85d@kern
>>>> el.org/
>>>>
>>>> this was not fixed and Renesas did not provide actual cross-patch review.
>>>
>>> That patch is not correct. See below.
>>>
>>>>
>>>> This is still probably wrong as pointed out by other patches by Renesas.
>>>> Also, you cannot have flexible names.
>>>
>>> You can have "rx", "tx" in any order and {rx, tx} should be unique dma
>>> specifier
>>
>> No. You cannot. I just told you so. Please read writing-bindings for arguments.
> 
> <snippet from writing-bindings >
> - DO define properties in terms of constraints. How many entries? What are
>   possible values? What is the order? All these constraints represent the ABI
>   as well.
> </snippet>
> 
> Is that the reason you're saying we cannot have flexible names for DMAs?

Yes

> 
> Are you expecting the RZ/G3L DMA entries to be like below? Please let me know.
> 
> This is not flexible — the user always needs to specify RX first, followed by TX.
> 
> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: rx
> +      - const: tx


Yes

> 
> 


Best regards,
Krzysztof

  reply	other threads:[~2026-04-05  8:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:49 [PATCH 0/2] Add Renesas RZ/G3L RSPI support Biju
2026-03-04  7:49 ` [PATCH 1/2] dt-bindings: spi: renesas,rzv2h-rspi: Document RZ/G3L SoC Biju
2026-03-04 15:03   ` Krzysztof Kozlowski
2026-03-04 15:18     ` Biju Das
2026-03-04 15:43       ` Krzysztof Kozlowski
2026-04-02 14:10         ` Biju Das
2026-04-05  8:58           ` Krzysztof Kozlowski [this message]
2026-04-07 13:51             ` Biju Das
2026-03-26 14:28   ` Geert Uytterhoeven
2026-04-02 13:00 ` [PATCH 0/2] Add Renesas RZ/G3L RSPI support Biju Das
2026-04-02 13:09   ` Biju Das
2026-04-02 13:20   ` Mark Brown
2026-04-02 13:32     ` Biju Das
2026-04-02 14:51       ` Mark Brown
2026-04-02 15:17         ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5a8ba40-1315-4654-b188-1c7a5f744d03@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox