From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B09AC4167B for ; Wed, 28 Dec 2022 15:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233612AbiL1PJF (ORCPT ); Wed, 28 Dec 2022 10:09:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233630AbiL1PJD (ORCPT ); Wed, 28 Dec 2022 10:09:03 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 323C313D74 for ; Wed, 28 Dec 2022 07:09:02 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id bt23so7327577lfb.5 for ; Wed, 28 Dec 2022 07:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gmtzdmo2KThie2rygVM6gP58Xp8wt3BXaHi7Yl4AiAo=; b=aIEQthuYYFP2u5JfqSwCIwrX6pmtwHj4uKu/TPmyjwKjHetmAFuw1XODvI1ksigK6G lz4x4V1+LYWrS69Y7O4l7UAptRwq8w54nAbS3h4FHQU60AdvnHf5zIHeMwDi2Hl8tzIY 8BD6fwiT1k3PCDLPgDc0TTRJsFUy9jE9qZ3KsBOaY0BuqnIvtYZar456VJkxwhR14T9C r+QfzJY/nYQ1YPRC/chI+6lsVhqlvOY+unQY3iiY/CDbz/PJ32LxMjdPrpKdpcpcqeEJ /gVcMA3swWTHHi8wD7MCjpw2nnZVBNrwNGQkM3unZSatZm2JCRD6kGqJVggh70z6FKUC mqKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gmtzdmo2KThie2rygVM6gP58Xp8wt3BXaHi7Yl4AiAo=; b=1Kjn/3UNpU25proZZlZ9/WVtNg1cN2i0ZJMGKNDAv8ZpkSXHeD572/L96ZFVjFhVGT nA5+Y2ncROyxsSJa3pn3/hs/k2OvrTUgUdj+xyCkCLSVnnccCxI0QWvCViGvhaTtrGxn C0CfJfkhZMs27VNt4nRGG9624X2qhoppEl0l4iBJhZVfVM/oyT4cWYA9fcs+xUL3j0IQ xhWV7Pj+MeArGUaew9+oBIdqET2e9NetNKf4Bzt4R3OyRBt40+8oSFYh4UWx3iOyTAnK VH+7cpIb8PbQsqwuKOmwOvW+2WxIsCzT0Cc7PimKv7DKTuooDiM7bJpy4lxYs84KZ1mr KiXQ== X-Gm-Message-State: AFqh2kroOxl1B1qx0YPKhhgGwRR/8tBObi+BtLYmEAMeBPaV0/+ap3LY 7hOmd5gNeEy+hTsLOYfVcOqBOQ== X-Google-Smtp-Source: AMrXdXtpRI5PKCqyRot0pgpuz1wAaTYR67+7gZgy3rUY+4sjGmfy+SH5CBZzaltjcR2FFjL39uNMfw== X-Received: by 2002:a05:6512:2008:b0:4b6:ed8b:4f17 with SMTP id a8-20020a056512200800b004b6ed8b4f17mr6598667lfb.51.1672240140575; Wed, 28 Dec 2022 07:09:00 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id p9-20020ac24ec9000000b004caffc90c29sm232333lfr.55.2022.12.28.07.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Dec 2022 07:09:00 -0800 (PST) Message-ID: Date: Wed, 28 Dec 2022 16:08:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Content-Language: en-US To: Anand Moon , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221228100321.15949-1-linux.amoon@gmail.com> <20221228100321.15949-3-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221228100321.15949-3-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/12/2022 11:03, Anand Moon wrote: > On Odroid c1 previously use gpio-hog to reset the usb hub, > switch to used on board usb hub reset to enable the usb hub > and enable power to usb hub. > > Add usb hub regulator as per the schematic. > > Signed-off-by: Anand Moon > --- > arch/arm/boot/dts/meson8b-odroidc1.dts | 40 +++++++++++++++++--------- > 1 file changed, 27 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts > index 04356bc639fa..3b29169aac43 100644 > --- a/arch/arm/boot/dts/meson8b-odroidc1.dts > +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts > @@ -185,6 +185,33 @@ vdd_rtc: regulator-vdd-rtc { > > vin-supply = <&vcc_3v3>; > }; > + > + usb_otg_pwr: regulator-usb-pwrs { > + compatible = "regulator-fixed"; > + regulator-name = "USB_OTG_PWR"; > + > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + /* signal name from schematics: PWREN */ > + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <&p5v0>; > + }; > + > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub@1 { > + /* Genesys Logic GL852G-OHG usb hub */ > + compatible = "genesys,usb5e3,610"; Wrong compatible. Does not match pattern in usb-device.yaml. Best regards, Krzysztof