From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40F7C43334 for ; Thu, 21 Jul 2022 07:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231735AbiGUHhB (ORCPT ); Thu, 21 Jul 2022 03:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbiGUHg6 (ORCPT ); Thu, 21 Jul 2022 03:36:58 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F1D7C1AD for ; Thu, 21 Jul 2022 00:36:56 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id u14so862152lju.0 for ; Thu, 21 Jul 2022 00:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=INIrz+WDj0ZvQHcz9TnBkLHSMLRDg1voDl7d6lVEzy4=; b=XuwHynZZccr+ihJjF+6M8WbwngkPw/sUIZTTN6Y/xf8Jz9I6G7qe61XakhiWCodkXB WMHqiTeIL0IbF+IGWXlCRF7qTO9W1RwL61FPdVJ9bNGGNvXw4NkF9YhaF9+DWDNxugIU fyKK0Ws8XA0eHWHZmJnOdipZfy7kWJJ2bdl/bkC+Y+95HpNAgyGfEQXwzCjLHGtDr2Lg rFGPG9gC8+BumsYcKTToqT8sEP+hF08WY3amq2X8lnII5RcT2T7wsOtfWRoQI2aKvSl+ +Gw0i9xZbHhNrCl/NfvaZ15vGJmPTzzMlHJ4VqATS9GJ1cMd8VED74Ly9i4zIPFZQwI/ P4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=INIrz+WDj0ZvQHcz9TnBkLHSMLRDg1voDl7d6lVEzy4=; b=Wye+OnZwRiUYUqRYA/On/C6dAGKt7aWvsxSiatPZhJu5QGiafaEGI+g299BwLy+eDq Jr/cx2Ux1WTuP6G2bZIkz7PwDvSYFQTqAaAjARpbmpNdF/Gc2iUl8G3uK4wdo0/85TOw EhSAoHWjCZbczkXZWt/OF7kM57oYLD9iPzav0IL0eG2/398sk4j1sN7g7yg4NLo0qDC8 h9Jkl9FdXEpq49xJTyeE4likGorW5KdqEEaKPuR7GvGyyNeb5isWDrjulEm0vbmc8lIP YxoMVeJN0gT/db7aMesnTgyvjP/8rfhU4DtE5QH/7SgVYX8yReEvNZp3flJcCOjE72DN 75pQ== X-Gm-Message-State: AJIora9Y5hVFI7obA5W96afc5fAkPUUuGeK3MzGcDzb45aDXxX/BhJqK +MbkBg2LrcmzSwnsJdXiAacd8A== X-Google-Smtp-Source: AGRyM1vmHIZvYb5hQiGX+8TA1O0aR9NSdv6+VJidFvgFxA/LZZxBMKynm3UyxFXXWa1or5c1+APrtg== X-Received: by 2002:a2e:a990:0:b0:25d:5e37:1746 with SMTP id x16-20020a2ea990000000b0025d5e371746mr18898124ljq.34.1658389015350; Thu, 21 Jul 2022 00:36:55 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id cf3-20020a056512280300b0048a71ff9c04sm115644lfb.254.2022.07.21.00.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 00:36:54 -0700 (PDT) Message-ID: Date: Thu, 21 Jul 2022 09:36:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description Content-Language: en-US To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: William Zhang , Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20220721000658.29537-1-william.zhang@broadcom.com> <883c2ad4c36220b488519a8902ad72bc@milecki.pl> <193845cb-6149-1ae6-5eb6-6b01ffcf763b@linaro.org> <4b5100e4a6e9e581f4b8ab58e5ca4927@milecki.pl> From: Krzysztof Kozlowski In-Reply-To: <4b5100e4a6e9e581f4b8ab58e5ca4927@milecki.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/07/2022 09:13, Rafał Miłecki wrote: >> That's better argument. But what's the benefit of adding generic >> compatible? Devices cannot bind to it (it is too generic). Does it >> describe the device anyhow? Imagine someone adding compatible >> "brcm,all-soc-of-broadcom" - does it make any sense? > > OK, I see it now. I can't think of any case of handling all devices > covered with suc a wide brcm,bcmbca binding. Maybe there is some common part of a SoC which that generic compatible would express? Most archs don't use soc-wide generic compatible, because of reasons I mentioned - no actual benefits for anyone from such compatible. But there are exceptions. I fouun socfpga and apple. The apple sounds as mistake to me, because the generic "apple,arm-platform" compatible looks like covering all possible Apple ARM platforms. I think Apple ARM designs in 20 years will not be compatible at all with current design, so such broad compatible is not useful... but that's only my opinion. > > This leads me to another question if we should actually totally drop > brcm,bcmbca from other SoCs bindings, see linux-next's > Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml This would be tricky as it was already accepted, unless all sit in linux-next and did not make to v5.19-rc1. Best regards, Krzysztof