From: Mark Brown <broonie@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, johan+linaro@kernel.org,
perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT
Date: Wed, 28 Jun 2023 20:40:12 +0100 [thread overview]
Message-ID: <c5bbdaa9-43fb-4ec3-af7d-b1629d2d88f7@sirena.org.uk> (raw)
In-Reply-To: <fabef33c-a8c7-af61-80b4-91e55081c977@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Wed, Jun 28, 2023 at 10:33:16PM +0300, Dmitry Baryshkov wrote:
> On 28/06/2023 21:10, Mark Brown wrote:
> > If the goal here is to put all the firmwares for a given board in a
> > single place surely it would be better to factor this all out of the
> > individual drivers so that they ask some helper for a directory to use
> > for firmware? Adding these device specific firmware node properties
> > doesn't seem to follow.
> This quickly becomes overcomplicated. Some platforms use different firmware
> naming structure. Some firmware goes into a generic location and other files
> go into device-specific location. So having a generic helper doesn't really
> help.
That sounds like a job for symlinks surely?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-28 19:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 10:26 [PATCH 0/3] ASoC: qcom: get tplg firmware-name from device tree Srinivas Kandagatla
2023-06-28 10:26 ` [PATCH 1/3] ASoC: dt-bindings: q6apm: add firmware-name bindings Srinivas Kandagatla
2023-06-28 11:18 ` Rob Herring
2023-06-28 15:54 ` Rob Herring
2023-06-28 16:43 ` Srinivas Kandagatla
2023-06-28 10:26 ` [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT Srinivas Kandagatla
2023-06-28 11:53 ` Mark Brown
2023-06-28 16:30 ` Srinivas Kandagatla
2023-06-28 17:42 ` Mark Brown
2023-06-28 16:57 ` Dmitry Baryshkov
2023-06-28 18:10 ` Mark Brown
2023-06-28 19:33 ` Dmitry Baryshkov
2023-06-28 19:40 ` Mark Brown [this message]
2023-06-28 20:00 ` Dmitry Baryshkov
2023-06-28 20:11 ` Mark Brown
2023-06-28 10:26 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-x13s: Add audio topology firmware path Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5bbdaa9-43fb-4ec3-af7d-b1629d2d88f7@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).