From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Date: Wed, 27 Mar 2019 12:26:49 +0000 Message-ID: References: <1553613207-3988-1-git-send-email-vidyas@nvidia.com> <1553613207-3988-11-git-send-email-vidyas@nvidia.com> <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Vidya Sagar , bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, thierry.reding@gmail.com, kishon@ti.com, catalin.marinas@arm.com, will.deacon@arm.com, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, mperttunen@nvidia.com, tiwai@suse.de, spujar@nvidia.com, skomatineni@nvidia.com, liviu.dudau@arm.com, krzk@kernel.org, heiko@sntech.de, horms+renesas@verge.net.au, olof@lixom.net, maxime.ripard@bootlin.com, andy.gross@linaro.org, bjorn.andersson@linaro.org, jagan@amarulasolutions.com, enric.balletbo@collabora.com, ezequiel@collabora.com, stefan.wahren@i2se.com, marc.w.gonzalez@free.fr, l.stach@pengutronix.de, tpiepho@impinj.com, hayashi.kunihiko@socionext.co Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kthota@nvidia.com, mmaddireddy@nvidia.com List-Id: devicetree@vger.kernel.org On 27/03/2019 10:12, Vidya Sagar wrote: > On 3/27/2019 3:38 PM, Jon Hunter wrote: >> >> On 26/03/2019 15:13, Vidya Sagar wrote: >>> Add PCIe host controller driver for DesignWare core based >>> PCIe controller IP present in Tegra194. >>> >>> Signed-off-by: Vidya Sagar >>> --- >>> =C2=A0 arch/arm64/configs/defconfig | 1 + >>> =C2=A0 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfi= g >>> index 2d9c39033c1a..2ddea5c4e87d 100644 >>> --- a/arch/arm64/configs/defconfig >>> +++ b/arch/arm64/configs/defconfig >>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=3Dy >>> =C2=A0 CONFIG_PCIE_ARMADA_8K=3Dy >>> =C2=A0 CONFIG_PCIE_KIRIN=3Dy >>> =C2=A0 CONFIG_PCIE_HISI_STB=3Dy >>> +CONFIG_PCIE_TEGRA194=3Dy >>> =C2=A0 CONFIG_ARM64_VA_BITS_48=3Dy >>> =C2=A0 CONFIG_SCHED_MC=3Dy >>> =C2=A0 CONFIG_NUMA=3Dy >> >> Maybe building as a module is more appropriate here as I am not sure >> that anyone else will want this built-in and it is not critical to >> booting AFAIK. > Since the DesignWare core framework doesn't yet have support for making > this > as a module, I added it as a built-in driver. I'll switch it to a module > once support is available. Ah I see. We often get reports/patches if a driver has a removal function but is defined in the Kconfig to only support being built-in. Does the designware core just need to export some symbols to support it being a module? If so it maybe worth adding these as part of the series to see if it is acceptable, otherwise it might not get done and there is no point us supporting it as a module. Cheers Jon --=20 nvpublic