From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41070C35DE6 for ; Mon, 24 Feb 2020 23:40:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 117E021556 for ; Mon, 24 Feb 2020 23:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="vYiAcpOR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RPEZ+3F5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbgBXXkM (ORCPT ); Mon, 24 Feb 2020 18:40:12 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:53167 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727976AbgBXXkM (ORCPT ); Mon, 24 Feb 2020 18:40:12 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DFE366C6; Mon, 24 Feb 2020 18:40:10 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Mon, 24 Feb 2020 18:40:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=3+7oIYy75eyNJFA+Gxl240s+7FvhCpt LmGW8I9hc6zc=; b=vYiAcpOR0t7KGVWY7hgh9uKy/VGeza1MpdZ2dKeiJpfgOdq Sala8CAoleHamfa4bqeWxEHIMixNWXwUiTy5/sFfbGdDmNfUoX+1sciR3devM0wD olVPelGp8f+n6AIFaPe8c0cq3mGEocaAwm/EoEKHs4tSEefXOsW8G9T0zf+JCPj7 GuVN/p7be69hH3IcHwkTvmmSbB1siDfYUkr4cSpgu7jUMrwXKpqy1L6+Ke2KI3db t4XuVH8MwO8m1PFMxADOQ0xo1l3qzpK5KgVRESBNrihvrV9z2JjAHi9o1XdAtIS+ 0mnwQqa6htnzxWK/eeiRau9cQ8lJa31OrWpizDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3+7oIY y75eyNJFA+Gxl240s+7FvhCptLmGW8I9hc6zc=; b=RPEZ+3F5AfM8pcpim0OtAW 0j+AlR+6UkaJRCS4Lnq27od9CbsUK6/1/WYwHVT36OBEG9PQIXENYJ6xxCYzEBtR nzEZVw03UPzy8JlfKHpxcthF5TC84vnSKRsAhhYAL7vYW9et4Ohg0HMB4sDSgMR4 6Dphk/Tsr0DHXZQ/nuUj1Ez3xoqq/3dRXEyKfGVcsf9JJxL8HqCD8hpnd3EjT24A nEyRm4NapwJSpQAWOhQzDDsqBEbV+o0J7qda+Dk2pf51dGcbYJ/OFF1ZLCBnD6a4 D/+cCDlTd6KeemJJG4oRX+3NCGAHXKyKjzmGwaWZEj7EgGDEmRUApCsY/iPcT8mw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledugdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghj rdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1A1F4E00A6; Mon, 24 Feb 2020 18:40:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-947-gbed3ff6-fmstable-20200220v2 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20200202163939.13326-1-linux@roeck-us.net> Date: Tue, 25 Feb 2020 10:10:06 +1030 From: "Andrew Jeffery" To: "Joel Stanley" , "Guenter Roeck" Cc: devicetree , "Linux ARM" , linux-aspeed , "Linux Kernel Mailing List" Subject: Re: [PATCH] ARM: dts: aspeed: tacoma: Enable eMMC controller Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 4 Feb 2020, at 16:24, Joel Stanley wrote: > On Sun, 2 Feb 2020 at 16:39, Guenter Roeck wrote: > > > > Enabling emmc without enabling its controller doesn't do any good. > > Enable its controller as well to make it work. > > > > Cc: Andrew Jeffery > > Cc: Joel Stanley > > Signed-off-by: Guenter Roeck > > Thanks Guenter. The description in aspeed-g6.dtsi changed at some > point and Tacoma was not updated. > > > --- > > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > > index ff49ec76fa7c..47293a5e0c59 100644 > > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > > @@ -132,6 +132,10 @@ > > use-ncsi; > > }; > > > > +&emmc_controller { > > + status = "okay"; > > +}; > > + > > &emmc { > > status = "okay"; > > }; > > This node is redundant, as it is not disabled in the dtsi. > > Andrew, should we add disabled to the emmc node? Probably. Also the nodes are badly named, partly because of the structure of the IP block. 'emmc' in this instance isn't the actual card, it's the SDHCI, and emmc_controller is a 'parent' that contains some global state which applies to one or more SDHCIs inside the IP block. We should probably cook up better names. > > Or remove the label completely, and just have emmc_controller? Maybe this is a better approach? The eMMC IP block only has one associated SDHCI, so that would make sense. Andrew