From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Subject: Re: [PATCH v5 02/22] fixup! v4l2-ctrls: add v4l2_ctrl_request_hdl_find/put/ctrl_find functions Date: Tue, 10 Jul 2018 10:21:09 +0200 Message-ID: References: <20180710080114.31469-1-paul.kocialkowski@bootlin.com> <20180710080114.31469-3-paul.kocialkowski@bootlin.com> <5adf8a6aa70fd6f7f4326ccb068b66d6221d8d8b.camel@bootlin.com> Reply-To: paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-tr9K18b3srFCX1uet9wE" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans Verkuil , Geert Uytterhoeven Cc: Linux Media Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , marco.franchi-3arQi8VN3Tc@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org, keiichiw-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Jonathan Corbet , smitha.t-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, tom.saeger-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, Andrzej Hajda , "David S. Miller" , Greg KH , Andrew Morton , Randy Dunlap , Arnd Bergmann , Laurent Pinchart , jaco List-Id: devicetree@vger.kernel.org --=-tr9K18b3srFCX1uet9wE Content-Type: text/plain; charset="UTF-8" Hi, On Tue, 2018-07-10 at 10:17 +0200, Hans Verkuil wrote: > On 10/07/18 10:13, Paul Kocialkowski wrote: > > Hi, > > > > On Tue, 2018-07-10 at 10:07 +0200, Geert Uytterhoeven wrote: > > > On Tue, Jul 10, 2018 at 10:02 AM Paul Kocialkowski > > > wrote: > > > > [PATCH v5 02/22] fixup! v4l2-ctrls: add v4l2_ctrl_request_hdl_find/put/ctrl_find functions > > > > > > git rebase -i ;-) > > > > Although I should have mentionned it (and did not), this is totally > > intentional! The first patch (from Hans Verkuil) requires said fixup to > > work properly. I didn't want to squash that change into the commit to > > make the diff obvious. > > Just squash the two for the next version you post. That works for me! I must admit I was rather unsure this was a sensible way to do things. > > Ultimately, this framework patch is not really part of the series but is > > one of its underlying requirements, that should be merged separately (as > > part of the requests API series). > > There is a good chance that this patch will go in via your series anyway > since it is not needed by vivid or vim2m. Alright, I will keep it around then. Cheers, Paul > Regards, > > Hans > > > > > I hope this clears up some of the confusion about this patch :) > > > > Cheers! > > > > > Gr{oetje,eeting}s, > > > > > > Geert > > > > > -- Paul Kocialkowski, Bootlin (formerly Free Electrons) Embedded Linux and kernel engineering https://bootlin.com --=-tr9K18b3srFCX1uet9wE--