Re: [PATCH v4 8/8] arm64: dts: qcom: x1e80100-crd: Add charge limit nvmem

Konrad Dybcio
2025-09-16T10:29:40Z

On 9/15/25 12:20 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 15, 2025 at 04:50:00PM +0800, Fenglin Wu via B4 Relay wrote:
>> From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>>
>> Add nvmem cells for getting charge control thresholds if they have
>> been set previously.
>>
>> Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on Thinkpad T14S OLED
>> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 3 +++
>> arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 20 ++++++++++++++++++++
>> 2 files changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> index c9f0d505267081af66b0973fe6c1e33832a2c86b..fee65391653ae9c2ee23f9f3954d9ed018c9aecd 100644
>> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
>> @@ -82,6 +82,9 @@ pmic-glink {
>> <&tlmm 123 GPIO_ACTIVE_HIGH>,
>> <&tlmm 125 GPIO_ACTIVE_HIGH>;
>>
>> + nvmem-cells = <&charge_limit_en>, <&charge_limit_end>, <&charge_limit_delta>;
>
> One item per line, please.
>
>> + nvmem-cell-names = "charge_limit_en", "charge_limit_end", "charge_limit_delta";
>
> And here too.

With that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad