From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1087418A5D for ; Thu, 24 Sep 2026 18:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275022; cv=none; b=uxRfrU9ouOIkXZ8Muq07FXpSqUELrkQHAvDT159/09OZnU1ovURpdcwCjjqmPovpxw3d0swGEGjVwzpRSywiUPN2wnnMj1zrwOYRakWhkPnb8tUnpbTk721RflpLTd82Nw7CG0kHlklX4/WEfg82FS62VY4aZYNxh76Qbwlr9kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275022; c=relaxed/simple; bh=Zm5ldxmbcNQhcHRY+0U+0ysqbQPxSjq+VFK68TfEGF0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H2dqgP+pDEDgE/2D9kPYvT1S/tMiQIhrL+/QMP/AQBaAZzNZlcPjpZUG9DCWHxvSbj67SlwefgiomDyqClfxm6H2sxSP5HNIuTUHwpfY76AwDwnl8GcHPOFPaDWIq0XAEE3wf3+vHTEeCWhRJRm33u2OBnUwyTxj/viRlc++T8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d/SnV1iu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PP0BP5aa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d/SnV1iu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PP0BP5aa" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68OFeVHm3064815 for ; Thu, 24 Sep 2026 18:36:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 41LukkMXTeVAHv1EIq6Q6zMQywct8NJOviLbwN/UtRg=; b=d/SnV1iuTx+hgTty eAP4qOmbq3d4b0L0y60wdiGxF00t4kjPES5bO5MiikdGvmjUG9NIqjZ0+PYiBA89 fa8IgVNZaSJN2EPTwMRslEte3J/HUVfMvXrehg01FSHqGy8RV9UPIF9b8zGy6Ams KIMXPuexfnkc/erkcQPouA79+sm9X5vy00OJh1Vti+5JtdCCfagxKrb1Z4I3Qrqu Gd/Co3mbSsVobRhNolbE+VmacIRQUKV0Lz8SSBW9O1FcUAA0vEKWqEoH7/EtG6iX FEquWtM5AZZXr3APziGivXU2m7fpCufG/W4tqK0FLuKZiYJEXIS8YEci+LVAeDw6 ItnVkQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gw1tjj661-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 18:36:59 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-33baaba6371so169027eec.1 for ; Thu, 24 Sep 2026 11:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790275018; x=1790879818; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=41LukkMXTeVAHv1EIq6Q6zMQywct8NJOviLbwN/UtRg=; b=PP0BP5aapjA/OFtkgA4qeiBtEPEOx6tlSgtDXKe6QCVfRH+CiQtf7FWgfWrPIe8gXU xGreYRt0E05KMZXX60gcLZDt1MrUBbO3JM/hEBrHS7rl2ZsxGS4AtvfQvAjZI8rINEzz f0XR4K8WIuwursiM5fy323zv9KUa6qxyWfhUlAhiG8ZD6HiAx51WFnP5XgTcnFBVoFrN d/MVWqfdhhdGgI/YcC7UzNIFi5VWdYy3vVn3MglEp78uS/zQXN46V3CP7Tkc1Ha1xVQO X/YtDV9zo+Mpa14j1rY5CLv7xEALcn/lDrSjt+acfoVG2HfCIEqhVq50lX6BYcJwSfmJ e7EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790275018; x=1790879818; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=41LukkMXTeVAHv1EIq6Q6zMQywct8NJOviLbwN/UtRg=; b=hPF6PfjO7mhlCZ2i9U7fEVSJlXR4SrPzXwr1a2y1d/s58Y/grPbyAiMjey6dM2l455 XlXZzKFHtzLrsuvLm/GrV79o0SzCab0LDXJm8hqgOOeSzMvERwjHKpW3kY9l7XZdh8p+ ZjSNjrgAX9+Njofb5PcYKXR4sXhCwfHIX894TQxf0NzSEmJihGBfSynBvuFNHPYQekmI d/Qj5h/AkPfzpXhGYWqenDJzkRyhohWnpolz57Xde8jnZaaNCUebCi3EMVqTNwQSIIEV vn9BFU4u2mrkYfkEpvqV7uhWR4NvaoZpXmT0m1CQZ+B8sJyRtZ5BGB1OR3jdhyd4x5vO ZNlw== X-Forwarded-Encrypted: i=1; AKwUvBwt8xpx7Vg2ncH2PtrN3CjoHeg7w3xXGGjYECTpwErPmZtBlP6DoTEk1RQL6AW5lbe0xWUiWC2ETadl@vger.kernel.org X-Gm-Message-State: AFuF++lrOJ8rHsVOYg8guME/NLrkJ2RIGyIMWmriZj25vNb5dcTrCAf4 da9v6aTuUWPnEpyUAMP2KWPvGWi3YwE+2wuGuf33hv18j9eBreBUSBm/X+t7CFIlYIdZQ/4IQxJ JH+l9oyYwpI0wOWX5UhL0w5O86ZW3zrqFP8xtlspzSMU10i8o4JkSH0WUKKD2dvaF X-Gm-Gg: AYBFou3ZvV6txXG2yDBRD6XghnbaBWfzFwBRQijhnI9y82yWJESZ8qYU+pbV3+1nlkm Fvv46SXgmdwY/oyp9sLega9PTKEyhpCADd33by4BtcjSdFZTFLS1Pix5aGoJRk1L8fNJvMVLwuR ChQM8qsbbDEA2mBWV20uapP0IbRRxdNknEk/s9wFk8OVCbk2Fwq7THy9EsLyXGANzmAIi68PkMw iBCPuOa/Y03Ff+zTyoEYyoERRXNliBOAqIMh1H6ynvLBdDo/JYduHcwtXjdTCSenCercX+VA89X 86HSrQkJE8fPrnPWLUJ6NJtvHrwoGuBog/3WuII+Zij5Cxosa4Hx1fKsSJzWvEzncY8QGnrp4Qn Cjwfyii3DRFcUbzDR39nFSigPfZ2eRg== X-Received: by 2002:a05:7301:438d:b0:33d:29c6:3445 with SMTP id 5a478bee46e88-340035bcf1dmr2498230eec.31.1790275017967; Thu, 24 Sep 2026 11:36:57 -0700 (PDT) X-Received: by 2002:a05:7301:438d:b0:33d:29c6:3445 with SMTP id 5a478bee46e88-340035bcf1dmr2498170eec.31.1790275016317; Thu, 24 Sep 2026 11:36:56 -0700 (PDT) Received: from [192.168.1.12] ([122.177.242.157]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-34144757747sm432684eec.13.2026.09.24.11.36.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2026 11:36:55 -0700 (PDT) Message-ID: Date: Fri, 25 Sep 2026 00:06:48 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel To: Dmitry Baryshkov Cc: Nabige Aala , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260916-shikra-dt-changes-v4-0-d5d5c3ffe070@oss.qualcomm.com> <20260916-shikra-dt-changes-v4-3-d5d5c3ffe070@oss.qualcomm.com> <5som4lcux7m6fyawwhjyrdxxiys6dh5ix33mtkxsseuv6uyxez@jb4m62r7x7i2> <7ef413c5-a9fd-4e75-bb02-b3d7f74c67ab@oss.qualcomm.com> Content-Language: en-US From: Arpit Saini In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: BnEBlmnBSrO8dqFPI0MC9en_KJCmBLt1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDA3NiBTYWx0ZWRfX5whEnuAu+TrX ITacn49fHeXaMa94ykFVgiRsKY6jWoBf4WDsjL6YhqhKHRLxsTMRJr5jv+PrzTO8Whp7ATygRwb 3Gy+UuX0RRBKG4u8VH/QtZAa5EDbdvInwjuQUksbv7RI68kCZCSShH/86/OknXsZ1oaTzRt/A9/ 7RyPhRPSTSrS2XDz4+otJ+X4wJc8pYn2FCLBzLtWUzLLXZMX7BGb6UQrcnvVaAW0qQ9Y9OS6gmc dtToaEDSWQGC8gJopGPgn6wvXS1Vmpv7qr/ROodxYQCbotpXc6B3E3mmpA63UXwxFf4/qJ8fmSq x7PARdN/uYpA7v7qokVXBoqgWvPyo937mQ0yTNengIpachIa+/j7lC5GiJ/uyNoCAjfSaezVyPp sr7V84v8vipZx+Q1rv0eXQnmXxQx71/PVqadVDgMMwZw5yOXTZJQ+zSyvqXTB5dPr+AyK2c7oli nZLyWckF0vQONgk5EoA== X-Authority-Analysis: v=2.4 cv=cK11IVeN c=1 sm=1 tr=0 ts=6ab56dcb cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=9WqIVI+dqUtONkXyCURkzg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5Aoo9DEluPtx4pQJSMQA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: BnEBlmnBSrO8dqFPI0MC9en_KJCmBLt1 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDA3NiBTYWx0ZWRfX2XbT0hhVdVE8 neVPROR+5IIF4PDKMYzbL15v3Bhjwcn9BOkDUEwdckvgPkFcQQgR09Z5OoH1ytKupM0uwWByUSk Bl0XH1hgNDFCh0XHDW2EaF9SF0CNhyY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240076 On 9/23/2026 5:38 PM, Dmitry Baryshkov wrote: > On Wed, Sep 23, 2026 at 04:16:21PM +0530, Arpit Saini wrote: >> Hi Dmitry, >> >> On 9/22/2026 9:33 PM, Dmitry Baryshkov wrote: >>> On Wed, Sep 16, 2026 at 02:41:20PM +0530, Nabige Aala wrote: >>>> From: Arpit Saini >>>> >>>> Enable the Shikra MDSS display subsystem on the Qualcomm >>>> Shikra CQM EVK board and add the DLC0697 MIPI DSI display >>>> panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load >>>> for DSI PHY PLL stability. >>>> >>>> Signed-off-by: Arpit Saini >>>> Signed-off-by: Nabige Aala >>>> --- >>>> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++++++++++++++ >>>> 1 file changed, 118 insertions(+) >>>> >>>> + >>>> +&mdss_dsi0 { >>>> + vdda-supply = <&pm4125_l5>; >>>> + >>>> + status = "okay"; >>>> + >>>> + panel@0 { >>>> + compatible = "dlc,dlc0697", "ilitek,ili7807s"; >>>> + reg = <0>; >>>> + >>>> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; >>>> + >>>> + vddi-supply = <&pm4125_l15>; >>>> + avdd-supply = <&vreg_disp_p>; >>>> + avee-supply = <&vreg_disp_n>; >>>> + >>>> + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; >>> >>> As far as I remember, your panel_bl_en enables an external regulator. >>> Why is it not described in this way? >>> >> >> panel_bl_en is a Qcom's daughter card specific platform signal , it does not feed into the panel. >> >> It is a board-level GPIO on the CQM EVK daughter card used purely for >> platform power sequencing. >> >> Adding panel_bl_en as an external regulator would be misleading and incorrect from a hardware perspective, >> as it is not directly going into the panel. > > Well... Aren't VREG_WLED and WLED_SIN1 / SIN2 directly going to the > panel? > >> >> for the CQM EVK, the backlight is MIPI DCS driven and panel_bl_en is a >> platform-specific sequencing pin, making pinctrl states the >> appropriate binding here. >> >> Could you please take a look at earlier discussion we had and let us know your thoughts ? >> >> https://lore.kernel.org/all/29ca6303-4368-4aeb-b82f-039aa252780a@oss.qualcomm.com/ > > Exactly. The diagram there shows that GPIO 91 (panel_bl_en) is an enable > signal for the WLED regulator, whose output is then fed to the panel. > Hi Dmitry Based on your feedback, I understand that the daughter-card WLED circuit should be modelled as a regulator-controlled device. I am planning the following implementation: vreg_wled: regulator-wled { compatible = "regulator-fixed"; regulator-name = "vreg_wled"; gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>; enable-active-high; }; The panel node will reference it as: wled-supply = <&vreg_wled>; In the panel driver, I will add wled to the existing bulk supply list: static const struct regulator_bulk_data ili7807s_supplies[] = { { .supply = "vddi" }, { .supply = "avdd" }, { .supply = "avee" }, { .supply = "wled" }, }; The existing regulator_bulk_enable() and regulator_bulk_disable() calls in prepare() and unprepare() will then control GPIO 91 through the fixed regulator. Brightness will continue to be controlled through the panel's DCS backlight implementation: wled-supply controls the WLED driver's enable signal. The DCS backlight controls brightness through the panel CABC/PWM output. panel_bl_en and panel_bl_suspend pinctrl states will be removed. Could you please confirm whether this modelling and driver sequence match your expectations? Thanks, Arpit