From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dlan@gentoo.org,
inochiama@outlook.com
Subject: Re: [PATCH v1 1/3] dt-bindings: rtc: sophgo: add RTC for Sophgo CV1800 series SoC.
Date: Thu, 4 Jan 2024 09:32:51 +0100 [thread overview]
Message-ID: <c5f7571e-8c99-4143-bfcd-cfd5b08329a9@linaro.org> (raw)
In-Reply-To: <20231229090643.116575-2-qiujingbao.dlmu@gmail.com>
On 29/12/2023 10:06, Jingbao Qiu wrote:
> Add devicetree binding to describe the RTC for Sophgo CV1800 SoC.
>
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> ---
> This patch depends on the clk driver
> Clk driver link:
> https://lore.kernel.org/all/IA1PR20MB49539CDAD9A268CBF6CA184BBB9FA@IA1PR20MB4953.namprd20.prod.outlook.com/
I don't understand how binding can depend on a driver. This is very
confusing and suggests you write binding for the driver, which is not
what we want.
What's more, I really do not see the dependency here, so your message is
incorrect?
>
> .../bindings/rtc/sophgo,cv1800-rtc.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml
>
You have dependencies between patches, but I do not see this explained
at all. How people can figure out merging strategy if they are not aware
there is dependency?
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 9:06 [PATCH v1 0/3] dt-bindings: riscv: sophgo: add mfd RTC and power for CV1800 Jingbao Qiu
2023-12-29 9:06 ` [PATCH v1 1/3] dt-bindings: rtc: sophgo: add RTC for Sophgo CV1800 series SoC Jingbao Qiu
2024-01-04 8:32 ` Krzysztof Kozlowski [this message]
2024-01-04 10:34 ` Jingbao Qiu
2024-01-04 10:44 ` Krzysztof Kozlowski
2024-01-04 10:49 ` Jingbao Qiu
2023-12-29 9:06 ` [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR " Jingbao Qiu
2024-01-04 8:37 ` Krzysztof Kozlowski
2024-01-04 10:39 ` Jingbao Qiu
2024-01-04 10:45 ` Krzysztof Kozlowski
2023-12-29 9:06 ` [PATCH v1 3/3] dt-bindings: mfd: sophgo: add misc MFD " Jingbao Qiu
2024-01-04 8:35 ` Krzysztof Kozlowski
2024-01-04 11:05 ` Jingbao Qiu
2024-01-04 11:16 ` Krzysztof Kozlowski
2024-01-04 11:42 ` Jingbao Qiu
2024-01-04 12:03 ` Krzysztof Kozlowski
2024-01-05 9:54 ` Jingbao Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f7571e-8c99-4143-bfcd-cfd5b08329a9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).