From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 06/10] ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5 Date: Sun, 18 Sep 2016 11:17:04 -0400 Message-ID: References: <1474054971-16831-1-git-send-email-krzk@kernel.org> <1474054971-16831-7-git-send-email-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1474054971-16831-7-git-send-email-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz , Geert Uytterhoeven , Alban Browaeys , Marc Zyngier List-Id: devicetree@vger.kernel.org Hello Krzysztof, On 09/16/2016 03:42 PM, Krzysztof Kozlowski wrote: > Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and > generates an error: > genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68) > > The GIC requires shared interrupts to be edge rising or level high. > Platform declares support for both. Choose level high everywhere. > > Reported-by: Marek Szyprowski > Reported-by: Geert Uytterhoeven > Reported-by: Alban Browaeys > Cc: Marc Zyngier > Signed-off-by: Krzysztof Kozlowski > --- I tested this patch on an Exynos5800 Peach Pi Chromebook and an Exynos5422 Odroid XU4 board and no regressions were found. Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America