From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swati Agarwal <swati.agarwal@oss.qualcomm.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable wakeup for primary USB controller
Date: Mon, 16 Feb 2026 13:57:12 +0100 [thread overview]
Message-ID: <c64e5211-5ca6-4c8a-bf4c-41ca54853ba8@kernel.org> (raw)
In-Reply-To: <20260215183325.3836178-3-swati.agarwal@oss.qualcomm.com>
On 15/02/2026 19:33, Swati Agarwal wrote:
> Add the "wakeup-source" property to the primary port controller node so its
> interrupt can wake the system from low‑power states on lemans EVK
> platform.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/lemans-evk.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index 90fce947ca7e..50620b557404 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> @@ -515,6 +515,8 @@ usb-typec@67 {
> pinctrl-0 = <&usb_id>, <&usb0_intr_state>;
> pinctrl-names = "default";
>
> + wakeup-source;
I don't think this was tested. Please read internal guideline which asks
you about specific steps YOU MUST do.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-02-16 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 18:33 [RFC PATCH 0/2] Add wakeup support from system suspend Swati Agarwal
2026-02-15 18:33 ` [RFC PATCH 1/2] usb: typec: hd3ss3220: " Swati Agarwal
2026-02-16 12:57 ` Krzysztof Kozlowski
2026-02-24 7:50 ` Dmitry Baryshkov
2026-02-15 18:33 ` [RFC PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable wakeup for primary USB controller Swati Agarwal
2026-02-16 11:22 ` Konrad Dybcio
2026-02-16 12:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c64e5211-5ca6-4c8a-bf4c-41ca54853ba8@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=swati.agarwal@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox