From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB783594B for ; Mon, 9 Dec 2024 13:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733750903; cv=none; b=MmfF6CgszHm/IHogLdXWQtXa1nMo+okzXMRMFmHN+C5TP7LgCog8C4wis5CNoEvE3EtbjaROf8K2Fwsqjy+8MHW9pmo516m/DXaaIC7jgf0nO5MeylQDEX5p/+njIPwQK4/ArOofrYSRaeUAtxshLiKxi8NwFByJ06t77+Y68hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733750903; c=relaxed/simple; bh=LdtLkb6g5/mYpUpJpgsKBP9UX9MGU4r33wuzmCaef1k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iXvWQ8vVWQMm7WiM5WrogDo7Y4Ps4aALR5DrD/sYXzRQ4LZDmMt9AYkDHVD2Psa0Zns7IqgEZKQWbYo7vgAafFQrEHloQTgVRnH+m0FSsh/0TYVZia/U1JpqGUis8hhkitAaT1qWvsJirEwB4q+FQCBQWO8MyAjMD9ktqlPXPEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=nQlHcl2f; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="nQlHcl2f" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-435004228c0so854855e9.0 for ; Mon, 09 Dec 2024 05:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733750899; x=1734355699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=El/TOZDLV/Adncw2igrq2Gpvgb3sMBAUyZwK9Lxfyn8=; b=nQlHcl2fX30nw3H+df5FwYFuDnEuQXeiO8VEnOiPRwHdiA1GB2jme0K2vpSjg8Hlu1 fAWf7Tf1Bm93maXY7Bz3XgRl8nwJ+lNcYDNMuv3pLsfOLUOGIMD+o1vqM/pivWCd0nYM IMdNg1kZBPf/Fa8ArUsTrQAm1s38xN0UHf2GzG7cEfG+T/SwU60OZamOk7sjrr5Bg6du CASaQtghB2Ys+NEW1dk0ClSPgHYqOuunmS1b0XkZEM25vWLWfcScKGw2ijCQKwh/oFwg s4+75N3P3E4agEaXGu+/frPpM5LZMsnFoKSd9QRQ0dspvcxIHIR4y7cPy+7Eye5xZQKR gxOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733750899; x=1734355699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=El/TOZDLV/Adncw2igrq2Gpvgb3sMBAUyZwK9Lxfyn8=; b=JXT34c/FR8LUdxE4rbfUHoNkW6NL+XThJ2P4HfE+tpxsgYZfjqPACPujqlvo9REFJw wJAfgPSt4DsaQJmHmChZkfoRj8qdr7Q+ieIkx4PMhMIgOgRJOXaxThKY+VjWIA3/y9RH WCgaY56UilnNQ3eAtbO4G9Fwsaa1mXVNG9bzlphUgNQYd4zIQvlmbqewVehdviVREqK3 /Ih324V9ame24apddKUrAQ4DulljJnuBupERCTvzrfEycPNJPkfo7mz6jSzhZyt20VOB 2eADe1kW4Vqsmc5Vm3VkNR4FTLaxLvSh4j6kkfRYkv16rCULjq5IlQLN/nbKIZj3RmlZ 3d0A== X-Forwarded-Encrypted: i=1; AJvYcCWFKLv2Y+fNhIPFx4mS/61QLCecT3C9qVYsRgdB0ecdYEV0GYzWs0p9nE84QQZj8zbOG0Gxb/TeGaDA@vger.kernel.org X-Gm-Message-State: AOJu0YwHPN4fVwdjXvRiMCostEiNY9sbd2Dsr5CW2RCpaS7cwkHrs92U k2R7hfW60ZzEbOoE3cDMX8WOEXp2fZ1elSS+5jTrWj3k82ae5T44EM6uHFtwiQrWKWbkhpn/qhE O X-Gm-Gg: ASbGncsO7JSUw7//zX9ZaSOX9PQ76Zw9MJ4PT4vBBO5xeOovcIfR2rm+Zaw3z4RvxZU q4Awd2uMOjPmmWDE3rY9ZMRcIhwDQ4AGnNmFKljuvBnIiFrXXXfPsF/tXMZVO0kBRsL8RA0Bh2b s5RDgZC0bJy2sLKcQKRTvmHeKYIZKwdIiz5KBsmkZ7EC5t7FBJMgRcgMPznodA/IVCKrzqkRKVo 3K2uHQQoJY8Ay8+0pTL5zCZTH5uCTHB/QsYPNFqTPat/e9HVh3kH4FWyUI= X-Google-Smtp-Source: AGHT+IHd1DkHzh1NVNjC22X5kRB98anOoYPZpCUeVEirns6S3aaWq7ub1ihZAzLS2qCt8RPK8fYhhg== X-Received: by 2002:a05:6000:1868:b0:385:fd24:3317 with SMTP id ffacd0b85a97d-386453cf868mr528412f8f.1.1733750899061; Mon, 09 Dec 2024 05:28:19 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa67f4c4ae4sm214590966b.111.2024.12.09.05.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 05:28:18 -0800 (PST) Message-ID: Date: Mon, 9 Dec 2024 15:28:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/25] ASoC: renesas: rz-ssi: Terminate all the DMA transactions Content-Language: en-US To: Geert Uytterhoeven Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, linus.walleij@linaro.org, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org References: <20241113133540.2005850-1-claudiu.beznea.uj@bp.renesas.com> <20241113133540.2005850-7-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, Geert, On 09.12.2024 15:15, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Wed, Nov 13, 2024 at 2:35 PM Claudiu wrote: >> From: Claudiu Beznea >> >> In case of full duplex the 1st closed stream doesn't benefit from the >> dmaengine_terminate_async(). Call it after the companion stream is >> closed. >> >> Fixes: 4f8cd05a4305 ("ASoC: sh: rz-ssi: Add full duplex support") >> Cc: stable@vger.kernel.org >> Reviewed-by: Biju Das >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> Changes in v3: >> - collected tags >> - use proper fixes commit SHA1 and description > > I am not sure which one is the correct one: the above, or commit> 26ac471c5354583c ("ASoC: sh: rz-ssi: Add SSI DMAC support")... IIRC, I had this one on the previous version but in the review process it has been proposed to used 4f8cd05a4305 ("ASoC: sh: rz-ssi: Add full duplex support"). I think 4f8cd05a4305 ("ASoC: sh: rz-ssi: Add full duplex support") is the right one as the issue is related to full duplex. > >> --- a/sound/soc/renesas/rz-ssi.c >> +++ b/sound/soc/renesas/rz-ssi.c >> @@ -415,8 +415,12 @@ static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) >> rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TEN | SSICR_REN, 0); >> >> /* Cancel all remaining DMA transactions */ >> - if (rz_ssi_is_dma_enabled(ssi)) >> - dmaengine_terminate_async(strm->dma_ch); >> + if (rz_ssi_is_dma_enabled(ssi)) { >> + if (ssi->playback.dma_ch) >> + dmaengine_terminate_async(ssi->playback.dma_ch); >> + if (ssi->capture.dma_ch) >> + dmaengine_terminate_async(ssi->capture.dma_ch); >> + } > > rz_ssi_stop() is called twice: once for capture, and a second time for > playback. How come that doesn't stop both? It is called from this path: static int rz_ssi_dai_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai) { // ... case SNDRV_PCM_TRIGGER_STOP: rz_ssi_stop(ssi, strm); rz_ssi_stream_quit(ssi, strm); // ... } rz_ssi_stop() is as follow: static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) { strm->running = 0; if (rz_ssi_is_stream_running(&ssi->playback) || rz_ssi_is_stream_running(&ssi->capture)) return 0; // ... } rz_ssi_is_stream_running() is as follows: static inline bool rz_ssi_is_stream_running(struct rz_ssi_stream *strm) { return strm->substream && strm->running; } The strm->substream is set to NULL in: static void rz_ssi_stream_quit(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) { struct snd_soc_dai *dai = rz_ssi_get_dai(strm->substream); rz_ssi_set_substream(strm, NULL); // ... } Thus, when the 1st full duplex stream is closed, as the companion stream is still running it doesn't benefit from dmaengine_terminate_async(). I'll update the commit description in the next version. Thank you for your review, Claudiu > Perhaps the checks at the top of rz_ssi_stop() are not correct? > Disclaimer: I am no sound expert, so I may be missing something... > >> >> rz_ssi_set_idle(ssi); > > Gr{oetje,eeting}s, > > Geert >