From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Saenz Julienne <nsaenzjulienne@suse.de>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: devicetree@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: nvmem: Add missing 'reg' property
Date: Thu, 9 Dec 2021 17:32:38 +0000 [thread overview]
Message-ID: <c676e23c-3c44-c28c-d572-499fe8d4ee8f@linaro.org> (raw)
In-Reply-To: <20211206174133.2296265-1-robh@kernel.org>
On 06/12/2021 17:41, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the following warnings
> are generated in the nvmem examples:
>
> Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)
>
> Add the missing 'reg' property definition.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Rafał Miłecki <rafal@milecki.pl>
> Cc: Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied thanks,
--srini
> ---
> Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++
> Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++
> Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> index 58ff6b0bdb1a..8c3f0cd22821 100644
> --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> @@ -24,6 +24,9 @@ properties:
> compatible:
> const: brcm,nvram
>
> + reg:
> + maxItems: 1
> +
> unevaluatedProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> index 1d85a0a30846..a4a755dcfc43 100644
> --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> @@ -19,6 +19,9 @@ properties:
> - raspberrypi,bootloader-config
> - const: nvmem-rmem
>
> + reg:
> + maxItems: 1
> +
> no-map:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> index a48c8fa56bce..448a2678dc62 100644
> --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> @@ -24,6 +24,9 @@ properties:
> - st,stm32f4-otp
> - st,stm32mp15-bsec
>
> + reg:
> + maxItems: 1
> +
> patternProperties:
> "^.*@[0-9a-f]+$":
> type: object
>
prev parent reply other threads:[~2021-12-09 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 17:41 [PATCH] dt-bindings: nvmem: Add missing 'reg' property Rob Herring
2021-12-07 8:24 ` Thierry Reding
2021-12-07 8:36 ` Fabrice Gasnier
2021-12-09 17:32 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c676e23c-3c44-c28c-d572-499fe8d4ee8f@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).