From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1A1A19046C; Wed, 5 Jun 2024 06:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717570742; cv=none; b=PoeZJzWUNAWdIHgelrb7XhIVJeZV7bbXqJpFVSqWUksclo2vG3CxvJhUzyXWAH/+qPG9Imhg+T8vO9aaEN8vbKiTmnzJTr7eMie+60q+8rcZWdzutrXZjr72UL2L8+tHWNxd+jtycxSM5QSoAaPdfqU0wt1ghNsmrg5Fyq9pm9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717570742; c=relaxed/simple; bh=RK17L3ehEBa/FE8txETH5XiKDKfaUnTO0BEmBdKkqAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tsx9UsknrZSTr+lUj8Vnw2m1NAhZp1od20P06gHI9e0UA2ZlpMOEU9WT88J1nuTzbcYrB5AJJ5HI940wkpclmk1TW1wsDx1T9cpas4H9QgwPvLB1R/E1bbd0ggEroePJ/oMnfJ/ZseykSUmP7B5GAJELh0TzgjvugwXteSSgoWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YrqNa4Or; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YrqNa4Or" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E27B5C3277B; Wed, 5 Jun 2024 06:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717570742; bh=RK17L3ehEBa/FE8txETH5XiKDKfaUnTO0BEmBdKkqAw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YrqNa4OrE09aAWr+SV8D0H3sK9UqosrvMSud478y2Nu1O9by7kTL1jqSblAv2Ld4k Bmh2JHdgetYRCJHeo7zDTKm/QviREXQpy5Cz4RDjVyCSfxty7OUkFZ9eryaisM41IR yxJxCXn762i6thtCoQhXVIRI8lfck21kTq6JIKLZDg02x6bpP6WbzWIHZq3ZO1Cgdh QneDLfRPZsntDIAX6u382lw7skTO+0BqukhfBNLUEqSOPkWqt53XCtuJZxiNIPfna1 475AqaUDjCOmOOJDfBGCfTa/W10zYrEMs2QJowNS8ti02R1iWPkdG47EpWWQrZpNQC Vp87xNMOxdd9A== Message-ID: Date: Wed, 5 Jun 2024 08:58:55 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source To: Abhinav Kumar , Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20240520-dpu-handle-te-signal-v1-1-f273b42a089c@linaro.org> <224fa477-07ba-e7b2-2f7d-8f7d21f4a0c7@quicinc.com> <5cde2f43-89ab-d2d4-d68e-605f8f5d1da7@quicinc.com> <4b604c91-7b1f-46b3-6b41-fe7d45190b78@quicinc.com> <74bc1fc0-2843-4d4a-ae6c-b656745bf02f@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/06/2024 19:52, Abhinav Kumar wrote: > > > On 6/4/2024 8:36 AM, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:32, Dmitry Baryshkov wrote: >>> On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >>>> On 04/06/2024 17:14, Dmitry Baryshkov wrote: >>>>>>>>>> >>>>>>>>>> I didnt follow why this is a link property. Sorry , I didnt follow the >>>>>>>>>> split part. >>>>>>>>> >>>>>>>>> There is a link between the DSI host and the panel. I don't want to >>>>>>>>> end up in a situation when the properties of the link are split >>>>>>>>> between two different nodes. >>>>>>>>> >>>>>>>> >>>>>>>> It really depends on what the property denotes. I do not think this >>>>>>>> should be the reason to do it this way. >>>>>>> >>>>>>> It denotes how the panel signals DPU that it finished processing the >>>>>>> data (please excuse me for possibly inaccurate description). However >>>>>>> there is no direct link between the panel and the DPU. So we should be >>>>>>> using a link between DSI host and the panel. >>>>>>> >>>>>> >>>>>> Yes, I totally agree that we should be using a link between DSI host and the >>>>>> panel. >>>>>> >>>>>> My question from the beginning has been why the output port? >>>>>> >>>>>> It looks like to me we need to have another input port to the controller >>>>>> then? >>>>>> >>>>>> One from DPU and the other from panel? >>>>> >>>>> Dear DT maintainers, could you please comment on the OF graph entries? >>>>> Are they considered to be unidirectional or bidirectional? >>>>> >>>>> Would you suggest adding another arc to the OF graph in our case or is >>>>> it fine to have a signal generated by the panel in the 'panel_in' port? >>>> >>>> Which pin are we talking about? DSI or panel? Commit msg suggests DSI, >>>> so property is in DSI node part. Seems logical to me. >>> >>> Input pin on the DSI side. >> >> So adding it to panel schema is not even possible thus I am not sure if >> we discuss this option (maybe not, because it would be odd, considering >> you got Rb tag!). >> >> Adding some input node to DSI connecting panel output and DSI input... >> for what? I mean, what sort of data would it represent? >> > > TE pin is an input signal from the panel to the DSI host. > > Today we have two ports in the DSI host node: > > 1) input to DSI node from DPU. This represents the pixel stream from DPU > to DSI > > 2) DSI output node to represent pixel stream from DSI host to panel in > > Now, please explain to me how does TE pin belongs to (2) because thats > where this property has been added. Don't get what is a DPU, but anyway connections are kind of bi-directional. So TE belongs there because this is the connection between the DSI and the panel, with generic meaning that data flows from the DSI to the panel. Why we keep discussing this? You really need 3rd ack or this is just bikeschedding? Best regards, Krzysztof