From: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
To: thor.thayer@linux.intel.com, netdev@vger.kernel.org,
dinguyen@kernel.org, richardcochran@gmail.com,
davem@davemloft.net, vbridger@opensource.altera.com,
robh+dt@kernel.org, devicetree@vger.kernel.org,
hean.loong.ong@intel.com
Subject: Re: [PATCH v2 net-next 06/10] net: eth: altera: Add missing identifier names to function declarations
Date: Tue, 18 Dec 2018 07:52:17 -0800 [thread overview]
Message-ID: <c684e04706a66bc272e52d1f1363c1935c22cd41.camel@linux.intel.com> (raw)
In-Reply-To: <03169cb9-2fcc-c849-7f40-b5f3044ef53d@linux.intel.com>
On Tue, 2018-12-18 at 09:45 -0600, Thor Thayer wrote:
> Hi Dalon,
>
> On 12/13/18 11:52 AM, dwesterg@gmail.com wrote:
> > From: Dalon Westergreen <dalon.westergreen@linux.intel.com>
> >
> > The sgdma and msgdma header files included function declarations
> > without identifier names for pointers. Add appropriate identifier
> > names.
> >
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@linux.intel.com>
> > ---
> > drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++---------
> > drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++----------
> > 2 files changed, 33 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/altera/altera_msgdma.h
> > b/drivers/net/ethernet/altera/altera_msgdma.h
> > index 42cf61c81057..e18be91a48a7 100644
> > --- a/drivers/net/ethernet/altera/altera_msgdma.h
> > +++ b/drivers/net/ethernet/altera/altera_msgdma.h
> > @@ -17,19 +17,21 @@
> > #ifndef __ALTERA_MSGDMA_H__
> > #define __ALTERA_MSGDMA_H__
> >
> > -void msgdma_reset(struct altera_tse_private *);
> > -void msgdma_enable_txirq(struct altera_tse_private *);
> > -void msgdma_enable_rxirq(struct altera_tse_private *);
> > -void msgdma_disable_rxirq(struct altera_tse_private *);
> > -void msgdma_disable_txirq(struct altera_tse_private *);
> > -void msgdma_clear_rxirq(struct altera_tse_private *);
> > -void msgdma_clear_txirq(struct altera_tse_private *);
> > -u32 msgdma_tx_completions(struct altera_tse_private *);
> > -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
> > -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *);
> > -u32 msgdma_rx_status(struct altera_tse_private *);
> > -int msgdma_initialize(struct altera_tse_private *);
> > -void msgdma_uninitialize(struct altera_tse_private *);
> > -void msgdma_start_rxdma(struct altera_tse_private *);
> > +void msgdma_reset(struct altera_tse_private *priv);
> > +void msgdma_enable_txirq(struct altera_tse_private *priv);
> > +void msgdma_enable_rxirq(struct altera_tse_private *priv);
> > +void msgdma_disable_rxirq(struct altera_tse_private *priv);
> > +void msgdma_disable_txirq(struct altera_tse_private *priv);
> > +void msgdma_clear_rxirq(struct altera_tse_private *priv);
> > +void msgdma_clear_txirq(struct altera_tse_private *priv);
> > +u32 msgdma_tx_completions(struct altera_tse_private *priv);
> > +void msgdma_add_rx_desc(struct altera_tse_private *priv,
> > + struct tse_buffer *buffer);
> > +int msgdma_tx_buffer(struct altera_tse_private *priv,
> > + struct tse_buffer *buffer);
> > +u32 msgdma_rx_status(struct altera_tse_private *priv);
> > +int msgdma_initialize(struct altera_tse_private *priv);
> > +void msgdma_uninitialize(struct altera_tse_private *priv);
> > +void msgdma_start_rxdma(struct altera_tse_private *priv);
> >
> > #endif /* __ALTERA_MSGDMA_H__ */
> > diff --git a/drivers/net/ethernet/altera/altera_sgdma.h
> > b/drivers/net/ethernet/altera/altera_sgdma.h
> > index 584977e29ef9..769e720a2043 100644
> > --- a/drivers/net/ethernet/altera/altera_sgdma.h
> > +++ b/drivers/net/ethernet/altera/altera_sgdma.h
> > @@ -17,20 +17,22 @@
> > #ifndef __ALTERA_SGDMA_H__
> > #define __ALTERA_SGDMA_H__
> >
> > -void sgdma_reset(struct altera_tse_private *);
> > -void sgdma_enable_txirq(struct altera_tse_private *);
> > -void sgdma_enable_rxirq(struct altera_tse_private *);
> > -void sgdma_disable_rxirq(struct altera_tse_private *);
> > -void sgdma_disable_txirq(struct altera_tse_private *);
> > -void sgdma_clear_rxirq(struct altera_tse_private *);
> > -void sgdma_clear_txirq(struct altera_tse_private *);
> > -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *);
> > -u32 sgdma_tx_completions(struct altera_tse_private *);
> > -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer
> > *);
> > -void sgdma_status(struct altera_tse_private *);
> > -u32 sgdma_rx_status(struct altera_tse_private *);
> > -int sgdma_initialize(struct altera_tse_private *);
> > -void sgdma_uninitialize(struct altera_tse_private *);
> > -void sgdma_start_rxdma(struct altera_tse_private *);
> > +void sgdma_reset(struct altera_tse_private *priv);
> > +void sgdma_enable_txirq(struct altera_tse_private *priv);
> > +void sgdma_enable_rxirq(struct altera_tse_private *priv);
> > +void sgdma_disable_rxirq(struct altera_tse_private *priv);
> > +void sgdma_disable_txirq(struct altera_tse_private *priv);
> > +void sgdma_clear_rxirq(struct altera_tse_private *priv);
> > +void sgdma_clear_txirq(struct altera_tse_private *priv);
> > +int sgdma_tx_buffer(struct altera_tse_private *priv,
> > + struct tse_buffer *buffer);
> > +u32 sgdma_tx_completions(struct altera_tse_private *priv);
> > +void sgdma_add_rx_desc(struct altera_tse_private *priv,
> > + struct tse_buffer *buffer);
> > +void sgdma_status(struct altera_tse_private *priv);
> > +u32 sgdma_rx_status(struct altera_tse_private *priv);
> > +int sgdma_initialize(struct altera_tse_private *priv);
> > +void sgdma_uninitialize(struct altera_tse_private *priv);
> > +void sgdma_start_rxdma(struct altera_tse_private *priv);
> >
> > #endif /* __ALTERA_SGDMA_H__ */
> >
>
> FYI. Since this is a change in v2, there is normally a break below your
> Signed-off-by and then a description of what changed (in this case new
> patch). This isolates the changes to the patch even though you put it in
> the summary patch. So it would look like this
>
> <snip>
> >
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@linux.intel.com>
> > ---
> > v2 New patch cleanup that adds the pointer identifier names.
> > ---
> > drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++---------
> > drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++----------
> </snip>
Thanks, I will add that in.
>
> Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
next prev parent reply other threads:[~2018-12-18 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 17:52 [PATCH v2 net-next 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher dwesterg
2018-12-13 17:52 ` [PATCH v2 net-next 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response dwesterg
2018-12-18 15:32 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 02/10] net: eth: altera: set rx and tx ring size before init_dma call dwesterg
2018-12-18 15:33 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 03/10] net: eth: altera: fix altera_dmaops declaration dwesterg
2018-12-18 15:33 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 04/10] net: eth: altera: add optional function to start tx dma dwesterg
2018-12-18 15:34 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 05/10] net: eth: altera: Move common functions to altera_utils dwesterg
2018-12-18 15:37 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 06/10] net: eth: altera: Add missing identifier names to function declarations dwesterg
2018-12-18 15:45 ` Thor Thayer
2018-12-18 15:52 ` Dalon L Westergreen [this message]
2018-12-13 17:52 ` [PATCH v2 net-next 07/10] net: eth: altera: change tx functions to type netdev_tx_t dwesterg
2018-12-18 15:48 ` Thor Thayer
2018-12-13 17:52 ` [PATCH v2 net-next 08/10] net: eth: altera: add support for ptp and timestamping dwesterg
2018-12-19 4:27 ` Richard Cochran
2018-12-19 19:27 ` Westergreen, Dalon
2018-12-13 17:52 ` [PATCH v2 net-next 09/10] net: eth: altera: add msgdma prefetcher dwesterg
2018-12-18 16:33 ` Thor Thayer
2018-12-18 17:00 ` Dalon L Westergreen
2018-12-13 17:52 ` [PATCH v2 net-next 10/10] net: eth: altera: update devicetree bindings documentation dwesterg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c684e04706a66bc272e52d1f1363c1935c22cd41.camel@linux.intel.com \
--to=dalon.westergreen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=hean.loong.ong@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thor.thayer@linux.intel.com \
--cc=vbridger@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).