From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0479FC43334 for ; Mon, 11 Jul 2022 11:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbiGKLQ5 (ORCPT ); Mon, 11 Jul 2022 07:16:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbiGKLQ2 (ORCPT ); Mon, 11 Jul 2022 07:16:28 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A415642E for ; Mon, 11 Jul 2022 03:38:33 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a9so7952234lfk.11 for ; Mon, 11 Jul 2022 03:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=NQoLzRBeO+sL0DWQtHTbM5QZDiRRY6R4q4RQs20xXvA=; b=VuG4aVjx+zQiHH6/kPNj8R2eOimlBGti8XEdbUYQ2Vzl8PAd+e6IKmdsu/22AD/P9J GBLC8aPdQl4arslGU3tOOFwPWIDP2UMS/J8MIRBRf4cndEtQQkmEmPGM7T0hqSHMpkrF tAtnCKNGdc6oKwIdwA36bJn4wyo5/LkekRWOLymdOn1fWMrn2XtvywH5xvHp1TrP/avW iX6YLCwq8rCRB9v8xv2rY6x8nhXIQGklitoDpL3NYTrSeVbbkvGJDJJoKWomVVeE5Mvl AiUG7/szAUZVaOF6hGneN2SDoMLOqoB9Dx+8uw4kNZge2pcZ2lc5Knd6JVVSpI+bj4Yy +aFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NQoLzRBeO+sL0DWQtHTbM5QZDiRRY6R4q4RQs20xXvA=; b=5UjM/JaU05/POzycNyiIDX+2RZEf40eAUQVV4h32YL8MWp6C5J6qJ+gY1PBm60n158 sKDwtSLKuMuYQ4I/RSvwhbXK9jGrI6/wN4JHfwbzkLOQRK6WpbnLdA+weM2GifUMl573 hsLbAPDzbHd7po6aXO7+I/9KYpdYVuMaVt3bAsdsTefz1DIXHw5Ooo1u+ivwlS7hEvxk qJneFo4FSf0WjoblsO4HrK1JkS+y+bjUsKmH2M9dbxrY6MJJso0+I6zx812BgrDmW1l5 xJZ8C/PuFPF/qFJtK5Kb8O3WkAbEU0Q0PTnLbZ7nchZ7q+sSkX9FjTBSV6azcfiywjry JFmQ== X-Gm-Message-State: AJIora9+n9mLcSRBT3iKwoHbr3541y5xlnVDGjEzpz1R1Fb6SmdzRlaW NajcxPzNI0Haz+qjDfPvGcZmMg== X-Google-Smtp-Source: AGRyM1tquCCB6Z0O+3aVgYSykP26Ez+/mnUfsPpGejuwSkfD9boKKoCZ6uAeHfwKQYC2bBpSQDcrLQ== X-Received: by 2002:a05:6512:1151:b0:481:1675:f343 with SMTP id m17-20020a056512115100b004811675f343mr10988046lfg.280.1657535911823; Mon, 11 Jul 2022 03:38:31 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id p13-20020a2e804d000000b0025a885a135csm1665054ljg.119.2022.07.11.03.38.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 03:38:31 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 12:38:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/3] dt-binding: power: power-domain: add power-supply-needs-irq Content-Language: en-US To: Martin Kepplinger , rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org, robh@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220711094549.3445566-1-martin.kepplinger@puri.sm> <20220711094549.3445566-2-martin.kepplinger@puri.sm> From: Krzysztof Kozlowski In-Reply-To: <20220711094549.3445566-2-martin.kepplinger@puri.sm> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2022 11:45, Martin Kepplinger wrote: > Add the power-supply-needs-irq board description property for power domains. Where is a board description here? I think you just meant "power-supply-needs-irq property"? > > Signed-off-by: Martin Kepplinger > --- > .../devicetree/bindings/power/power-domain.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml > index 889091b9814f..e82c2f7ccb97 100644 > --- a/Documentation/devicetree/bindings/power/power-domain.yaml > +++ b/Documentation/devicetree/bindings/power/power-domain.yaml > @@ -70,6 +70,16 @@ properties: > by the given provider should be subdomains of the domain specified > by this binding. > > + power-supply: true This is a new property not described in the commit msg. > + > + power-supply-needs-irq: > + type: boolean > + description: > + A power-supply can link for example to a regulator controlled via > + i2c or otherwise needing interrupts enabled to be able to enable and > + disable. Not really a property of power domain. How the regulator supply works is entirely up to regulator. Otherwise such property should appear for every device. > This property makes various callbacks usually run in the > + noirq phase, being run when interrupts are available. Last sentence does not fit - you embed Linux implementation into DT bindings. noirq phase is Linux specific. > + > required: > - "#power-domain-cells" > Best regards, Krzysztof