From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B55B2030B for ; Mon, 9 Oct 2023 21:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XVQJc+0r" Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08980A3 for ; Mon, 9 Oct 2023 14:12:39 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5031ccf004cso5942513e87.2 for ; Mon, 09 Oct 2023 14:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696885957; x=1697490757; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jGoGhItmjXMm5592hTQT86oDx5AEAugpeAAG92Ldv9c=; b=XVQJc+0rZA8e6WctYFLbKYDlqtPNU0ZOYg/EpwZlsFUo4wMxi/Kwi+8ys0qxhealS8 JVvJKdvbUZs9jSIwbRiT5f6faiSGpnnpbzof2hFjrHZBOozuBpMTlWoicCDA49T44VZj rBuRFOtEw7uN+kDke20ZmGLdqDk7hggxhnFqD+IoFyJfBCp4Ve9sRZaSHszSWM91jhIJ 8v0PVpGGQbI/J0z5BRwruraF3K1wAiPFoRtloMxCKnIldNmVpQmJT+D+exEO4fNWc4SB tycTDPKn/zpB+dVuXUqA/itEo477KlsAekt6b4BVAm/o2NNxZw5LV9e+ikfOZTJfuLMq 4KnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696885957; x=1697490757; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jGoGhItmjXMm5592hTQT86oDx5AEAugpeAAG92Ldv9c=; b=aC81MW3dQcfSCtxi4e5AAkSWS0D6tv3R5Ze3be2UCFI3Fbm+0eZ44zYG5ZssgQwzS9 +RRNy2lW2Pjc/yiIoHgtajkKUQ1nGAQpzeeQEbwxnXfGwNp2ma5VvC492dEZF/d3OyyC 1etFfiigLBeH/8I2/+snz7FUfAeZvmRt+IqtJMSm+uGsV59ksw5S8YiJNE7N1h1hTXfD k8Apag+4hdai2abXPYmENgWzrGwJrMplrdNzxVh9kzb1c0BVjqEt7DPSq6MrO2SUkhxN M0vT4GWgXbXUztClwnJlbZkSo6cy+zPCMv83MPU+Cs1w5gpMnBPc8E4TFFawKTHoZbyV OURg== X-Gm-Message-State: AOJu0YxxcLGl3msvAwUaPJLFm8WWidsODfE8DpfKrMa+4BIoqnwTfS2/ DDUQhXtBdZMwJlmSzmgW2UbYtw== X-Google-Smtp-Source: AGHT+IES2gxCqlfZ4jVm2fkrFudmIdnYvMcqyuJquOODcke/lKVXTFzg0TPAm6K5BgdJCoKWv5t6WA== X-Received: by 2002:a05:6512:138e:b0:503:7dd:7ebc with SMTP id fc14-20020a056512138e00b0050307dd7ebcmr18050066lfb.18.1696885957242; Mon, 09 Oct 2023 14:12:37 -0700 (PDT) Received: from [172.30.204.90] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id w10-20020a19c50a000000b005056efabed0sm1563171lfe.29.2023.10.09.14.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 14:12:36 -0700 (PDT) Message-ID: Date: Mon, 9 Oct 2023 23:12:34 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] arm64: dts: qcom: sc7180: Add UFS nodes Content-Language: en-US To: David Wronek , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Joe Mason Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, hexdump0815@googlemail.com, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20231007140053.1731245-1-davidwronek@gmail.com> <20231007140053.1731245-6-davidwronek@gmail.com> From: Konrad Dybcio In-Reply-To: <20231007140053.1731245-6-davidwronek@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 10/7/23 15:58, David Wronek wrote: > Add the UFS and QMP PHY nodes for the Qualcomm SC7180 SoC. > > Signed-off-by: David Wronek > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 70 ++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 11f353d416b4..9f18be4fd61a 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1532,6 +1532,76 @@ mmss_noc: interconnect@1740000 { > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > + ufs_mem_hc: ufshc@1d84000 { > + compatible = "qcom,sc7180-ufshc", "qcom,ufshc", > + "jedec,ufs-2.0"; > + reg = <0 0x01d84000 0 0x3000>, > + <0 0x01d90000 0 0x8000>; > + reg-names = "std", "ice"; Recently the ICE was separated into its own node > + interrupts = ; > + phys = <&ufs_mem_phy>; > + phy-names = "ufsphy"; > + lanes-per-direction = <1>; > + power-domains = <&gcc UFS_PHY_GDSC>; > + #reset-cells = <1>; > + resets = <&gcc GCC_UFS_PHY_BCR>; > + reset-names = "rst"; > + > + iommus = <&apps_smmu 0xa0 0x0>; > + > + clock-names = > + "core_clk", Remove the newline after the =, here and below > + "bus_aggr_clk", > + "iface_clk", > + "core_clk_unipro", > + "ref_clk", > + "tx_lane0_sync_clk", > + "rx_lane0_sync_clk", > + "ice_core_clk"; > + clocks = > + <&gcc GCC_UFS_PHY_AXI_CLK>, > + <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, > + <&gcc GCC_UFS_PHY_AHB_CLK>, > + <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>, > + <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, > + <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, > + <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; > + freq-table-hz = > + <50000000 200000000>, > + <0 0>, > + <0 0>, > + <37500000 150000000>, > + <0 0>, > + <0 0>, > + <0 0>, > + <0 300000000>; > + > + interconnects = <&aggre1_noc MASTER_UFS_MEM 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_UFS_MEM_CFG 0>; Please make the + interconnect-names = "ufs-ddr", "cpu-ufs"; > + > + status = "disabled"; > + }; > + > + ufs_mem_phy: phy@1d87000 { > + compatible = "qcom,sc7180-qmp-ufs-phy"; > + reg = <0 0x01d87000 0 0x1000>; > + > + clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, > + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; Please align the