From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
linux-remoteproc@vger.kernel.org, agross@kernel.org,
andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com,
perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org,
mathieu.poirier@linaro.org, corbet@lwn.net
Subject: Re: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
Date: Sun, 8 Jan 2023 16:36:29 +0100 [thread overview]
Message-ID: <c6ea3f37-fe5a-9a61-3a02-99bc036fd23e@linaro.org> (raw)
In-Reply-To: <1672991425-898-1-git-send-email-quic_srivasam@quicinc.com>
On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote:
> Add reg-names and power-domain-names for remoteproc ADSP pheripheral
> loader. This is to make compatible with remoteproc ADSP PIL driver.
I don't understand the reasoning. Before binding was "incompatible"?
> Also change power domain from LCX to CX.
Why? Hardware changed?
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Changes Since v1:
> -- Modify subject line to SoC specific.
>
> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> index 94ca7a0..b5bee2c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> @@ -23,6 +23,11 @@ properties:
> - description: qdsp6ss register
> - description: efuse q6ss register
>
> + reg-names:
> + items:
> + - const: qdsp6ss_base
> + - const: lpass_efuse
> +
> iommus:
> items:
> - description: Phandle to apps_smmu node with sid mask
> @@ -57,7 +62,11 @@ properties:
>
> power-domains:
> items:
> - - description: LCX power domain
> + - description: CX power domain
> +
> + power-domain-names:
> + items:
> + - const: cx
>
> resets:
> items:
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-08 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 7:50 [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names Srinivasa Rao Mandadapu
2023-01-08 15:36 ` Krzysztof Kozlowski [this message]
2023-01-10 6:27 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ea3f37-fe5a-9a61-3a02-99bc036fd23e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).