* [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
@ 2023-01-06 7:50 Srinivasa Rao Mandadapu
2023-01-08 15:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2023-01-06 7:50 UTC (permalink / raw)
To: linux-remoteproc, agross, andersson, lgirdwood, broonie, robh+dt,
quic_plai, bgoswami, perex, tiwai, srinivas.kandagatla,
quic_rohkumar, linux-arm-msm, linux-kernel, swboyd, judyhsiao,
devicetree, krzysztof.kozlowski, mathieu.poirier, corbet
Cc: Srinivasa Rao Mandadapu
Add reg-names and power-domain-names for remoteproc ADSP pheripheral
loader. This is to make compatible with remoteproc ADSP PIL driver.
Also change power domain from LCX to CX.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
Changes Since v1:
-- Modify subject line to SoC specific.
.../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
index 94ca7a0..b5bee2c 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
@@ -23,6 +23,11 @@ properties:
- description: qdsp6ss register
- description: efuse q6ss register
+ reg-names:
+ items:
+ - const: qdsp6ss_base
+ - const: lpass_efuse
+
iommus:
items:
- description: Phandle to apps_smmu node with sid mask
@@ -57,7 +62,11 @@ properties:
power-domains:
items:
- - description: LCX power domain
+ - description: CX power domain
+
+ power-domain-names:
+ items:
+ - const: cx
resets:
items:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
2023-01-06 7:50 [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names Srinivasa Rao Mandadapu
@ 2023-01-08 15:36 ` Krzysztof Kozlowski
2023-01-10 6:27 ` Srinivasa Rao Mandadapu
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-08 15:36 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu, linux-remoteproc, agross, andersson,
lgirdwood, broonie, robh+dt, quic_plai, bgoswami, perex, tiwai,
srinivas.kandagatla, quic_rohkumar, linux-arm-msm, linux-kernel,
swboyd, judyhsiao, devicetree, mathieu.poirier, corbet
On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote:
> Add reg-names and power-domain-names for remoteproc ADSP pheripheral
> loader. This is to make compatible with remoteproc ADSP PIL driver.
I don't understand the reasoning. Before binding was "incompatible"?
> Also change power domain from LCX to CX.
Why? Hardware changed?
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Changes Since v1:
> -- Modify subject line to SoC specific.
>
> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> index 94ca7a0..b5bee2c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
> @@ -23,6 +23,11 @@ properties:
> - description: qdsp6ss register
> - description: efuse q6ss register
>
> + reg-names:
> + items:
> + - const: qdsp6ss_base
> + - const: lpass_efuse
> +
> iommus:
> items:
> - description: Phandle to apps_smmu node with sid mask
> @@ -57,7 +62,11 @@ properties:
>
> power-domains:
> items:
> - - description: LCX power domain
> + - description: CX power domain
> +
> + power-domain-names:
> + items:
> + - const: cx
>
> resets:
> items:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
2023-01-08 15:36 ` Krzysztof Kozlowski
@ 2023-01-10 6:27 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2023-01-10 6:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-remoteproc, agross, andersson,
lgirdwood, broonie, robh+dt, quic_plai, bgoswami, perex, tiwai,
srinivas.kandagatla, quic_rohkumar, linux-arm-msm, linux-kernel,
swboyd, judyhsiao, devicetree, mathieu.poirier, corbet
On 1/8/2023 9:06 PM, Krzysztof Kozlowski wrote:
Thanks for Your Time Krzyszto!!!
> On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote:
>> Add reg-names and power-domain-names for remoteproc ADSP pheripheral
>> loader. This is to make compatible with remoteproc ADSP PIL driver.
> I don't understand the reasoning. Before binding was "incompatible"?
Yes. Previous bindings needs fixes. Will add fixes tag for the same. So
far corresponding device tree not
mainlined and no user till now, hence these missing errors not found.
>
>> Also change power domain from LCX to CX.
> Why? Hardware changed?
No, basically it's a fix. The power domain name wrongly mentioned in
previous bindings.
The fixes tag mentioned above will be applicable here also.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> ---
>> Changes Since v1:
>> -- Modify subject line to SoC specific.
>>
>> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> index 94ca7a0..b5bee2c 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml
>> @@ -23,6 +23,11 @@ properties:
>> - description: qdsp6ss register
>> - description: efuse q6ss register
>>
>> + reg-names:
>> + items:
>> + - const: qdsp6ss_base
>> + - const: lpass_efuse
>> +
>> iommus:
>> items:
>> - description: Phandle to apps_smmu node with sid mask
>> @@ -57,7 +62,11 @@ properties:
>>
>> power-domains:
>> items:
>> - - description: LCX power domain
>> + - description: CX power domain
>> +
>> + power-domain-names:
>> + items:
>> + - const: cx
>>
>> resets:
>> items:
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-10 6:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-06 7:50 [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names Srinivasa Rao Mandadapu
2023-01-08 15:36 ` Krzysztof Kozlowski
2023-01-10 6:27 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).