From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: tfa9879: Convert to dtschema
Date: Fri, 22 Sep 2023 22:53:06 +0530 [thread overview]
Message-ID: <c6f795f1-2832-c282-5819-f8f402a312bd@gmail.com> (raw)
In-Reply-To: <20230922-unmindful-anyplace-f1da73ab168c@spud>
On 22/09/23 20:56, Conor Dooley wrote:
> On Fri, Sep 22, 2023 at 12:03:13AM +0530, Bragatheswaran Manickavel wrote:
>> Convert the tfa9879 audio CODEC bindings to DT schema
>> No error/warning seen when running make dt_binding_check
>>
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> Changes:
>> V1 -> V2: Fixed DT syntax errors and doc warning
> These should be under the --- line, not above it.
> Perhaps Mark will change it on application.
> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks,
> Conor.
Hi Conor,
Thanks for reviewing it.
Do I need to send a new patch by addressing the above comments ?
>
>> ---
>> .../bindings/sound/nxp,tfa9879.yaml | 44 +++++++++++++++++++
>> .../devicetree/bindings/sound/tfa9879.txt | 23 ----------
>> MAINTAINERS | 2 +-
>> 3 files changed, 45 insertions(+), 24 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml
>> delete mode 100644 Documentation/devicetree/bindings/sound/tfa9879.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml
>> new file mode 100644
>> index 000000000000..df26248573ad
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/nxp,tfa9879.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NXP TFA9879 class-D audio amplifier
>> +
>> +maintainers:
>> + - Peter Rosin <peda@axentia.se>
>> +
>> +allOf:
>> + - $ref: dai-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: nxp,tfa9879
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + "#sound-dai-cells":
>> + const: 0
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - '#sound-dai-cells'
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + i2c1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + amplifier@6c {
>> + compatible = "nxp,tfa9879";
>> + reg = <0x6c>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_i2c1>;
>> + #sound-dai-cells = <0>;
>> + };
>> + };
>> diff --git a/Documentation/devicetree/bindings/sound/tfa9879.txt b/Documentation/devicetree/bindings/sound/tfa9879.txt
>> deleted file mode 100644
>> index 1620e6848436..000000000000
>> --- a/Documentation/devicetree/bindings/sound/tfa9879.txt
>> +++ /dev/null
>> @@ -1,23 +0,0 @@
>> -NXP TFA9879 class-D audio amplifier
>> -
>> -Required properties:
>> -
>> -- compatible : "nxp,tfa9879"
>> -
>> -- reg : the I2C address of the device
>> -
>> -- #sound-dai-cells : must be 0.
>> -
>> -Example:
>> -
>> -&i2c1 {
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&pinctrl_i2c1>;
>> -
>> - amp: amp@6c {
>> - #sound-dai-cells = <0>;
>> - compatible = "nxp,tfa9879";
>> - reg = <0x6c>;
>> - };
>> -};
>> -
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a4c30221eb30..569303daf9b4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15476,7 +15476,7 @@ NXP TFA9879 DRIVER
>> M: Peter Rosin <peda@axentia.se>
>> L: alsa-devel@alsa-project.org (moderated for non-subscribers)
>> S: Maintained
>> -F: Documentation/devicetree/bindings/sound/tfa9879.txt
>> +F: Documentation/devicetree/bindings/sound/nxp,tfa9879.yaml
>> F: sound/soc/codecs/tfa9879*
>>
>> NXP-NCI NFC DRIVER
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2023-09-22 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:33 [PATCH v2] ASoC: dt-bindings: tfa9879: Convert to dtschema Bragatheswaran Manickavel
2023-09-22 15:26 ` Conor Dooley
2023-09-22 17:23 ` Bragatheswaran Manickavel [this message]
2023-09-22 18:21 ` Conor Dooley
2023-09-22 19:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f795f1-2832-c282-5819-f8f402a312bd@gmail.com \
--to=bragathemanick0908@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).