From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D797EC433F5 for ; Wed, 13 Apr 2022 10:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231749AbiDMKaZ (ORCPT ); Wed, 13 Apr 2022 06:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231583AbiDMKaX (ORCPT ); Wed, 13 Apr 2022 06:30:23 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB910483B4 for ; Wed, 13 Apr 2022 03:28:02 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id v15so1764116edb.12 for ; Wed, 13 Apr 2022 03:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=R3EQcXNwiHoGLibRNZM84Xx3HLPLT7OeOsdWHMolBU0=; b=XjBwrxbZnOFSYpEjeTAJSHsPIraWNt7Z8dFNiQaWOB+yk0a6RkQURtgBGEGR3R4k2N dZW8o/op1DQf9VHN5WCBB5DNfQR/q45etGnwKF7DsnCKkCmOT3SRlFYPKZZ/4ydV+pZ9 tItVyhmspl+n2Qdczec9WNxbfLjX2Tu6vlGTxN12p14vATW9xRC9GcCEsMgx5wAx/pdn dBOAbWxaR5Bc32H+i/Z7NqnhC/A5iZczQeAo9proLHjWrmNHupzQDUK9uodxJlArAJdf kAc+Wk2SrZ3S+NwUhy9AkMvlSPueCmXHk6FQZis9Vlaq1T7QtWRLD0tTANWAOZPRiG0+ 4VsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=R3EQcXNwiHoGLibRNZM84Xx3HLPLT7OeOsdWHMolBU0=; b=nqm1KPvIyC5+GugNF0JVh/ilE2AyP93aEG4yMd5zKlYhkj/J3emcSDw5+cpE6tq0a+ OcgWZtp+SPceEILrDKWAKVVmB4HOyLtdGE/KXqvs8GGjCWOm8nRIpStdU98P2WUPzXlL gXgH+S3s+lot/Os4GhK0zqL1aO3KjEgBJpKJnVGBVBwPBOrLEnHWS0N5nummcEBqbgtT kgOMc60ibFtn0zPfoBgzTbfrPhqrAmQpWsAya2ZjQAm6CAARVjI0vUxRLKdF/XhIy6L0 +80IPDNTGwm+ZeEaUblphNjK8gRt4wQGjKgIYJ+KaPdeiCJ/9iQlteMpCv90Sa8UloXF 19JA== X-Gm-Message-State: AOAM532QXv9tjR8U3HKzk4EmN1UqI6dPoeIA33EiPwksFV/TnOTxd6EG iMQO38tgKtX2ksWnqfr8cye4kw== X-Google-Smtp-Source: ABdhPJxPBKrnJ5zL7mJn2c/3VCB1NQBYCwUBGLxjcK4aAJIpKXzcg2mnhESD2bvp5MpHvuaGCtmKUw== X-Received: by 2002:a05:6402:42cb:b0:41e:ce5:f02c with SMTP id i11-20020a05640242cb00b0041e0ce5f02cmr3717675edc.74.1649845681551; Wed, 13 Apr 2022 03:28:01 -0700 (PDT) Received: from [192.168.0.203] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id t12-20020a1709067c0c00b006e86db76851sm5099383ejo.193.2022.04.13.03.28.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 03:28:01 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 12:28:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] arm64: dts: imx8mm-evk: add pwm1/backlight support Content-Language: en-US To: Tommaso Merciai Cc: linux-amarula@amarulasolutions.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Joakim Zhang , Tim Harvey , Richard Zhu , Li Jun , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220413102052.20207-1-tommaso.merciai@amarulasolutions.com> From: Krzysztof Kozlowski In-Reply-To: <20220413102052.20207-1-tommaso.merciai@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2022 12:20, Tommaso Merciai wrote: > Add pwm1/backlight support nodes for imx8mm_evk board. Align with u-boot > dts > > References: > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/ > > Signed-off-by: Tommaso Merciai > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > index 6d67df7692f1..55566708f667 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > enable-active-high; > }; > > + backlight: backlight { > + status = "disabled"; Why disabled? > + compatible = "pwm-backlight"; > + pwms = <&pwm1 0 5000000>; > + brightness-levels = <0 255>; > + num-interpolated-steps = <255>; > + default-brightness-level = <250>; > + }; > + > ir-receiver { > compatible = "gpio-ir-receiver"; > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > @@ -395,6 +404,12 @@ &wdog1 { > status = "okay"; > }; > > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; > + status = "disabled"; Same here. Best regards, Krzysztof