devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	'Sunyeal Hong' <sunyeal.hong@samsung.com>,
	'Sylwester Nawrocki' <s.nawrocki@samsung.com>,
	'Chanwoo Choi' <cw00.choi@samsung.com>,
	'Michael Turquette' <mturquette@baylibre.com>,
	'Stephen Boyd' <sboyd@kernel.org>,
	'Rob Herring' <robh@kernel.org>,
	'Conor Dooley' <conor+dt@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings
Date: Mon, 12 Aug 2024 08:31:28 +0200	[thread overview]
Message-ID: <c6ff2c78-df8a-446d-a87a-6e5349e43195@kernel.org> (raw)
In-Reply-To: <000a01daec0f$33ca4710$9b5ed530$@samsung.com>

On 11/08/2024 18:54, Alim Akhtar wrote:
> Hi Krzysztof
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Wednesday, July 31, 2024 2:57 PM
>> To: Sunyeal Hong <sunyeal.hong@samsung.com>; Sylwester Nawrocki
> [snip]
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - samsung,exynosautov920-cmu-top
>>> +      - samsung,exynosautov920-cmu-peric0
>>
>> Maybe I misinterpreted previous discussion, but I had impression that
>> binding was incomplete and you wanted to add more devices?
>>
> There are other CMU controller blocks likes any other Exynos SoC. 
> Are you suggesting to add all of them? 
> In the above case cmu_top provides clocks to cmu_peric0. 
> And I think the subject patch Intension is to add binding for this clock tree. 

I want the bindings to be complete, because previous review indicated
there are more devices.

Best regards,
Krzysztof


  reply	other threads:[~2024-08-12  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240730071227epcas2p3db10248818bb509aa069205bb9bb851b@epcas2p3.samsung.com>
2024-07-30  7:12 ` [PATCH v5 0/4] initial clock support for exynosauto v920 SoC Sunyeal Hong
     [not found]   ` <CGME20240730071227epcas2p278017961013950cd75c4266eda45c236@epcas2p2.samsung.com>
2024-07-30  7:12     ` [PATCH v5 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings Sunyeal Hong
2024-07-31  9:27       ` Krzysztof Kozlowski
2024-08-11 16:54         ` Alim Akhtar
2024-08-12  6:31           ` Krzysztof Kozlowski [this message]
     [not found]   ` <CGME20240730071227epcas2p1d1c0d9d1f40b045002ce0509f5168648@epcas2p1.samsung.com>
2024-07-30  7:12     ` [PATCH v5 2/4] arm64: dts: exynos: add initial CMU clock nodes in ExynosAuto v920 Sunyeal Hong
     [not found]   ` <CGME20240730071227epcas2p356635cf71f4d652be2bfa733c8b5848e@epcas2p3.samsung.com>
2024-07-30  7:12     ` [PATCH v5 3/4] clk: samsung: clk-pll: Add support for pll_531x Sunyeal Hong
     [not found]   ` <CGME20240730071228epcas2p1923fbb513190816d7bd9afaf0a4f5066@epcas2p1.samsung.com>
2024-07-30  7:12     ` [PATCH v5 4/4] clk: samsung: add top clock support for ExynosAuto v920 SoC Sunyeal Hong
2024-08-12  4:39       ` Kwanghoon Son

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6ff2c78-df8a-446d-a87a-6e5349e43195@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=sunyeal.hong@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).