[PATCH] ARM: dts: at91: sama7g5: Add NAND support

[PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Tudor Ambarus]

Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
a slightly change: it provides a synchronous clock output (SMC clock)
that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
NAND configuration, thus code will not be added in the current nand driver
to address the FPGA usage, use the sama5d2's compatible and choose not to
introduce dedicated compatibles for sama7g5.
Tested with Micron MT29F4G08ABAEAWP NAND flash.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
The patch depends on the following patch:
https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u

 arch/arm/boot/dts/sama7g5.dtsi | 55 ++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
index eddcfbf4d223..7972cb8c2562 100644
--- a/arch/arm/boot/dts/sama7g5.dtsi
+++ b/arch/arm/boot/dts/sama7g5.dtsi
@@ -75,6 +75,45 @@ soc {
 		#size-cells = <1>;
 		ranges;
 
+		nfc_sram: sram@600000 {
+			compatible = "mmio-sram";
+			no-memory-wc;
+			reg = <0x00600000 0x2400>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 0x00600000 0x2400>;
+		};
+
+		nfc_io: nfc-io@10000000 {
+			compatible = "atmel,sama5d3-nfc-io", "syscon";
+			reg = <0x10000000 0x8000000>;
+		};
+
+		ebi: ebi@40000000 {
+			compatible = "atmel,sama5d3-ebi";
+			#address-cells = <2>;
+			#size-cells = <1>;
+			atmel,smc = <&hsmc>;
+			reg = <0x40000000 0x20000000>;
+			ranges = <0x0 0x0 0x40000000 0x8000000
+				  0x1 0x0 0x48000000 0x8000000
+				  0x2 0x0 0x50000000 0x8000000
+				  0x3 0x0 0x58000000 0x8000000>;
+			clocks = <&pmc PMC_TYPE_CORE PMC_MCK1>;
+			status = "disabled";
+
+			nand_controller: nand-controller {
+				compatible = "atmel,sama5d3-nand-controller";
+				atmel,nfc-sram = <&nfc_sram>;
+				atmel,nfc-io = <&nfc_io>;
+				ecc-engine = <&pmecc>;
+				#address-cells = <2>;
+				#size-cells = <1>;
+				ranges;
+				status = "disabled";
+			};
+		};
+
 		securam: securam@e0000000 {
 			compatible = "microchip,sama7g5-securam", "atmel,sama5d2-securam", "mmio-sram";
 			reg = <0xe0000000 0x4000>;
@@ -181,6 +220,22 @@ tcb1: timer@e0800000 {
 			clock-names = "t0_clk", "t1_clk", "t2_clk", "slow_clk";
 		};
 
+		hsmc: hsmc@e0808000 {
+			compatible = "atmel,sama5d2-smc", "syscon", "simple-mfd";
+			reg = <0xe0808000 0x1000>;
+			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&pmc PMC_TYPE_PERIPHERAL 21>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+
+			pmecc: ecc-engine@e0808070 {
+				compatible = "atmel,sama5d2-pmecc";
+				reg = <0xe0808070 0x490>,
+				      <0xe0808500 0x200>;
+			};
+		};
+
 		qspi0: spi@e080c000 {
 			compatible = "microchip,sama7g5-ospi";
 			reg = <0xe080c000 0x400>, <0x20000000 0x10000000>;
-- 
2.25.1

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Nicolas Ferre]

On 11/01/2022 at 14:05, Tudor Ambarus wrote:
> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
> a slightly change: it provides a synchronous clock output (SMC clock)
> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
> NAND configuration, thus code will not be added in the current nand driver
> to address the FPGA usage, use the sama5d2's compatible and choose not to
> introduce dedicated compatibles for sama7g5.
> Tested with Micron MT29F4G08ABAEAWP NAND flash.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
> The patch depends on the following patch:
> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u

Patch seems taken, so I add this one to at91-dt branch for 5.18 merge 
window.

Best regards,
   Nicolas

> 
>   arch/arm/boot/dts/sama7g5.dtsi | 55 ++++++++++++++++++++++++++++++++++
>   1 file changed, 55 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index eddcfbf4d223..7972cb8c2562 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -75,6 +75,45 @@ soc {
>   		#size-cells = <1>;
>   		ranges;
>   
> +		nfc_sram: sram@600000 {
> +			compatible = "mmio-sram";
> +			no-memory-wc;
> +			reg = <0x00600000 0x2400>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 0x00600000 0x2400>;
> +		};
> +
> +		nfc_io: nfc-io@10000000 {
> +			compatible = "atmel,sama5d3-nfc-io", "syscon";
> +			reg = <0x10000000 0x8000000>;
> +		};
> +
> +		ebi: ebi@40000000 {
> +			compatible = "atmel,sama5d3-ebi";
> +			#address-cells = <2>;
> +			#size-cells = <1>;
> +			atmel,smc = <&hsmc>;
> +			reg = <0x40000000 0x20000000>;
> +			ranges = <0x0 0x0 0x40000000 0x8000000
> +				  0x1 0x0 0x48000000 0x8000000
> +				  0x2 0x0 0x50000000 0x8000000
> +				  0x3 0x0 0x58000000 0x8000000>;
> +			clocks = <&pmc PMC_TYPE_CORE PMC_MCK1>;
> +			status = "disabled";
> +
> +			nand_controller: nand-controller {
> +				compatible = "atmel,sama5d3-nand-controller";
> +				atmel,nfc-sram = <&nfc_sram>;
> +				atmel,nfc-io = <&nfc_io>;
> +				ecc-engine = <&pmecc>;
> +				#address-cells = <2>;
> +				#size-cells = <1>;
> +				ranges;
> +				status = "disabled";
> +			};
> +		};
> +
>   		securam: securam@e0000000 {
>   			compatible = "microchip,sama7g5-securam", "atmel,sama5d2-securam", "mmio-sram";
>   			reg = <0xe0000000 0x4000>;
> @@ -181,6 +220,22 @@ tcb1: timer@e0800000 {
>   			clock-names = "t0_clk", "t1_clk", "t2_clk", "slow_clk";
>   		};
>   
> +		hsmc: hsmc@e0808000 {
> +			compatible = "atmel,sama5d2-smc", "syscon", "simple-mfd";
> +			reg = <0xe0808000 0x1000>;
> +			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 21>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +
> +			pmecc: ecc-engine@e0808070 {
> +				compatible = "atmel,sama5d2-pmecc";
> +				reg = <0xe0808070 0x490>,
> +				      <0xe0808500 0x200>;
> +			};
> +		};
> +
>   		qspi0: spi@e080c000 {
>   			compatible = "microchip,sama7g5-ospi";
>   			reg = <0xe080c000 0x400>, <0x20000000 0x10000000>;


-- 
Nicolas Ferre

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Tudor.Ambarus]

On 2/24/22 17:04, Nicolas Ferre wrote:
> On 11/01/2022 at 14:05, Tudor Ambarus wrote:
>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
>> a slightly change: it provides a synchronous clock output (SMC clock)
>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
>> NAND configuration, thus code will not be added in the current nand driver
>> to address the FPGA usage, use the sama5d2's compatible and choose not to
>> introduce dedicated compatibles for sama7g5.
>> Tested with Micron MT29F4G08ABAEAWP NAND flash.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
>> ---
>> The patch depends on the following patch:
>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
> 
> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window.
> 

I think it depends on who gets to next first. If at91 gets before clk,
there will be a build error, isn't it?

Cheers,
ta

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Nicolas Ferre]

Hi Tudor,

On 24/02/2022 at 16:49, Tudor Ambarus - M18064 wrote:
> On 2/24/22 17:04, Nicolas Ferre wrote:
>> On 11/01/2022 at 14:05, Tudor Ambarus wrote:
>>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
>>> a slightly change: it provides a synchronous clock output (SMC clock)
>>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
>>> NAND configuration, thus code will not be added in the current nand driver
>>> to address the FPGA usage, use the sama5d2's compatible and choose not to
>>> introduce dedicated compatibles for sama7g5.
>>> Tested with Micron MT29F4G08ABAEAWP NAND flash.
>>>
>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>
>>> ---
>>> The patch depends on the following patch:
>>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
>>
>> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window.
>>
> 
> I think it depends on who gets to next first. If at91 gets before clk,
> there will be a build error, isn't it?

Clk patch is already in linux-next, so no worries.
Moreover, I don't get why there could be a build error as there is no 
build dependency between DT changes and C changes.
Sorry but I'm puzzled... Or I'm not looking at the right patch.

Regards,
   Nicolas



-- 
Nicolas Ferre

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Tudor.Ambarus]

On 2/24/22 19:44, Nicolas Ferre wrote:
> Hi Tudor,

Hi,

> 
> On 24/02/2022 at 16:49, Tudor Ambarus - M18064 wrote:
>> On 2/24/22 17:04, Nicolas Ferre wrote:
>>> On 11/01/2022 at 14:05, Tudor Ambarus wrote:
>>>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
>>>> a slightly change: it provides a synchronous clock output (SMC clock)
>>>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
>>>> NAND configuration, thus code will not be added in the current nand driver
>>>> to address the FPGA usage, use the sama5d2's compatible and choose not to
>>>> introduce dedicated compatibles for sama7g5.
>>>> Tested with Micron MT29F4G08ABAEAWP NAND flash.
>>>>
>>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>
>>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>>
>>>> ---
>>>> The patch depends on the following patch:
>>>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
>>>
>>> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window.
>>>
>>
>> I think it depends on who gets to next first. If at91 gets before clk,
>> there will be a build error, isn't it?
> 

Sorry, not linux-next, but whose PR gets first applied by Linus.

> Clk patch is already in linux-next, so no worries.
> Moreover, I don't get why there could be a build error as there is no build dependency between DT changes and C changes.
> Sorry but I'm puzzled... Or I'm not looking at the right patch.
> 

You would see this kind of error:
Error: arch/arm/boot/dts/sama7g5.dtsi:102.21-22 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:346: arch/arm/boot/dts/at91-sama7g5ek.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1385: dtbs] Error 2
make: *** Waiting for unfinished jobs....

This patch uses "PMC_MCK1" which is defined in:
https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u

If Linus applies the arm-soc PR before the clk PR, it will see the same error, no?

Cheers,
ta

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Nicolas Ferre]

On 24/02/2022 at 19:26, Tudor Ambarus - M18064 wrote:
> On 2/24/22 19:44, Nicolas Ferre wrote:
>> Hi Tudor,
> 
> Hi,
> 
>>
>> On 24/02/2022 at 16:49, Tudor Ambarus - M18064 wrote:
>>> On 2/24/22 17:04, Nicolas Ferre wrote:
>>>> On 11/01/2022 at 14:05, Tudor Ambarus wrote:
>>>>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
>>>>> a slightly change: it provides a synchronous clock output (SMC clock)
>>>>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
>>>>> NAND configuration, thus code will not be added in the current nand driver
>>>>> to address the FPGA usage, use the sama5d2's compatible and choose not to
>>>>> introduce dedicated compatibles for sama7g5.
>>>>> Tested with Micron MT29F4G08ABAEAWP NAND flash.
>>>>>
>>>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>>
>>>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>>>
>>>>> ---
>>>>> The patch depends on the following patch:
>>>>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
>>>>
>>>> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window.
>>>>
>>>
>>> I think it depends on who gets to next first. If at91 gets before clk,
>>> there will be a build error, isn't it?
>>
> 
> Sorry, not linux-next, but whose PR gets first applied by Linus.
> 
>> Clk patch is already in linux-next, so no worries.
>> Moreover, I don't get why there could be a build error as there is no build dependency between DT changes and C changes.
>> Sorry but I'm puzzled... Or I'm not looking at the right patch.
>>
> 
> You would see this kind of error:
> Error: arch/arm/boot/dts/sama7g5.dtsi:102.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:346: arch/arm/boot/dts/at91-sama7g5ek.dtb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1385: dtbs] Error 2
> make: *** Waiting for unfinished jobs....
> 
> This patch uses "PMC_MCK1" which is defined in:
> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
> 
> If Linus applies the arm-soc PR before the clk PR, it will see the same error, no?

Yes, absolutely.
So I need to have an immutable branch from Stephen then. I'm removing 
the patch from the at91-dt branch for now.

Thanks for the insight and sorry not having overlooked at that crucial 
piece of header file ;-)

Best regards,
   Nicolas

-- 
Nicolas Ferre

Re: [PATCH] ARM: dts: at91: sama7g5: Add NAND support

[Nicolas Ferre]

On 25/02/2022 at 11:28, Nicolas Ferre wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 24/02/2022 at 19:26, Tudor Ambarus - M18064 wrote:
>> On 2/24/22 19:44, Nicolas Ferre wrote:
>>> Hi Tudor,
>>
>> Hi,
>>
>>>
>>> On 24/02/2022 at 16:49, Tudor Ambarus - M18064 wrote:
>>>> On 2/24/22 17:04, Nicolas Ferre wrote:
>>>>> On 11/01/2022 at 14:05, Tudor Ambarus wrote:
>>>>>> Add NAND support. The sama7g5's SMC IP is the same as sama5d2's with
>>>>>> a slightly change: it provides a synchronous clock output (SMC clock)
>>>>>> that is dedicated to FPGA usage. Since this doesn't interfere with the SMC
>>>>>> NAND configuration, thus code will not be added in the current nand driver
>>>>>> to address the FPGA usage, use the sama5d2's compatible and choose not to
>>>>>> introduce dedicated compatibles for sama7g5.
>>>>>> Tested with Micron MT29F4G08ABAEAWP NAND flash.
>>>>>>
>>>>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>>>
>>>>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>>>>
>>>>>> ---
>>>>>> The patch depends on the following patch:
>>>>>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
>>>>>
>>>>> Patch seems taken, so I add this one to at91-dt branch for 5.18 merge window.
>>>>>
>>>>
>>>> I think it depends on who gets to next first. If at91 gets before clk,
>>>> there will be a build error, isn't it?
>>>
>>
>> Sorry, not linux-next, but whose PR gets first applied by Linus.
>>
>>> Clk patch is already in linux-next, so no worries.
>>> Moreover, I don't get why there could be a build error as there is no build dependency between DT changes and C changes.
>>> Sorry but I'm puzzled... Or I'm not looking at the right patch.
>>>
>>
>> You would see this kind of error:
>> Error: arch/arm/boot/dts/sama7g5.dtsi:102.21-22 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:346: arch/arm/boot/dts/at91-sama7g5ek.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1385: dtbs] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> This patch uses "PMC_MCK1" which is defined in:
>> https://lore.kernel.org/linux-clk/20220111125310.902856-1-tudor.ambarus@microchip.com/T/#u
>>
>> If Linus applies the arm-soc PR before the clk PR, it will see the same error, no?
> 
> Yes, absolutely.
> So I need to have an immutable branch from Stephen then. I'm removing
> the patch from the at91-dt branch for now.

I didn't hear from Setphen so I'm adding the missing piece in the patch 
and queue it in my next DT pull-request to arm-soc (target: 5.18).
I verified that there is no conflict when merging with linux-next which 
already contains this chunk.

Best regards,
   Nicolas

> Thanks for the insight and sorry not having overlooked at that crucial
> piece of header file ;-)
> 
> Best regards,
>     Nicolas
> 
> --
> Nicolas Ferre
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Nicolas Ferre