From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Adolfsson <johan.adolfsson@axis.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi
Date: Fri, 19 Apr 2024 01:04:48 +0200 [thread overview]
Message-ID: <c739a512-9a75-4f48-b5ef-801191c298f5@linaro.org> (raw)
In-Reply-To: <20240418-foo-fix-v1-2-461bcc8f5976@axis.com>
On 18/04/2024 16:01, Johan Adolfsson wrote:
> panel-dsi is similar to panel-dpi with overridable timings
???
>
> Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>
> ---
> Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index f9160d7bac3c..4c9dd4f66a8f 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -56,6 +56,8 @@ properties:
> - samsung,sofef00
> # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
> - tdo,tl070wsh30
> + # Generic dsi panel with timing overridable
> + - panel-dsi
? Devices are not generic. This is very confusing and commit msg does
not help me. Compatibles *must* be specific, see writing-bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-18 23:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:01 [PATCH 0/2] Add generic panel-dsi to panel-simple Johan Adolfsson
2024-04-18 14:01 ` [PATCH 1/2] drm/panel: panel-simple: Add generic panel-dsi driver Johan Adolfsson
2024-04-18 23:06 ` Krzysztof Kozlowski
2024-04-22 14:05 ` Johan Adolfsson
2024-04-22 19:43 ` Dmitry Baryshkov
2024-04-18 14:01 ` [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi Johan Adolfsson
2024-04-18 23:04 ` Krzysztof Kozlowski [this message]
2024-04-22 14:34 ` Johan Adolfsson
2024-04-22 20:56 ` Krzysztof Kozlowski
2024-05-13 9:34 ` Johan Adolfsson
2024-05-13 9:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c739a512-9a75-4f48-b5ef-801191c298f5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=johan.adolfsson@axis.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).