From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Andreas Schwab <schwab@suse.de>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] clocksource: Add StarFive timer driver
Date: Tue, 7 Mar 2023 11:47:45 +0800 [thread overview]
Message-ID: <c745392f-6d8a-8e00-803b-dd61a0a008a0@starfivetech.com> (raw)
In-Reply-To: <mvmzg8vlcfk.fsf@suse.de>
On 2023/3/2 17:39, Andreas Schwab wrote:
> drivers/clocksource/timer-starfive.c:117:13: error: conflicting types for 'timer_shutdown'; have 'void(struct starfive_clkevt *)'
> 117 | static void timer_shutdown(struct starfive_clkevt *clkevt)
> | ^~~~~~~~~~~~~~
> In file included from ./include/linux/workqueue.h:9,
> from ./include/linux/srcu.h:21,
> from ./include/linux/notifier.h:16,
> from ./include/linux/clk.h:14,
> from drivers/clocksource/timer-starfive.c:12:
> ./include/linux/timer.h:188:12: note: previous declaration of 'timer_shutdown' with type 'int(struct timer_list *)'
> 188 | extern int timer_shutdown(struct timer_list *timer);
> | ^~~~~~~~~~~~~~
>
Oh, this timer_shutdown(struct timer_list *timer) function was not available
in 6.1-rc5 which this patchset was base on. And in the new version, it's the
same name as my own function. I will change the name of this function.
Best regards,
Xingyu Wu
next prev parent reply other threads:[~2023-03-07 3:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 9:47 [PATCH v1 0/3] Add timer driver for StarFive JH7110 RISC-V SoC Xingyu Wu
2022-12-23 9:47 ` [PATCH v1 1/3] dt-bindings: timer: Add timer for StarFive JH7110 SoC Xingyu Wu
2022-12-23 10:25 ` Krzysztof Kozlowski
2023-01-10 2:14 ` Xingyu Wu
2023-01-10 8:24 ` Krzysztof Kozlowski
2022-12-23 9:48 ` [PATCH v1 2/3] clocksource: Add StarFive timer driver Xingyu Wu
2023-01-17 6:39 ` Xingyu Wu
2023-03-02 9:39 ` Andreas Schwab
2023-03-07 3:47 ` Xingyu Wu [this message]
2022-12-23 9:48 ` [PATCH v1 3/3] riscv: dts: jh7110: starfive: Add timer node Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c745392f-6d8a-8e00-803b-dd61a0a008a0@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=schwab@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).