From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFEB26AEA; Sun, 31 Mar 2024 23:06:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711926381; cv=none; b=dWrqfaA3rxXTQCo7QZfOFQltNNatHVcrmT6JT+da9fn3vp7WirgzOu38qLE8bWqPZU9Zn3opghPzFtlTZKh+IypsFr9OIHjbeLt1Yu8QtQragn6J11KwIFMEuTFRskYRcnBqyrEnCfaVaj5XRP8Y/fi8uPDNLX17RhxPki6knsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711926381; c=relaxed/simple; bh=14qIqX8MDo3yXNFpqBzy/00s9TGjAWt6G7ERHC7x30A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LEkZQOIZvVYdz9iqlRPM3VGgfye3jvHfwBgzsdFOGg/PyJRR/e/bLAgHw4O4aPttCazfRkhwUJ2YE06aqbB5v2+Rl0Ijpvvm68lpuGIzyBKTXi4jA3ImIalEBN449a6QAblw+KJhRFmCUZ5IyPxi9De09bTWwQHMDiptzo9rERw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gw6sdMmc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gw6sdMmc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC358C433F1; Sun, 31 Mar 2024 23:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711926381; bh=14qIqX8MDo3yXNFpqBzy/00s9TGjAWt6G7ERHC7x30A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gw6sdMmccfg6fv2rsBdDfRpSG7EMGTTmkv9GV0mfGfq78EG0Qa3zFW+rJUZzSqm/1 9rw6aVYZcX3zsaWf+T8zHt+KIJdjHHYF+3GyTxnvmPCDqh8zutCL1T5XgVQX8sf8Ub XCLjmRv0WFLzmR5UfSYpKO6zco0y/AHJCjO71mC+f9PpTO5gqM/B2OmeCNYooRVxo9 2mKSG0zoKqfErDvmrGPb305oT3IpOq+xTMdWPERY6pzWuFMWaE5sXg9Bo7xIRiphe7 ddcRd9uXmkpF6sUoIMIgiNFlwRzX4TbqA6IWQNgGTC8Bl/Jgmi+8lfUjtYJAAmr2Et fItqbas/oQN0g== Message-ID: Date: Mon, 1 Apr 2024 08:06:17 +0900 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 17/18] dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property To: Krzysztof Kozlowski , Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-18-dlemoal@kernel.org> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/24 18:16, Krzysztof Kozlowski wrote: > On 30/03/2024 05:19, Damien Le Moal wrote: >> From: Wilfred Mallawa >> >> Describe the `ep-gpios` property which is used to map the PERST# input >> signal for endpoint mode. >> >> Signed-off-by: Wilfred Mallawa >> Signed-off-by: Damien Le Moal >> --- >> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> index 6b62f6f58efe..9331d44d6963 100644 >> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >> @@ -30,6 +30,9 @@ properties: >> maximum: 32 >> default: 32 >> >> + ep-gpios: >> + description: Input GPIO configured for the PERST# signal. > > Missing maxItems. But more important: why existing property perst-gpios, > which you already have there in common schema, is not correct for this case? I am confused... Where do you find perst-gpios defined for the rk3399 ? Under Documentation/devicetree/bindings/pci/, the only schema I see using perst-gpios property are for the qcom (Qualcomm) controllers. The RC bindings for the rockchip rk3399 PCIe controller (pci/rockchip,rk3399-pcie.yaml) already define the ep-gpios property. So if anything, this patch should be probably be modified to move this property to the common schema in pci/rockchip,rk3399-pcie-common.yaml. No ? > > Best regards, > Krzysztof > -- Damien Le Moal Western Digital Research