From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C605BC433EF for ; Wed, 29 Jun 2022 09:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbiF2J6Y (ORCPT ); Wed, 29 Jun 2022 05:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbiF2J6X (ORCPT ); Wed, 29 Jun 2022 05:58:23 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFB9113A for ; Wed, 29 Jun 2022 02:58:22 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id k20so29496edj.13 for ; Wed, 29 Jun 2022 02:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Q0hXybwVYyJJtShG3s2e1VSFC83nd6szT4kAIob75Sw=; b=LKpu2yHFiRvrEnZapYQSuYenvUNEBYE3I1cR5EA3rgm9hglZyMvJ2I+iHMm/PhP0Jn NF8t4zrVn1tBf8/mkBD7WOjeHSM1LrfnkU4BiRuem1bpFhUFi744B39AWsK3ybNGMW5o QO+sCKPxdOZB3VpSRGEzVDAHW3v6OIfWz37Q/eHzpzP6upnr/DT1yvKGkeWB8Q3s10Um IKUNcZw9x40xqPKU5mRRJ80+pDuRmcRnIaUJfjdHUDZV3VuVts19cR0fBlvduoWTmWAD 6G8VwYYWnRf7gzgpDWPHcu86rkhGicnTXJYWL+/Mu1of3JzOsFQVWkNF7RlePzYY/Y2c 9tJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q0hXybwVYyJJtShG3s2e1VSFC83nd6szT4kAIob75Sw=; b=RbL6IhJF3vDKAU0fhsry45sHuqOr7vv2bZiSbjcAeDmy2wborOwkQFchOQ61P/9d/C kUccBhBDKcxrRmUiviX0FgJTyk/Sno2nIIEpUzjQkje166Ff/ARkU5aKRSXB+3O/Ojb0 OJVERC9bQQjUd2Lo/lI2/KFiN6Pg92v+q4BBcF3MlMsA+QobR2rCo+IJ9b8UEcwpt/uq 6GDrDWVMgINk9VA7XnBqdHchXLIJvS857tXH1APoKTNnAWjLxT0G5gMiYXTVWOJw91To R58nusxL/XAL8i8WVrCqIEkOinHnaz/h4P0cAXzBAtfoJMKz6UKyo9RdNMVSP554GUsL 32HQ== X-Gm-Message-State: AJIora+qWxwizlv+RBJFlYzpxTZuuHAgFTC3fjK0htowEz5PlxTKBS9J v/FvQiI/tA5mOawJetKT+Og/Gogjyx+Nnw== X-Google-Smtp-Source: AGRyM1vuENth8+BVV6epDv21UB66lX7OsmfGpsefU+XZem8sycJawvinAvmNj+V+ISVAa2nGTddMkw== X-Received: by 2002:aa7:c38d:0:b0:435:9257:99a5 with SMTP id k13-20020aa7c38d000000b00435925799a5mr3063222edq.204.1656496700585; Wed, 29 Jun 2022 02:58:20 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s22-20020a170906a19600b0071cef8bafc3sm7570775ejy.1.2022.06.29.02.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 02:58:20 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 11:58:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 02/12] powerpc: wiiu: device tree Content-Language: en-US To: Ash Logan , krzysztof.kozlowski+dt@linaro.org, paulus@samba.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, robh+dt@kernel.org, benh@kernel.crashing.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, j.ne@posteo.net, linkmauve@linkmauve.fr, rw-r-r-0644@protonmail.com, devicetree@vger.kernel.org, joel@jms.id.au References: <20220622131037.57604-1-ash@heyquark.com> <20220628133144.142185-1-ash@heyquark.com> <20220628133144.142185-3-ash@heyquark.com> From: Krzysztof Kozlowski In-Reply-To: <20220628133144.142185-3-ash@heyquark.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/06/2022 15:31, Ash Logan wrote: > Add a device tree source file for the Nintendo Wii U video game console. > > Signed-off-by: Ash Logan > Co-developed-by: Roberto Van Eeden > Signed-off-by: Roberto Van Eeden > Co-developed-by: Emmanuel Gil Peyrot > Signed-off-by: Emmanuel Gil Peyrot > --- > v1->v2: Style and formatting changes suggested by Rob Herring. > License remains GPL-2.0 as the other powerpc dtses are the same, happy > to change if there is a different preferred default. > v2->v3: Re-added address-cells accidentally removed in v2. > Marked latte as a simple-bus, since it is. Thank you for your patch. There is something to discuss/improve. > > arch/powerpc/boot/dts/wiiu.dts | 326 +++++++++++++++++++++++++++++++++ > 1 file changed, 326 insertions(+) > create mode 100644 arch/powerpc/boot/dts/wiiu.dts > > diff --git a/arch/powerpc/boot/dts/wiiu.dts b/arch/powerpc/boot/dts/wiiu.dts > new file mode 100644 > index 000000000000..44a5a1469095 > --- /dev/null > +++ b/arch/powerpc/boot/dts/wiiu.dts > @@ -0,0 +1,326 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Nintendo Wii U Device Tree Source > + * > + * Copyright (C) 2022 The linux-wiiu Team > + */ > + > +/dts-v1/; > +#include > +#include > + > +/ { > + model = "nintendo,wiiu"; It's not compatible, but user-visible string, e.g. "Nintendo Wii U" > + compatible = "nintendo,wiiu"; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + chosen { > + bootargs = "root=/dev/sda1 rootwait"; This does not belong to shared DTS. No bootargs. > + }; > + > + memory { > + device_type = "memory"; > + reg = <0x00000000 0x02000000 /* MEM1 - 32MiB */ > + 0x08000000 0x00300000 /* MEM0 - 3MiB */ > + 0x10000000 0x80000000>; /* MEM2 - 2GiB */ > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* TODO: Add SMP */ > + PowerPC,espresso@0 { Node name should be generic, so "cpu". Unless something needs the specific node name? > + device_type = "cpu"; > + reg = <0>; > + clock-frequency = <1243125000>; /* 1.243125GHz */ > + bus-frequency = <248625000>; /* 248.625MHz core-to-bus 5x */ > + timebase-frequency = <62156250>; /* 1/4 of the bus clock */ > + i-cache-size = <32768>; /* 32K icache */ > + i-cache-line-size = <32>; > + i-cache-block-size = <32>; > + i-cache-sets = <128>; > + d-cache-size = <32768>; /* 32K dcache */ > + d-cache-line-size = <32>; > + d-cache-block-size = <32>; > + d-cache-sets = <128>; > + next-level-cache = <&L2_0>; > + L2_0:l2-cache { > + compatible = "cache"; > + cache-level = <2>; > + cache-unified; > + cache-size = <0x80000>; /* 512KB L2 */ > + cache-line-size = <64>; > + cache-block-size = <32>; > + cache-sets = <2048>; > + }; > + }; > + }; > + > + latte { Generic node names. > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "nintendo,latte", "simple-bus"; > + ranges = <0x0c000000 0x0c000000 0x00400000 /* Espresso-only registers */ > + 0x0d000000 0x0d000000 0x00200000 /* Latte AHB deivces */ > + 0x0d800000 0x0d800000 0x00800000>; /* Latte SoC registers */ > + > + latte_gpu: gpu@c200000 { > + compatible = "nintendo,latte-gpu7"; > + reg = <0x0c200000 0x80000>; > + interrupts = <2>; > + interrupt-parent = <&espresso_pic>; > + }; > + > + espresso_pic: pic@c000078 { interrupt-controller > + #interrupt-cells = <1>; > + interrupt-controller; > + > + compatible = "nintendo,espresso-pic"; > + reg = <0x0c000078 0x18>; > + }; > + > + latte_dsp: dsp@c005000 { > + compatible = "nintendo,latte-dsp"; > + reg = <0x0c005000 0x200>; > + }; > + > + ehci_0: usb@d040000 { > + compatible = "nintendo,latte-usb-ehci", "usb-ehci"; > + reg = <0x0d040000 0x100>; > + interrupts = <4>; > + interrupt-parent = <&latte_pic>; > + big-endian-regs; > + }; > + > + ohci_0_0: usb@d050000 { > + compatible = "nintendo,latte-usb-ohci"; > + reg = <0x0d050000 0x100>; > + interrupts = <5>; > + interrupt-parent = <&latte_pic>; > + > + big-endian-regs; > + }; > + > + ohci_0_1: usb@d060000 { > + compatible = "nintendo,latte-usb-ohci"; > + reg = <0x0d060000 0x100>; > + interrupts = <6>; > + interrupt-parent = <&latte_pic>; > + > + big-endian-regs; > + }; > + > + ehci_1: usb@d120000 { > + compatible = "nintendo,latte-usb-ehci", "usb-ehci"; > + reg = <0x0d120000 0x100>; > + interrupts = <16>; > + interrupt-parent = <&latte_pic>; > + big-endian-regs; > + }; > + > + ohci_1_0: usb@d130000 { > + compatible = "nintendo,latte-usb-ohci"; > + reg = <0x0d130000 0x100>; > + interrupts = <35>; > + interrupt-parent = <&latte_pic>; > + > + big-endian-regs; > + }; > + > + ehci_2: usb@d140000 { > + compatible = "nintendo,latte-usb-ehci", "usb-ehci"; > + reg = <0x0d140000 0x100>; > + interrupts = <36>; > + interrupt-parent = <&latte_pic>; > + big-endian-regs; > + }; > + > + ohci_2_0: usb@d150000 { > + compatible = "nintendo,latte-usb-ohci"; > + reg = <0x0d150000 0x100>; > + interrupts = <37>; > + interrupt-parent = <&latte_pic>; > + > + big-endian-regs; > + }; > + > + sdcard_0: sdhci@d070000 { mmc > + compatible = "nintendo,latte-sdhci","sdhci"; > + reg = <0x0d070000 0x200>; > + interrupts = <7>; > + interrupt-parent = <&latte_pic>; > + }; > + > + wifi_0: sdhci@d080000 { mmc > + compatible = "nintendo,latte-sdhci","sdhci"; > + reg = <0x0d080000 0x200>; > + interrupts = <8>; > + interrupt-parent = <&latte_pic>; > + }; > + > + legacy_ipc: ipc@d800000 { > + compatible = "nintendo,latte-ipc", "nintendo,hollywood-ipc"; > + reg = <0x0d800000 0x10>; > + interrupts = <30 31>; > + interrupt-parent = <&latte_pic>; > + }; > + > + latte_otp: otp@d8001ec { > + compatible = "nintendo,latte-otp"; > + reg = <0x0d8001ec 0x8>; > + }; > + > + sata: ahci@d160400 { > + compatible = "nintendo,latte-ahci"; > + reg = <0x0d160400 0x808>; > + > + interrupt-parent = <&latte_pic>; > + interrupts = <38 28>; > + }; > + > + latte_pic: pic@d800440 { interrupt-controller > + #interrupt-cells = <1>; > + interrupt-controller; > + > + compatible = "nintendo,latte-pic"; > + reg = <0x0d800440 0x30>; > + interrupt-parent = <&espresso_pic>; > + interrupts = <24>; > + }; > + > + gpio: gpio@d8000c0 { > + #gpio-cells = <2>; > + compatible = "nintendo,latte-gpio", "nintendo,hollywood-gpio"; > + > + reg = <0x0d8000c0 0x40>; > + gpio-controller; > + /* TODO: There are actually 31 AHBALL GPIOs */ > + ngpios = <24>; > + > + gpio-line-names = > + "POWER", "DWIFI", "FAN", "DC_DC", > + "", "Esp10WorkAround", "", "", > + "PADPD", "", "EEP_CS", "EEP_CLK", > + "EEP_MOSI", "EEP_MISO", "AVE_SCL", "AVE_SDA", > + "DEBUG0", "DEBUG1", "DEBUG2", "DEBUG3", > + "DEBUG4", "DEBUG5", "DEBUG6", "DEBUG7"; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <10>; > + interrupt-parent = <&latte_pic>; > + }; > + > + gpio2: gpio@d800520 { > + #gpio-cells = <2>; > + compatible = "nintendo,latte-gpio", "nintendo,hollywood-gpio"; > + > + reg = <0x0d800520 0x40>; > + gpio-controller; > + ngpios = <7>; > + > + gpio-line-names = > + "FANSPEED", "SMC_SCL", "SMC_SDA", "DC_DC2", > + "AVE_INT", "", "AVE_RESET"; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <10>; > + interrupt-parent = <&latte_pic>; > + }; > + }; > + > + spi_gpio: spi-gpio { > + compatible = "spi-gpio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + cs-gpios = <&gpio 10 GPIO_ACTIVE_HIGH>; > + gpio-sck = <&gpio 11 GPIO_ACTIVE_HIGH>; > + gpio-mosi = <&gpio 12 GPIO_ACTIVE_HIGH>; > + gpio-miso = <&gpio 13 GPIO_ACTIVE_HIGH>; > + num-chipselects = <1>; > + > + eeprom@0 { > + compatible = "atmel,at93c66"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cs-high; > + /* TODO: wiiubrew says this is 16-bit, but I only get the correct > + * values in 8-bit... > + */ > + data-size = <8>; > + read-only; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + /* https://wiiubrew.org/wiki/Hardware/SEEPROM */ > + rng_seed: rng@12 { reg = <0x012 8>; }; > + ppc_pvr: pvr@20 { reg = <0x020 4>; }; > + seeprom_ver_str: sver-str@24 { reg = <0x024 6>; }; > + seeprom_ver: sver@2a { reg = <0x02A 2>; }; > + otp_ver: over@2c { reg = <0x02C 2>; }; > + otp_rev: orev@2e { reg = <0x02E 2>; }; > + otp_ver_str: over-str@30 { reg = <0x030 8>; }; > + > + bc_crc: bc-crc@38 { reg = <0x038 4>; }; > + bc_sz: bc-sz@3c { reg = <0x03C 2>; }; > + bc_ver: bc-ver@3e { reg = <0x03E 2>; }; > + bc_boardtype: boardtype@42 { reg = <0x042 2>; }; > + bc_boardrev: boardrev@44 { reg = <0x044 2>; }; > + bc_bootsource: bootsource@46 { reg = <0x046 2>; }; > + bc_ddr3size: ddr3size@48 { reg = <0x048 2>; }; > + bc_ddr3speed: ddr3speed@4a { reg = <0x04A 2>; }; > + bc_ppcclockmul: ppcclockmul@4c { reg = <0x04C 2>; }; > + bc_iopclockmul: iopclockmul@46 { reg = <0x04E 2>; }; > + bc_video1080p: video1080p@50 { reg = <0x050 2>; }; > + bc_ddr3vendor: ddr3vendor@52 { reg = <0x052 2>; }; > + bc_movpassivereset: movpassivereset@54 { reg = <0x054 2>; }; > + bc_syspllspd: syspllspd@56 { reg = <0x056 2>; }; > + bc_satadevice: satadevice@58 { reg = <0x058 2>; }; > + bc_consoletype: consoletype@5a { reg = <0x05A 2>; }; > + bc_deviceprescence: deviceprescence@5c { reg = <0x05C 2>; }; > + > + drive_key: drvkey@80 { reg = <0x080 16>; }; > + factory_key: fackey@90 { reg = <0x090 16>; }; > + shdd_key: shddkey@a0 { reg = <0x0A0 16>; }; > + usb_key_seed: usbkeyseed@b0 { reg = <0x0B0 16>; }; > + drive_key_flag: drvkeyf@c0 { reg = <0x0C0 2>; }; > + usb_key_flag: udbkeyf@c2 { reg = <0x0C2 2>; }; > + shdd_key_flag: shddkeyf@c4 { reg = <0x0C4 2>; }; > + > + sysprod_version: sp_ver@140 { reg = <0x140 4>; }; > + sysprod_eeprom_version: sp_ee_ver@144 { reg = <0x144 4>; }; > + sysprod_product_area: sp_parea@148 { reg = <0x148 4>; }; > + sysprod_game_region: sp_region@14c { reg = <0x14C 4>; }; > + sysprod_ntsc_pal: sp_ntscpal@150 { reg = <0x150 4>; }; > + sysprod_5ghz_country: sp_5ghz_c@154 { reg = <0x154 2>; }; > + sysprod_5ghz_country_rev: sp_5ghz_crev@156 { reg = <0x156 2>; }; > + sysprod_code: sp_code@158 { reg = <0x158 8>; }; > + sysprod_serial: sp_serial@160 { reg = <0x160 16>; }; > + sysprod_model: sp_model@170 { reg = <0x170 16>; }; > + > + prod_year: pyear@188 { reg = <0x188 2>; }; > + prod_date: pdate@18a { reg = <0x18A 2>; }; > + prod_time: ptime@18c { reg = <0x18C 2>; }; > + > + boot_params: boot_params@1c0 { reg = <0x1C0 48>; }; > + }; > + }; > + > + /* TODO make this gpio-keyed once hollywood-gpio supports interrupts */ > + gpio-keys-polled { gpio-keys > + poll-interval = <50>; > + compatible = "gpio-keys-polled"; > + > + power { key-power (will be enforced by schema) > + label = "Power Button"; > + gpios = <&gpio 0 GPIO_ACTIVE_HIGH>; > + linux,code = ; > + }; > + }; > +}; Best regards, Krzysztof