From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69649310628 for ; Wed, 10 Sep 2025 08:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757493770; cv=none; b=cFn3DhOMOSX2n01h4bgBZNE2XQURF3qd6omNdHWxBSm5XSvpi6V72yyyyO/kM1Vr2GmfDHm6y0shZOscXPhyD1Tij1BR3ZLyg3S1TznNmAum+Mt84KmkbPtxTrzJij/nybtYVgulNNEbvYnvYhjMIF8MJd9uwZNReyYnPmpdfvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757493770; c=relaxed/simple; bh=sI6ml4hTh+NeJSK15fW+krN1+UqokRd841kdomv2beQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=en1GY4Yj1lL6PzAp7XnXhuUh51vI5STtvY4LUwpWpFNseDpGjhPbrEq7sIt8M6AJ/RKlFFgQbyCsnlC6AYkzqNnV7NdT7z5FE6fYj7OAwtp0UEdPtCzDJHAN3LYmgIFzNJ7HIt4cmz/AQlbatpEWIZbi+k+2j8dZstpBuwr1d4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bx1M4qmF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bx1M4qmF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45df656889cso6290235e9.1 for ; Wed, 10 Sep 2025 01:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757493766; x=1758098566; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lquJ5PztwzuglOeRIwX9xUr/VMazVnds3G/8YT7Fvc4=; b=Bx1M4qmFf/fvaj3xSI0o53J5qtElAsxAMW1njKe6tJotp2Wb/bA4qKFPyEtv7gXFdj 8N4jddmgJAxc9vNGVLYGK1UefzsF45pDTMRResB/tREqius0PgCZX40EZqfdXzvPc5uA l0f/6i4hCZqC7Xfqe4u2yQ4UEPurbbJYkDxtF96QC7e361+U+DurXtgYBBwg7E0mK9WO At9ECdgJOu2PLhWbvjhGxomW/tRoSr/5CvK5HOz45T54WwhH1utv8jA/Ygn9PjfgHkQj I5QQeLK1xYSZKCM9ECgV8CyJFI+79OTFB0FetDgbvylR1agpfuMZf0S23ra73H6uI/gF KdWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757493766; x=1758098566; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lquJ5PztwzuglOeRIwX9xUr/VMazVnds3G/8YT7Fvc4=; b=uiHMWxjS+IBqTHvvq8qQhMd/LWfmxf8v7gRY51tymEB77fml5LCC2JZIriq+PlMpQL SuV65+5kPYofYDprE2xmQKUL3R+2VxKIkFKEZCz2aIwPBRY5hAnLWTK/Jc9dnH57mwuw swhkIIWGSAUV6dqeEKOPzX5EpG2L0gpqThchlwoR4B0ZrOqzP3scv3P4rkIIQJP0RCRs S/GnSRi+t6Ko0cu6spn+POja37QA84zv+p80Rc9+dnnYRSTWyhHqDzkxAurIOcSNuAYQ rJvFnZwvb5Z6GTn4l5kyzFxG1+O+ff9foBlpNlgtz2rpxXuCwlx7e8vc4qSvzdG2nmYy FHkg== X-Forwarded-Encrypted: i=1; AJvYcCW9XkK124JWrRjydSovbjNc0s8YNCHoNvuKzyh1A3ACZDbLhM3mSQd/QcQWxcbkjhAuk0txOmViBEsx@vger.kernel.org X-Gm-Message-State: AOJu0YwdsjaQv4w4wQR6EC5lmlOIUUQkYbnu3/0CdXIZ+GyMp42yQj3J P/DPs4UxPx4kO5l6ruhfsHNXVLxcbJVVBfm8Wi0SJ246X+99SLLpqwNjVs2XIN5cgz4= X-Gm-Gg: ASbGncvpiMf+mqJ5t14ClTPVb8BulCuADJDfd6JukIIHE7KrF/5AUkEmojqq9sxf/Yi todpQb9Y16zO4FJ+D1PklzzRcCmYbzkx6hbBiBjBs5A+lI0Bv64GXhtS+VA4b8nKyjRtB+EijVz l92DiDDBaitthW+3WfDcV/6/a/yDaXBs48vtIrAg1fqUNgdfBsw55FhBfJrvqgiwA85maDaboo2 VQT4wEH/ONNv0mhtgMDWQjcimN9I072ACpDPdQKPn0T+2cabvWgdHQcsnjZhc7KjhntgLQW1cwY sd7JnckruJN2mF25PSa5itUEBmZgjyaUb2QvW7h5PoF8SNNcmEaJUuUal22YOTIHwyhiL/RdFxH aVvBnVHh/e2LBjtm5p63MI6eA/UnY1PtKtQvMLXKhkJHbq9iY87ClwCYzW9MI6ckE8yY++uWjF1 KiZml0rlQhcBZqNei+QiA= X-Google-Smtp-Source: AGHT+IHVjNthO4SktB1Xz75HnDS8/BmjdCNmc8dzepzAh2MGw5GBwzE8aoUhNAen8jMgrcMcoay5OA== X-Received: by 2002:a05:600c:474e:b0:456:1b6f:c888 with SMTP id 5b1f17b1804b1-45dddecd894mr125340515e9.23.1757493765680; Wed, 10 Sep 2025 01:42:45 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45df8247acbsm19112915e9.13.2025.09.10.01.42.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 01:42:45 -0700 (PDT) Message-ID: Date: Wed, 10 Sep 2025 09:42:44 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] media: dt-bindings: Add qcom,qcs8300-camss compatible To: Krzysztof Kozlowski , Vikram Sharma , Krzysztof Kozlowski , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250813053724.232494-1-quic_vikramsa@quicinc.com> <20250813053724.232494-2-quic_vikramsa@quicinc.com> <8c1163ad-6e65-450b-ae44-c9a71a045333@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <8c1163ad-6e65-450b-ae44-c9a71a045333@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/09/2025 08:42, Krzysztof Kozlowski wrote: > On 10/09/2025 09:26, Vikram Sharma wrote: >> >> On 9/10/2025 12:35 PM, Krzysztof Kozlowski wrote: >>> On 13/08/2025 07:37, Vikram Sharma wrote: >>>> Add the compatible string "qcom,qcs8300-camss" to support the >>>> Camera Subsystem (CAMSS) on the Qualcomm QCS8300 platform. >>>> >>>> The QCS8300 platform provides: >>>> - 2 x VFE (version 690), each with 3 RDI >>>> - 5 x VFE Lite (version 690), each with 6 RDI >>>> - 2 x CSID (version 690) >>>> - 5 x CSID Lite (version 690) >>>> - 3 x CSIPHY (version 690) >>>> - 3 x TPG >>>> >>>> Signed-off-by: Vikram Sharma >>>> Reviewed-by: Krzysztof Kozlowski >>>> --- >>>> .../bindings/media/qcom,qcs8300-camss.yaml | 336 ++++++++++++++++++ >>>> 1 file changed, 336 insertions(+) >>> So it turns out this code is wrong and you already sent fixes for it. >> >> Hi Krzysztof, >> Thanks for your comments. These bindings are tested with TPG (Test Pattern Generator), As camera sensor testing was not possible at that point. > > You cannot test bindings with TPG. It's impossible. > >> This is because Monaco-evk kit was not ready which can be used to enable sensor. >> >> These Bindings are complete in its own, If someone want to use TPG. > > No. You do not understand - they are not complete if you add new > properties to them! > > How bindings could be complete if you add now supplies!?!? > >> >> My latest update in these bindings are for camera sensor enablement which needs supplies too. >> >> Please let me know if this justification works to accept these bindings it its current form and add supplies as a separate patch. > > NAK. Read writing bindings doc. Or internal docs. > > Best regards, > Krzysztof @Vikram Could you send an updated dt-bindings with the supplies included ASAP as a v4 of this series ? The -supplies in your email here look fine 20250909114241.840842-5-quic_vikramsa@quicinc.com Otherwise we will have to drop this binding and the associated driver changes. --- bod