From: Xukai Wang <kingxukai@zohomail.com>
To: Stephen Boyd <sboyd@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Samuel Holland <samuel.holland@sifive.com>,
Troy Mitchell <TroyMitchell988@gmail.com>
Subject: Re: [PATCH v4 2/3] clk: canaan: Add clock driver for Canaan K230
Date: Thu, 20 Feb 2025 23:18:11 +0800 [thread overview]
Message-ID: <c76655ad-e1e4-46f1-aecd-e57716b80ee7@zohomail.com> (raw)
In-Reply-To: <364a8fbd-d78e-421d-a37b-cb7a29077802@zohomail.com>
On 2025/2/20 23:07, Xukai Wang wrote:
> On 2025/2/19 05:48, Stephen Boyd wrote:
>>> +static void k230_clk_disable(struct clk_hw *hw)
>>> +{
>>> + struct k230_clk *clk = to_k230_clk(hw);
>>> + struct k230_sysclk *ksc = clk->ksc;
>>> + struct k230_clk_cfg *cfg = &k230_clk_cfgs[clk->id];
>>> + u32 reg;
>>> +
>>> + if (!cfg->have_gate) {
>>> + dev_err(&ksc->pdev->dev, "This clock doesn't have gate\n");
>> Why are the clk_ops assigned to this clk then?
> If this clock doesn't have a gate, then the clk_ops will not be assigned to it. In this case, I'm simply checking it again. You can verify this in the k230_register_clk function to ensure it's handled correctly.
Apologies for my script doesn't wrap this paragraph.
> If you think this check is redundant, I can drop it.
next prev parent reply other threads:[~2025-02-20 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 14:45 [PATCH v4 0/3] riscv: canaan: Add support for K230-Canmv clock Xukai Wang
2025-02-17 14:45 ` [PATCH v4 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller Xukai Wang
2025-02-18 21:51 ` Stephen Boyd
2025-02-19 12:28 ` Xukai Wang
2025-02-17 14:45 ` [PATCH v4 2/3] clk: canaan: Add clock driver for Canaan K230 Xukai Wang
2025-02-18 21:48 ` Stephen Boyd
2025-02-20 15:07 ` Xukai Wang
2025-02-20 15:18 ` Xukai Wang [this message]
2025-02-17 14:45 ` [PATCH v4 3/3] riscv: dts: canaan: Add clock initial support for K230 Xukai Wang
2025-02-18 17:00 ` Conor Dooley
2025-02-18 17:36 ` Xukai Wang
2025-02-18 17:02 ` [PATCH v4 0/3] riscv: canaan: Add support for K230-Canmv clock Conor Dooley
2025-02-18 21:51 ` Stephen Boyd
2025-02-19 17:07 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76655ad-e1e4-46f1-aecd-e57716b80ee7@zohomail.com \
--to=kingxukai@zohomail.com \
--cc=TroyMitchell988@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).