devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
	frank-w@public-files.de, "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	erkin.bozoglu@xeront.com, Sean Wang <sean.wang@mediatek.com>,
	DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2
Date: Tue, 31 Jan 2023 12:55:14 +0100	[thread overview]
Message-ID: <c78e2725-0be7-caa8-40db-2f355cc2cdec@gmail.com> (raw)
In-Reply-To: <cf7d3247-4d21-98f0-819b-7653153ee4c0@arinc9.com>



On 25/01/2023 17:54, Arınç ÜNAL wrote:
> On 25.01.2023 19:41, Frank Wunderlich wrote:
>> Am 20. Januar 2023 21:53:17 MEZ schrieb "Arınç ÜNAL" <arinc.unal@arinc9.com>:
>>
>>>         switch@1f {
>>>             compatible = "mediatek,mt7530";
>>>             reg = <0x1f>;
>>> @@ -199,11 +208,6 @@ ports {
>>>                 #address-cells = <1>;
>>>                 #size-cells = <0>;
>>>
>>> -                port@0 {
>>> -                    reg = <0>;
>>> -                    label = "wan";
>>> -                };
>>> -
>>
>> This will break existing userspace setups using wan as interface name.
> 
> Yup. The OS being used will have to either rename the interface or adapt to the 
> new name, eth1.
> 

In that case please explain in the commit message why this is needed. We are 
trying really hard to not break userspace by a device-tree update.

Regards,
Matthias

  reply	other threads:[~2023-01-31 11:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230120205318.519493-1-arinc.unal@arinc9.com>
2023-01-25 15:03 ` [PATCH 0/5] arm: dts: mt7623: relocate gmacs, mt7530 switch, and mux phy Matthias Brugger
     [not found] ` <20230120205318.519493-5-arinc.unal@arinc9.com>
2023-01-25 16:41   ` [PATCH 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2 Frank Wunderlich
2023-01-25 16:54     ` Arınç ÜNAL
2023-01-31 11:55       ` Matthias Brugger [this message]
2023-01-31 16:39         ` Aw: " Frank Wunderlich
2023-02-01 17:49           ` Arınç ÜNAL
     [not found] ` <20230120205318.519493-2-arinc.unal@arinc9.com>
2023-01-25 16:45   ` [PATCH 1/5] arm: dts: mt7623: add gmacs to mt7623.dtsi Frank Wunderlich
2023-01-25 16:52     ` Arınç ÜNAL
2023-01-31 11:53       ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c78e2725-0be7-caa8-40db-2f355cc2cdec@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=arinc.unal@arinc9.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dqfext@gmail.com \
    --cc=erkin.bozoglu@xeront.com \
    --cc=frank-w@public-files.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).