From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"marex@denx.de" <marex@denx.de>,
"festevam@denx.de" <festevam@denx.de>,
"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>,
"marcel.ziswiler@toradex.com" <marcel.ziswiler@toradex.com>,
"max.krummenacher@toradex.com" <max.krummenacher@toradex.com>,
"stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
"matthias.schiffer@tq-group.com" <matthias.schiffer@tq-group.com>,
"denys.drozdov@toradex.com" <denys.drozdov@toradex.com>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM
Date: Sun, 30 Apr 2023 14:07:58 +0200 [thread overview]
Message-ID: <c7a24bac-a81d-6786-f1d3-d0f2c43cee8d@linaro.org> (raw)
In-Reply-To: <BM1PR01MB4899FB61CCDE89E83F0F4D979A689@BM1PR01MB4899.INDPRD01.PROD.OUTLOOK.COM>
On 29/04/2023 16:07, Himanshu Bhavani wrote:
> From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM
Please fix your patch format.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
>
> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> + - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
Messed order, incorrect vendor prefix. Also board name looks actually
missing.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-04-30 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 14:07 [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM Himanshu Bhavani
2023-04-30 10:13 ` Francesco Dolcini
2023-04-30 12:07 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a24bac-a81d-6786-f1d3-d0f2c43cee8d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=denys.drozdov@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=himanshu.bhavani@siliconsignals.io \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=matthias.schiffer@tq-group.com \
--cc=max.krummenacher@toradex.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).